From: Stefan Kangas <stefan@marxist.se>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 52523@debbugs.gnu.org, Juri Linkov <juri@linkov.net>
Subject: bug#52523: 29.0.50; defcustom :type 'key-sequence not following key-valid-p format
Date: Mon, 27 Dec 2021 07:41:34 -0800 [thread overview]
Message-ID: <CADwFkmm=P8Sk0YtxNHR3yVX4r=Et-XMnbzTjiVz+oRarvkhLAQ@mail.gmail.com> (raw)
In-Reply-To: <87ee5ycky0.fsf@gnus.org>
Lars Ingebrigtsen <larsi@gnus.org> writes:
>> However, if we do that the problem is that we then risk having two
>> definitions of "key sequence": both the old and the new style.
>>
>> See also (info "(elisp) Key Sequences"), that uses the old style.
>
> Yes, that's confusing. I meant to have the `key-valid-p' say what it
> accepts as a valid key binding, and then the other functions refer to it.
Do you mean here "a valid key"? A key binding AFAIU is a mapping from
"KEY => DEFINITION" as described in `keymap-set-after', and belongs in a
key map.
>> `keymap-set' says:
>>
>> Set key sequence KEY to DEFINITION in KEYMAP.
>>
>> So here is again the "new" style used as the definition of a key
>> sequence, which seems to contradict the Elisp manual.
>
> Yes. Please go ahead and fix up the doc strings. 😀
I tried to do that on master (commit 8df3a71c52), please take a look.
I also filed a number of documentation bugs separately while looking
over the info manual.
next prev parent reply other threads:[~2021-12-27 15:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 20:35 bug#52523: 29.0.50; defcustom :type 'key-sequence not following key-valid-p format Stefan Kangas
2021-12-16 17:11 ` Juri Linkov
2021-12-19 12:15 ` Lars Ingebrigtsen
2021-12-19 13:43 ` Stefan Kangas
2021-12-19 13:54 ` Lars Ingebrigtsen
2021-12-19 17:08 ` Juri Linkov
2021-12-20 6:59 ` Stefan Kangas
[not found] ` <86tuf3ptcr.fsf@mail.linkov.net>
2021-12-20 10:27 ` Lars Ingebrigtsen
2021-12-21 11:19 ` Stefan Kangas
2021-12-21 18:53 ` Juri Linkov
2021-12-22 12:41 ` Lars Ingebrigtsen
2021-12-26 16:39 ` Stefan Kangas
2021-12-27 12:05 ` Lars Ingebrigtsen
2021-12-27 15:41 ` Stefan Kangas [this message]
2021-12-28 14:32 ` Lars Ingebrigtsen
2021-12-28 3:08 ` Stefan Kangas
2021-12-28 12:51 ` Eli Zaretskii
2021-12-28 14:33 ` Lars Ingebrigtsen
2021-12-28 14:34 ` Lars Ingebrigtsen
2022-01-02 16:00 ` Stefan Kangas
2021-12-22 4:16 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmm=P8Sk0YtxNHR3yVX4r=Et-XMnbzTjiVz+oRarvkhLAQ@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=52523@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).