From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#16368: [PATCH] cperl-mode: don't freeze over a cool regexp Date: Wed, 2 Sep 2020 18:19:25 -0400 Message-ID: References: <87iotxq4oy.fsf@xvii.vinc17.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22311"; mail-complaints-to="usenet@ciao.gmane.io" To: Harald =?UTF-8?Q?J=C3=B6rg?= , 16368@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 03 00:20:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kDb6w-0005hU-EX for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Sep 2020 00:20:10 +0200 Original-Received: from localhost ([::1]:60052 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kDb6v-0005FV-Gp for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Sep 2020 18:20:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58666) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDb6o-0005FH-2h for bug-gnu-emacs@gnu.org; Wed, 02 Sep 2020 18:20:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49475) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kDb6n-0005XO-Nt for bug-gnu-emacs@gnu.org; Wed, 02 Sep 2020 18:20:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kDb6n-0007XH-KH for bug-gnu-emacs@gnu.org; Wed, 02 Sep 2020 18:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Sep 2020 22:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16368 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 16368-submit@debbugs.gnu.org id=B16368.159908517528929 (code B ref 16368); Wed, 02 Sep 2020 22:20:01 +0000 Original-Received: (at 16368) by debbugs.gnu.org; 2 Sep 2020 22:19:35 +0000 Original-Received: from localhost ([127.0.0.1]:32788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDb6M-0007WX-R5 for submit@debbugs.gnu.org; Wed, 02 Sep 2020 18:19:35 -0400 Original-Received: from mail-ed1-f54.google.com ([209.85.208.54]:38601) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDb6J-0007WI-RY for 16368@debbugs.gnu.org; Wed, 02 Sep 2020 18:19:33 -0400 Original-Received: by mail-ed1-f54.google.com with SMTP id c8so591445edv.5 for <16368@debbugs.gnu.org>; Wed, 02 Sep 2020 15:19:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :content-transfer-encoding; bh=iiIx1igfbiupHRtjXhb2vM55jQGd0IZSlM14o0P95xA=; b=clgY3AFVIgA5V5ShygYpziAqynBDd9m8iKiRMW3FYHWpqg9YNC83tlLYcBAjTKBTY3 eUK5ap9JrXVuOOHeJXhddkJgY8RIg5SdOaLIW9q7UzhYAlIeeTJkxSDZ+a6O5HoJF3ig iK70d1g1C7Nn4HWTIh1w9/wHIXKvM0SgC8QMPxkh00ncs1p4UsZXixQmSL3p+edQsfFm qjSmYf9nlX6OnwAAYgkKBUELQLYq6OFx8169OvbBD1tm+eSheGRnOAm9jAj7nAJ+uL7l nZRWSUUi6iyZieGbQ9PawbHVOp6VnhmGWo01nXkg/4tmgyuIKXI4gNjRmiaPNrBqVA2Z b3sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:content-transfer-encoding; bh=iiIx1igfbiupHRtjXhb2vM55jQGd0IZSlM14o0P95xA=; b=A8EzPQPkL8w/w5a+3TaSnB7kEuqwIppT+5UtM/LtwQBGABPJ/2ngVbYTmrNy0zbm0L ZHQpOvALjam1PfW6spYuqo7Xi286ijFfUvIXZ5BIJK7cTKFmk1MSZQwuSMw3AnyoshQp GX6jM6FcBkiPj3GawopvYV2QmPAYZH0QmWejIGeTbzEEyaY8CEYLyuedWEnwR4rpGCw6 vwEZ/tyu7yBaEKR03XWMSzAg+LuPZYR138bypYVJGMEMwAUdipDuTwRqWGPBAFhzxbAk XNNKMvgqjG3qwG03sWhXhPVwzTdfolyPVagYlZfDjw0Zwfi7tSoZ831eaJAOH/cXwUDs C3Pg== X-Gm-Message-State: AOAM531l4oGexnOXmfTOhqpdOXcQ8zkUyFu6UyP/7/K1U+90UvBpIlbS BHfeCv/6XwGyn3kHcWZ+qxwiJeYGXkNkLZ//8bk= X-Google-Smtp-Source: ABdhPJyIPvH5XoSizhJU23OVCGdUfHG296ucy+KFKGhSJ1kiF7Tp18bxmpTdhz3Wlmq7KfrcdmpDInAecUwPi/MOTok= X-Received: by 2002:a50:cd08:: with SMTP id z8mr13289edi.185.1599085165979; Wed, 02 Sep 2020 15:19:25 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 2 Sep 2020 18:19:25 -0400 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186969 Archived-At: Harald J=C3=B6rg writes: > Patch attached, including two test cases. Thanks for working on cperl-mode bugs. Testing the original recipe with your patch it is already an improvement in that it avoids the freeze. But I see these messages: cperl-forward-group-in-re: error (scan-error Unbalanced parentheses 9 94) (scan-error Unbalanced parentheses 9 94) Is that the expected and desired behavior? --- Also, some minor nits: > Subject: [PATCH] =3D?UTF-8?q?2020-09-02=3D20=3D20Harald=3D20J=3DC3=3DB6rg= =3D20=3D20 =3D?UTF-8?q?steo.de>?=3D Better first line: Fix freeze in cperl-mode when editing a regexp > * lisp/progmodes/cperl-mode.el (cperl-forward-group-in-re): Make > sure that an error is reported back to the caller (Bug#16368). > > * test/lisp/progmodes/cperl-mode-tests.el (cperl-mode-test-bug-16368): > Tests for balanced (no error) and unbalanced (caught exception) > cases of `cperl-forward-group-in-re'. Format these flush to the first column (no initial space). > --- a/test/lisp/progmodes/cperl-mode-tests.el > +++ b/test/lisp/progmodes/cperl-mode-tests.el I see this: ELC lisp/progmodes/cperl-mode-tests.elc In end of data: lisp/progmodes/cperl-mode-tests.el:73:1: Warning: the function `cperl-forward-group-in-re' is not known to be defined. You should add this line to the top: (require 'cperl-mode) Best regards, Stefan Kangas