From: Stefan Kangas <stefan@marxist.se>
To: "Jan Synáček" <jan.synacek@gmail.com>
Cc: 51262@debbugs.gnu.org
Subject: bug#51262: [PATCH] Don't use color escape sequences in `vc-git-expanded-log-entry'
Date: Mon, 18 Oct 2021 22:16:11 -0700 [thread overview]
Message-ID: <CADwFkmm9BUBMoboQaqqbC2uGDFRR1UHNKXdqn_3MWGt37kVtBA@mail.gmail.com> (raw)
In-Reply-To: <CACA+5f3dQ69DkeFf997zrs8wAQFYd1GJ5cGt6icEBYeH1wP30A@mail.gmail.com> ("Jan Synáček"'s message of "Mon, 18 Oct 2021 12:45:48 +0200")
Jan Synáček <jan.synacek@gmail.com> writes:
> From acbfec361709c5eebafb9a957e76f70500083cf0 Mon Sep 17 00:00:00 2001
> From: Jan Synacek <jan.synacek@gmail.com>
> Date: Mon, 18 Oct 2021 12:34:38 +0200
> Subject: [PATCH] Don't use color escape sequences in
> `vc-git-expanded-log-entry'
>
> * lisp/vc/vc-git.el (vc-git-expanded-log-entry): Use --no-color in git
> invocation.
>
> Copyright-paperwork-exempt: yes
> ---
> lisp/vc/vc-git.el | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el
> index 35c0838dd6..3f89fad235 100644
> --- a/lisp/vc/vc-git.el
> +++ b/lisp/vc/vc-git.el
> @@ -1323,7 +1323,7 @@ vc-git-show-log-entry
>
> (defun vc-git-expanded-log-entry (revision)
> (with-temp-buffer
> - (apply #'vc-git-command t nil nil (list "log" revision "-1" "--"))
> + (apply #'vc-git-command t nil nil (list "log" revision "-1" "--no-color" "--"))
> (goto-char (point-min))
> (unless (eobp)
> ;; Indent the expanded log entry.
Thanks for the patch.
Could you add some details here, such as what problem it is supposed to
fix? How can I reproduce the issue here, starting from emacs -Q?
next prev parent reply other threads:[~2021-10-19 5:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 10:45 bug#51262: [PATCH] Don't use color escape sequences in `vc-git-expanded-log-entry' Jan Synáček
2021-10-19 5:16 ` Stefan Kangas [this message]
2021-10-19 8:15 ` Jan Synáček
2021-10-19 8:33 ` Stefan Kangas
2021-10-19 8:53 ` Jan Synáček
2021-10-19 18:00 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmm9BUBMoboQaqqbC2uGDFRR1UHNKXdqn_3MWGt37kVtBA@mail.gmail.com \
--to=stefan@marxist.se \
--cc=51262@debbugs.gnu.org \
--cc=jan.synacek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).