unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Manuel Giraud <manuel@ledu-giraud.fr>, 58307@debbugs.gnu.org
Subject: bug#58307: 29.0.50; Fix battery mode over TRAMP on *BSD
Date: Wed, 5 Oct 2022 15:51:35 -0700	[thread overview]
Message-ID: <CADwFkmm7_6WJEvbzEpq+hyjQn3+GNn56mzyFOBdMQSCwWBmcmg@mail.gmail.com> (raw)
In-Reply-To: <87ilkyfhlo.fsf@elite.giraud>

Manuel Giraud <manuel@ledu-giraud.fr> writes:

> @@ -929,13 +933,13 @@ battery-bsd-apm
>  %t Remaining time (to charge or discharge) in the form `h:min'"
>    (let* ((os-name (car (split-string
>                          ;; FIXME: Can't we use something like `system-type'?
> -                        (shell-command-to-string "/usr/bin/uname"))))
> +                        (call-process-to-string "/usr/bin/uname"))))

Here's a minor nit:

I realize that the OpenBSD folks are not likely to move uname to /bin
(which is its location on my GNU/Linux system, for example), but I'd
probably still prefer

    (executable-find "uname")

to hard coding its location.





  parent reply	other threads:[~2022-10-05 22:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-05 14:52 bug#58307: 29.0.50; Fix battery mode over TRAMP on *BSD Manuel Giraud
2022-10-05 20:24 ` Michael Albinus
2022-10-05 22:51 ` Stefan Kangas [this message]
2022-10-06  8:17   ` Manuel Giraud
2022-10-06 12:47     ` Lars Ingebrigtsen
2022-10-06 14:34       ` Manuel Giraud
2022-10-06 18:20         ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADwFkmm7_6WJEvbzEpq+hyjQn3+GNn56mzyFOBdMQSCwWBmcmg@mail.gmail.com \
    --to=stefankangas@gmail.com \
    --cc=58307@debbugs.gnu.org \
    --cc=manuel@ledu-giraud.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).