bug#26490: 25.1; package-buffer-info is incorrectly case-insensitive

[Stefan Kangas <stefan@marxist.se>]

[-- Attachment #1: Type: text/plain, Size: 643 bytes --]

Stefan Kangas <stefan@marxist.se> writes:

> I see your point.  How about issuing a warning instead?  That should
> be sufficiently discouraging for package authors, while also allowing
> us to drop this requirement at some point in the future.
>
> I've attached a patch which I believe would do this in a reasonable way.

Ping!  Does anyone have any objections to this change, or any
comments?  I've attached the latest version of the patch.

In summary, it makes it possible to install packages even if they are
missing the terminating ";; foo.el ends here" line.  Instead, we raise
a warning for such packages.

Best regards,
Stefan Kangas

[-- Attachment #2: 0001-Allow-installation-packages-without-a-footer-line.patch --]
[-- Type: application/octet-stream, Size: 2821 bytes --]

From cbad98f4ac8029e383255ff45395b5aa01935306 Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefankangas@gmail.com>
Date: Fri, 20 Sep 2019 19:18:03 +0200
Subject: [PATCH] Allow installation packages without a "footer line"

* lisp/emacs-lisp/package.el (package-buffer-info): Warn instead of
signaling an error when there is no "footer line".  This allows such
packages to be installed.  (Bug#26490)
* etc/NEWS: Announce it.
---
 etc/NEWS                   | 15 +++++++++++++++
 lisp/emacs-lisp/package.el | 11 ++++++++---
 2 files changed, 23 insertions(+), 3 deletions(-)

diff --git a/etc/NEWS b/etc/NEWS
index 46ed40dfcb..a47c6098d4 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -1030,6 +1030,21 @@ it can't find the config file.
 
 ** Package
 
+*** Allow installation of packages missing a "footer line".
+Previously, the package system refused to install a package without
+the so-called "footer line", which should appear at the very end of
+the file:
+
+;;; FILENAME ends here
+
+Emacs will now only issue a warning for such packages.  To avoid this
+warning, packages should keep the "footer line".
+
+Note that versions of Emacs older than 27.1 will not only refuse to
+install packages without such a line -- they will be unable to parse
+the package data.  It is therefore strongly recommended to keep this
+line, even if your package only supports Emacs 27.1 or later.
+
 *** Change of 'package-check-signature' for packages with multiple sigs
 In previous Emacsen, 't' checked that all signatures are valid.
 Now 't' only checks that at least one signature is valid and the new 'all'
diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 20462064af..69ca658b81 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -1082,10 +1082,15 @@ package-buffer-info
   (let ((file-name (match-string-no-properties 1))
         (desc      (match-string-no-properties 2))
         (start     (line-beginning-position)))
-    ;; The terminating comment format could be extended to accept a
-    ;; generic string that is not in English.
+    ;; Before version 27.1, it was not possible to install packages
+    ;; without a terminating comment.  We now only issue a warning.
+    ;; This warning should probably be around until at least Emacs
+    ;; version 32.1 or so, or possibly longer.  The idea is to phase
+    ;; out the requirement for a "footer line" without unduly
+    ;; impacting users on earlier Emacs versions.  (Bug#26490)
     (unless (search-forward (concat ";;; " file-name ".el ends here"))
-      (error "Package lacks a terminating comment"))
+      (lwarn '(package package-format) :warning
+             "Package lacks a terminating comment"))
     ;; Try to include a trailing newline.
     (forward-line)
     (narrow-to-region start (point))
-- 
2.23.0