From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#10758: thumbs and image-dired to use built-in ImageMagick Date: Sun, 24 Oct 2021 02:14:32 -0700 Message-ID: References: <8xfwemx6yr.fsf@fencepost.gnu.org> <87k18jw6w0.fsf@marxist.se> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20471"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 10758@debbugs.gnu.org, Mathias Dahl To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 24 11:15:45 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1meZbV-00057q-Ax for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 Oct 2021 11:15:45 +0200 Original-Received: from localhost ([::1]:48390 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1meZbT-00031d-Sh for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 Oct 2021 05:15:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43956) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1meZap-00030g-1c for bug-gnu-emacs@gnu.org; Sun, 24 Oct 2021 05:15:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54622) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1meZao-0004WW-Q1 for bug-gnu-emacs@gnu.org; Sun, 24 Oct 2021 05:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1meZao-00065L-Kb for bug-gnu-emacs@gnu.org; Sun, 24 Oct 2021 05:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Oct 2021 09:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10758 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 10758-submit@debbugs.gnu.org id=B10758.163506688223331 (code B ref 10758); Sun, 24 Oct 2021 09:15:02 +0000 Original-Received: (at 10758) by debbugs.gnu.org; 24 Oct 2021 09:14:42 +0000 Original-Received: from localhost ([127.0.0.1]:37933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1meZaT-00064F-OQ for submit@debbugs.gnu.org; Sun, 24 Oct 2021 05:14:41 -0400 Original-Received: from mail-pj1-f50.google.com ([209.85.216.50]:41640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1meZaQ-00063z-8S for 10758@debbugs.gnu.org; Sun, 24 Oct 2021 05:14:40 -0400 Original-Received: by mail-pj1-f50.google.com with SMTP id na16-20020a17090b4c1000b0019f5bb661f9so6165889pjb.0 for <10758@debbugs.gnu.org>; Sun, 24 Oct 2021 02:14:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=4Jxb9OWgA2bBKV30KYXZe44OOXOQ1Ub7vIgBVPEx6iU=; b=VafJ1VG5KPimopYYc5E1z+k/Z5kwBhF7BSiY0pXORo7/ZY5y2Tk0g4TeSPWNCP4+8A bVaSjcfDt06fRnF4MhDAo54f88MvEljE+jfD8g6XB6HVXRW/7b1zMC5nns5Wu2ANXefk 80T2Tuy1xIxYKdCJdm/XUQTyMBg92mfXUjsCFvvXBvS008KBMbbqZbmUoDwBi2PCEt89 1JYOm54/MzGWAhfJTsknkGM9Ud9nE++gkAIAvxp7p/ZVidvCKpTVRLhZlt78oLXAGg8Z CKBkwkyfV0vhzOoOXBJiq23LTI1RcXviJR8DBJGeSYFHNQ90L63KSDcprXxmOKKpoPPp yhdg== X-Gm-Message-State: AOAM531qu71yMn8YFGuXWb111NPOHSZmA5N171uMY5ICz7Y0dTQBRC8p iN3yJOxquyUbouopCAVhzQI1tymOxPWnaZodQ5k= X-Google-Smtp-Source: ABdhPJw8qE1I1FKs5cx265TQM854X2jmBJJX9F/EtzgIVEo2QXZ+3A5Dvhl5s1DtkOPswZojUu3gMgk2H12gNOlR6+0= X-Received: by 2002:a17:90a:d917:: with SMTP id c23mr5349179pjv.133.1635066872611; Sun, 24 Oct 2021 02:14:32 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 24 Oct 2021 02:14:32 -0700 In-Reply-To: (Stefan Kangas's message of "Fri, 22 Oct 2021 23:57:42 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218081 Archived-At: Stefan Kangas writes: > So perhaps this feature request is relevant anymore. WDYT? I now see that Glenn mentioned resizing as well, where using the built-in image scaling seems very relevant. We currently jump through some unnecessary hoops in `image-dired-display-image' when we could just resize the image in memory. Is there any reason why `image-dired-display-image-mode' doesn't just inherit `image-mode'? That would avoid code duplication and also allow us to immediately benefit from any improvements to `image-mode'.