From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#55764: 29.0.50; sh-mode: Support mksh's alternate case brace syntax Date: Sat, 30 Sep 2023 19:30:53 -0700 Message-ID: References: <87o7zbp4uc.fsf@gmail.com> <87o7zbw5dz.fsf@gnus.org> <87k09zp3kh.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26296"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , 55764@debbugs.gnu.org, Stefan Monnier To: Visuwesh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 01 04:32:05 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qmmFY-0006Ug-9I for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Oct 2023 04:32:04 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qmmFH-0005WL-PW; Sat, 30 Sep 2023 22:31:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qmmFG-0005W2-I1 for bug-gnu-emacs@gnu.org; Sat, 30 Sep 2023 22:31:46 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qmmFG-0002Eo-9H for bug-gnu-emacs@gnu.org; Sat, 30 Sep 2023 22:31:46 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qmmFV-0005wO-VD for bug-gnu-emacs@gnu.org; Sat, 30 Sep 2023 22:32:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Oct 2023 02:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55764 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55764-submit@debbugs.gnu.org id=B55764.169612748222770 (code B ref 55764); Sun, 01 Oct 2023 02:32:01 +0000 Original-Received: (at 55764) by debbugs.gnu.org; 1 Oct 2023 02:31:22 +0000 Original-Received: from localhost ([127.0.0.1]:60250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmmEs-0005vC-Ai for submit@debbugs.gnu.org; Sat, 30 Sep 2023 22:31:22 -0400 Original-Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]:52474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmmEm-0005uo-Cs for 55764@debbugs.gnu.org; Sat, 30 Sep 2023 22:31:21 -0400 Original-Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-50307759b65so23846635e87.0 for <55764@debbugs.gnu.org>; Sat, 30 Sep 2023 19:31:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696127454; x=1696732254; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=HZinW4c3MK6FbF0+RTkKm84s6hZRRXiBMrQ4PTZYgfw=; b=PMRiKcYGrxLMXxkAqMX+v7kfe2jr9/VIsVW7Igizssyd7j0yPIPnz7BtjUeeFYiLaO Wgbn8ZuE7okCftNaufHriNXDo3w+dka/iioJUcTWrgbc/xaY/+65nsRcD/zW4jOSZdNO EW1yubW/nJLSB+G8LCUe4S8/o8rDkdUdt7aOxe63sOFLvy12jcoa8ZFsYHTc2g5wFYuR ZwlEBJUwgR42pcylmyUCiWo5U8DMfNM0zpNsJ/YIYkLyex2P09hVd0NyG0dgexNyTLj7 BFC/yv0FKLtJ1qSxguD75xFgumYrPERN3cjlf0U6KQRHMW1oNYFHcY22YyQ/shsW1t0q P+kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696127454; x=1696732254; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=HZinW4c3MK6FbF0+RTkKm84s6hZRRXiBMrQ4PTZYgfw=; b=grsYXLKfYMlNin5VGzc5wMMsDk/DaAqqc3OXgDmFE5WoCQuqFc4gtQ86c6ElkOjqrt zl2IbpRMYnOPWDGFONLzW6cNPxzAwD1eGUCISafzeedylY0zBSlepN0fCqqye0MmTvQW znyOKknDqPg2mdF8dKNKFDbNYt6NAh8vJ72Id2vr6y71+zIkaYG2kOwotFhMFNA0ESwh Lrhq3NfrQrjBs98PTEr05QRo5KsR2MwKJrZsK0mVFL5OZhBEWoMmnwtyJHGFqISDYoo3 N2tdN0DDyF++C5wERVAtqwrImg9dqDdOeYsiUl3wRdPGXldraGHV8vuT/Z3vRvJ59c7A lgQg== X-Gm-Message-State: AOJu0YwU4VMYWc4UF2pNOJ+Oc5wUS3aRKwRouh/i2VQ8ehMl1gZNFrlp y5Rh8nzavsIGl7MevvYcs0X6+bdchOyRRgB/eU8/M27C X-Google-Smtp-Source: AGHT+IEaGNZjnDsUzETV7w4OWFnTXJTakThoyfyJTQtfrnEmGtcCIKQzfvE0k215B5wmJeCDgtZjrYak+7nkpE/wbvg= X-Received: by 2002:a05:6512:10d5:b0:505:6cc7:e0f7 with SMTP id k21-20020a05651210d500b005056cc7e0f7mr6282075lfg.44.1696127454398; Sat, 30 Sep 2023 19:30:54 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 30 Sep 2023 19:30:53 -0700 In-Reply-To: <87k09zp3kh.fsf@gmail.com> (Visuwesh's message of "Thu, 02 Jun 2022 19:31:18 +0530") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271586 Archived-At: Visuwesh writes: > [=E0=AE=B5=E0=AE=BF=E0=AE=AF=E0=AE=BE=E0=AE=B4=E0=AE=A9=E0=AF=8D =E0=AE= =9C=E0=AF=82=E0=AE=A9=E0=AF=8D 02, 2022] Lars Ingebrigtsen wrote: > >> Visuwesh writes: >> >>> mksh and OpenBSD's ksh support an alternative case syntax for historica= l >>> reasons [1], >>> >>> case $i { >>> *pattern) do ;; >>> *pattern2) do2 ;; >>> } >>> >>> Currently, sh-mode cannot handle this and the easy way out of writing a >>> semicolon after $i is out since, >>> >>> % case "foo"; { *o) echo 1;; } >>> /bin/mksh: syntax error: unexpected ';' >>> >>> I came with the attached patch after a bit of trial and error but I'm >>> not sure if it is the right way to do it. >> >> I think that might make sense, but perhaps Stefan has some comments here >> (added to the CCs). > > To no one's surprise, the patch is not the right approach. IIUC, when I > use braces, *pattern) thingies are not recognised as "case-)" anymore so > sh-indent-for-case-label does not get applied. I tried a bit more but I > only got it to respect the first line but still it is definitely not the > right approach, Did you make any further progress here?