unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#36009: [PATCH] Use lexical-binding in textmodes/page.el and add tests
@ 2019-05-30 18:31 Stefan Kangas
  2019-06-02  1:58 ` Paul Eggert
  0 siblings, 1 reply; 8+ messages in thread
From: Stefan Kangas @ 2019-05-30 18:31 UTC (permalink / raw)
  To: 36009

[-- Attachment #1: Type: text/plain, Size: 152 bytes --]

I've written unit tests and added the lexical-binding header to
textmodes/page.el.  Please let me know if you have any comments.

Thanks,
Stefan Kangas

[-- Attachment #2: 0001-Use-lexical-binding-in-textmodes-page.el-and-add-tes.patch --]
[-- Type: text/x-patch, Size: 4464 bytes --]

From 87c2cb96d73090abe2761bd8044aa4aa5d84de90 Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefankangas@gmail.com>
Date: Tue, 28 May 2019 14:24:42 +0200
Subject: [PATCH] Use lexical-binding in textmodes/page.el and add tests

* lisp/textmodes/page.el: Use lexical-binding.
* test/lisp/textmodes/page-tests.el: New file.
---
 lisp/textmodes/page.el            |   2 +-
 test/lisp/textmodes/page-tests.el | 102 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 103 insertions(+), 1 deletion(-)
 create mode 100644 test/lisp/textmodes/page-tests.el

diff --git a/lisp/textmodes/page.el b/lisp/textmodes/page.el
index 220ef2d7fd..768ca4482f 100644
--- a/lisp/textmodes/page.el
+++ b/lisp/textmodes/page.el
@@ -1,4 +1,4 @@
-;;; page.el --- page motion commands for Emacs
+;;; page.el --- page motion commands for Emacs  -*- lexical-binding: t -*-
 
 ;; Copyright (C) 1985, 2001-2019 Free Software Foundation, Inc.
 
diff --git a/test/lisp/textmodes/page-tests.el b/test/lisp/textmodes/page-tests.el
new file mode 100644
index 0000000000..5b8622084c
--- /dev/null
+++ b/test/lisp/textmodes/page-tests.el
@@ -0,0 +1,102 @@
+;;; page-tests.el --- Tests for page.el  -*- lexical-binding: t; -*-
+
+;; Copyright (C) 2019 Free Software Foundation, Inc.
+
+;; Author: Stefan Kangas <stefankangas@gmail.com>
+
+;; This file is part of GNU Emacs.
+
+;; GNU Emacs is free software: you can redistribute it and/or modify
+;; it under the terms of the GNU General Public License as published by
+;; the Free Software Foundation, either version 3 of the License, or
+;; (at your option) any later version.
+
+;; GNU Emacs is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;; GNU General Public License for more details.
+
+;; You should have received a copy of the GNU General Public License
+;; along with GNU Emacs.  If not, see <https://www.gnu.org/licenses/>.
+
+;;; Commentary:
+
+;;; Code:
+
+(require 'ert)
+(require 'page)
+
+(defvar page-tests-page-1 "Page 1/3"
+  "Example text used to test page.el.")
+(defvar page-tests-page-2 "\nPage 2/3"
+  "Example text used to test page.el.")
+(defvar page-tests-page-3 "\nPage 3/3\nLast line"
+  "Example text used to test page.el.")
+(defvar page-tests-break "\n\f"
+  "Page break used to test page.el.")
+(defvar page-tests-example-text
+  (concat page-tests-page-1 page-tests-break
+          page-tests-page-2 page-tests-break
+          page-tests-page-3)
+  "Example text used to test page.el.")
+
+(ert-deftest page-tests-forward-page ()
+  (with-temp-buffer
+    (insert page-tests-example-text)
+    (goto-char (point-min))
+    (forward-page)
+    (should (looking-at page-tests-page-2))
+    (forward-page)
+    (should (looking-at page-tests-page-3))
+    (forward-page)
+    (should (equal (point) (point-max)))))
+
+(ert-deftest page-tests-backward-page ()
+  (with-temp-buffer
+    (insert page-tests-example-text)
+    (goto-char (point-max))
+    (backward-page)
+    (should (looking-at page-tests-page-3))
+    (backward-page)
+    (should (looking-at page-tests-page-2))
+    (backward-page)
+    (should (looking-at page-tests-page-1))
+    (should (equal (point) (point-min)))))
+
+(ert-deftest page-tests-mark-page ()
+  (with-temp-buffer
+    (insert page-tests-example-text)
+    (goto-char (point-min))
+    (mark-page)
+    (should (looking-at page-tests-page-1))
+    (should mark-active)
+    (should (equal (mark) 11))))
+
+(ert-deftest page-tests-narrow-to-page ()
+  (with-temp-buffer
+    (insert page-tests-example-text)
+    (goto-char (point-min))
+    (narrow-to-page)
+    (should (equal (buffer-string)
+                   (concat page-tests-page-1 "\n")))))
+
+(ert-deftest page-tests-count-lines-page ()
+  (with-temp-buffer
+    (insert page-tests-example-text)
+    (goto-char (point-min))
+    (should (equal (count-lines-page) "Page has 1 lines (0 + 1)"))
+    (goto-char (point-max))
+    (should (equal (count-lines-page) "Page has 3 lines (3 + 0)"))))
+
+(ert-deftest page-tests-what-page ()
+  (with-temp-buffer
+    (insert page-tests-example-text)
+    (goto-char (point-min))
+    (should (equal (what-page) "Page 1, line 1"))
+    (forward-page)
+    (should (equal (what-page) "Page 2, line 2"))
+    (forward-page)
+    (should (equal (what-page) "Page 3, line 4"))))
+
+(provide 'page-tests)
+;;; page-tests.el ends here
-- 
2.11.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-06-23  5:29 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-30 18:31 bug#36009: [PATCH] Use lexical-binding in textmodes/page.el and add tests Stefan Kangas
2019-06-02  1:58 ` Paul Eggert
2019-06-02 10:25   ` Simen Heggestøyl
2019-06-13 22:02     ` Stefan Kangas
2019-06-22 10:55       ` Simen Heggestøyl
2019-06-22 21:32         ` Stefan Kangas
2019-06-22 23:57           ` Paul Eggert
2019-06-23  5:29             ` Simen Heggestøyl

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).