From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on visual-line-mode Date: Wed, 13 Sep 2023 08:56:12 -0700 Message-ID: References: <87tu0nao77.fsf@neverwas.me> <87il8vxrr1.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29677"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-erc@gnu.org To: "J.P." , 60936@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 13 17:57:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qgSEu-0007U3-HG for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 13 Sep 2023 17:57:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qgSEc-0007nC-7Q; Wed, 13 Sep 2023 11:56:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgSEb-0007mz-DS for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2023 11:56:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qgSEb-0004y6-5V for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2023 11:56:57 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qgSEg-0006a3-E8 for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2023 11:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Sep 2023 15:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60936 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60936-submit@debbugs.gnu.org id=B60936.169462058825252 (code B ref 60936); Wed, 13 Sep 2023 15:57:02 +0000 Original-Received: (at 60936) by debbugs.gnu.org; 13 Sep 2023 15:56:28 +0000 Original-Received: from localhost ([127.0.0.1]:35731 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgSE7-0006ZE-JL for submit@debbugs.gnu.org; Wed, 13 Sep 2023 11:56:27 -0400 Original-Received: from mail-lj1-x232.google.com ([2a00:1450:4864:20::232]:52504) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgSE4-0006Yz-PI for 60936@debbugs.gnu.org; Wed, 13 Sep 2023 11:56:25 -0400 Original-Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2bfbbd55158so12803181fa.1 for <60936@debbugs.gnu.org>; Wed, 13 Sep 2023 08:56:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694620573; x=1695225373; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=VqiYl0BW3zfX9+Wg7d8i0IoNi3/osTwFSVDBJWponq4=; b=E/mYr5xKQinaoBmw4C+Ou6HrveJjC5Erkwc2bUhObc5i/JfrjAqI/r+aWMU4jIVubf 7sKNQTWZumnlCjkfcWU/zVCBOVGCnpPzng82w1ci0VK6RX1PDIFcOtSMKkjkFBeQuYYc EFlrZ/8DAacD7wD5Z9mXhUhcw43o1NjXQQiC2TdvF+pJu20cQX5YqoEVoS5Q0WQegzhB 59S9qC8iaJH5NqidlsxHjMlaxlDGqWwWvG2PMP6gXqPG4nwbZABPS46XVcILrFhoUgT+ glJRHVF17dDePFS8u8wRJUypc2172aEvunGxr9d4E7u1PUz81hYXhV4eZiBpB+jUDhCk g+eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694620573; x=1695225373; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=VqiYl0BW3zfX9+Wg7d8i0IoNi3/osTwFSVDBJWponq4=; b=K12SMFRQVwtnGJl+yL/VopSGUZTT6vLOhxxbnXUj7TvEk4Pec6m10YskCUfYAOb8uk 0z4YVh5IVtvpDY4P5gghbMj5sHNA2jnfEzMgKEsjG6cSe7SYAAUkcvaJO/RXHLBTM0VS xwJrhiB9YfHp5hkxQLgu4NWEcpuuOerKCFVZKkDGSr+RUj16eHuWfCS+x5rg+K6waNuf Qv08AjgFv5gvwin5byNnhjx7yZb8nTa3p82Z/cs6KkJjjKp/rdc4wdZUcadTMybrwgBQ +FW10gytuTVooXW+8FStE2gSPIGVZzuNCKsC85ZKP79lrQVPYQVGcBtADNV6q1Y9t1LO Vdow== X-Gm-Message-State: AOJu0YyRW9b82p+XbEyTEMk5B8cjGqKp7NwrZf3sAqZoABZW0X7oG/It XosbbcMFdVZSFAwlSkZtK49xAWrjTSpJ6ETj4Ic= X-Google-Smtp-Source: AGHT+IGXjTixofjfFem6qcypiwryypUs1kmk8bt/sSR1m1Blxz9eDN1tZUyhefg9ksXUodVdb+sZ9d/6zbNVVLsgntU= X-Received: by 2002:a2e:9849:0:b0:2b9:55c9:c228 with SMTP id e9-20020a2e9849000000b002b955c9c228mr2677727ljj.27.1694620573306; Wed, 13 Sep 2023 08:56:13 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 13 Sep 2023 08:56:12 -0700 In-Reply-To: <87il8vxrr1.fsf@neverwas.me> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270324 Archived-At: "J.P." writes: > One of my patches for this feature introduced a corner-case regression > involving the option `erc-echo-timestamps'. If `cursor-sensor-mode' is > somehow enabled outside of this module, then timestamps will still be > echoed even when `erc-echo-timestamps' is nil. > > commit ad3dc74e074719a58226e23a45c4556cd54c0a48 > Author: F. Jason Park > Date: Wed Nov 24 03:10:20 2021 -0800 > > Expose insertion time as text prop in erc-stamp > > * lisp/erc/erc-stamp.el (erc-add-timestamp): Add new text property > [...] > (erc-echo-timestamp): Make interactive and show timestamps even whe= n > the variable `erc-echo-timestamps' is nil. > (erc--echo-ts-csf): Add new function to serve as value of > cursor-sensor function text properties. > * test/lisp/erc/erc-stamp-tests.el: New file. (Bug#60936.) I'm seeing new test failures with this file on master: Running 6 tests (2023-09-13 16:45:56+0200, selector =E2=80=98(not (or (tag :expensive-test) (tag :unstable) (tag :nativecomp)))=E2=80=99) Test erc-echo-timestamp backtrace: signal(ert-test-failed (((should (equal (call-interactively #'erc-ec ert-fail(((should (equal (call-interactively #'erc-echo-timestamp) " #f(compiled-function () #)() ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name erc-echo-timestamp :documentation nil ert-run-or-rerun-test(#s(ert--stats :selector (not (or ... ... ...)) ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) ( ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/erc/erc-stamp-tests" command-line() normal-top-level() Test erc-echo-timestamp condition: (ert-test-failed ((should (equal (call-interactively ...) "1983-09-27 04:00:00 GMT")) :form (equal "1983-09-27 04:00:00 UTC" "1983-09-27 04:00:00 GMT") :value nil :explanation (array-elt 20 (different-atoms (85 "#x55" "?U") (71 "#x47" "?G"))))) FAILED 1/6 erc-echo-timestamp (0.002433 sec) at lisp/erc/erc-stamp-tests.el:277 passed 2/6 erc-stamp--display-margin-mode--right (0.009260 sec) passed 3/6 erc-timestamp-intangible--left (0.012494 sec) passed 4/6 erc-timestamp-use-align-to--integer (0.007917 sec) passed 5/6 erc-timestamp-use-align-to--nil (0.015289 sec) passed 6/6 erc-timestamp-use-align-to--t (0.024845 sec) Ran 6 tests, 5 results as expected, 1 unexpected (2023-09-13 16:45:56+0200, 0.484120 sec) 1 unexpected results: FAILED erc-echo-timestamp GEN lisp/eshell/em-dirs-tests.log make[3]: *** [lisp/erc/erc-stamp-tests.log] Error 1 In GNU Emacs 30.0.50 (build 3, x86_64-apple-darwin21.6.0, NS appkit-2113.60 Version 12.6.9 (Build 21G726)) of 2023-09-13 built on MY-MacBook-Pro Repository revision: 1f7113e68988fa0bcbdeca5ae364cba8d6db3637 Repository branch: master Windowing system distributor 'Apple', version 10.3.2113 System Description: macOS 12.6.9 Configured features: ACL GIF GMP GNUTLS JPEG JSON LCMS2 LIBXML2 MODULES NOTIFY KQUEUE NS PDUMPER PNG SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM ZLIB