unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#72182: 31.0.50; static-if defined twice
@ 2024-07-18 20:09 Philip Kaludercic
  2024-07-19 17:13 ` Jonas Bernoulli via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 1 reply; 5+ messages in thread
From: Philip Kaludercic @ 2024-07-18 20:09 UTC (permalink / raw)
  To: 72182; +Cc: Jonas Bernoulli


The `static-if' macro is currently being defined twice:  Once in
subr.el, where it probably should occur, and then again in transient,
added in

commit 4675aff76828b0747d1ac900d65d4a92a457ebf5
Author: Jonas Bernoulli <jonas@bernoul.li>
Date:   Tue Dec 5 19:59:34 2023 +0100

    Update to Transient v0.5.2

As Compat provides the definition for older versions as of the latest
release, we should probably just remove the definition in transient.

-- 
	Philip Kaludercic on peregrine





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#72182: 31.0.50; static-if defined twice
  2024-07-18 20:09 bug#72182: 31.0.50; static-if defined twice Philip Kaludercic
@ 2024-07-19 17:13 ` Jonas Bernoulli via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2024-07-19 17:43   ` Philip Kaludercic
  0 siblings, 1 reply; 5+ messages in thread
From: Jonas Bernoulli via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-07-19 17:13 UTC (permalink / raw)
  To: Philip Kaludercic, 72182

> The `static-if' macro is currently being defined twice:  Once in
> subr.el, where it probably should occur, and then again in transient,
> added in

I should have removed that when merging the standalone version into
Emacs.  I've done so now.

     Jonas





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#72182: 31.0.50; static-if defined twice
  2024-07-19 17:13 ` Jonas Bernoulli via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2024-07-19 17:43   ` Philip Kaludercic
  2024-07-19 18:07     ` Eli Zaretskii
  0 siblings, 1 reply; 5+ messages in thread
From: Philip Kaludercic @ 2024-07-19 17:43 UTC (permalink / raw)
  To: Jonas Bernoulli; +Cc: 72182

Jonas Bernoulli <jonas@bernoul.li> writes:

>> The `static-if' macro is currently being defined twice:  Once in
>> subr.el, where it probably should occur, and then again in transient,
>> added in
>
> I should have removed that when merging the standalone version into
> Emacs.  I've done so now.

Where did you change what?  I just fetched the master branch and still
find a definition of `static-if' in transient.el.

>      Jonas

-- 
	Philip Kaludercic on peregrine





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#72182: 31.0.50; static-if defined twice
  2024-07-19 17:43   ` Philip Kaludercic
@ 2024-07-19 18:07     ` Eli Zaretskii
  2024-07-19 20:13       ` Stefan Kangas
  0 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2024-07-19 18:07 UTC (permalink / raw)
  To: Philip Kaludercic; +Cc: 72182, jonas

> Cc: 72182@debbugs.gnu.org
> From: Philip Kaludercic <philipk@posteo.net>
> Date: Fri, 19 Jul 2024 17:43:52 +0000
> 
> Jonas Bernoulli <jonas@bernoul.li> writes:
> 
> >> The `static-if' macro is currently being defined twice:  Once in
> >> subr.el, where it probably should occur, and then again in transient,
> >> added in
> >
> > I should have removed that when merging the standalone version into
> > Emacs.  I've done so now.
> 
> Where did you change what?  I just fetched the master branch and still
> find a definition of `static-if' in transient.el.

Jonas (correctly) did that on the emacs-30 branch.  Will be merged to
master soon.





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#72182: 31.0.50; static-if defined twice
  2024-07-19 18:07     ` Eli Zaretskii
@ 2024-07-19 20:13       ` Stefan Kangas
  0 siblings, 0 replies; 5+ messages in thread
From: Stefan Kangas @ 2024-07-19 20:13 UTC (permalink / raw)
  To: Eli Zaretskii, Philip Kaludercic; +Cc: jonas, 72182-done

Eli Zaretskii <eliz@gnu.org> writes:

> Jonas (correctly) did that on the emacs-30 branch.  Will be merged to
> master soon.

I'm therefore closing this bug report.





^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-07-19 20:13 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-18 20:09 bug#72182: 31.0.50; static-if defined twice Philip Kaludercic
2024-07-19 17:13 ` Jonas Bernoulli via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-19 17:43   ` Philip Kaludercic
2024-07-19 18:07     ` Eli Zaretskii
2024-07-19 20:13       ` Stefan Kangas

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).