From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#8724: 23.2; js-mode imenu should be more thorough Date: Wed, 10 Jan 2024 03:55:03 -0800 Message-ID: References: <4DFE5EC4.3070103@gmail.com> <87y2bselz9.fsf@gnus.org> <96de25bd-511a-67c7-9253-1e7e29b1e021@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3938"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , Daniel Colascione , dino chiesa , 8724@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 10 12:56:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNXBw-0000l7-HW for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Jan 2024 12:56:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNXBc-00080a-Ie; Wed, 10 Jan 2024 06:55:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNXBb-00080M-AW for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 06:55:55 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNXBb-0001Fb-2J for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 06:55:55 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rNXBi-0000sH-EG for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 06:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jan 2024 11:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8724 X-GNU-PR-Package: emacs Original-Received: via spool by 8724-submit@debbugs.gnu.org id=B8724.17048877203292 (code B ref 8724); Wed, 10 Jan 2024 11:56:02 +0000 Original-Received: (at 8724) by debbugs.gnu.org; 10 Jan 2024 11:55:20 +0000 Original-Received: from localhost ([127.0.0.1]:42354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNXB2-0000r1-92 for submit@debbugs.gnu.org; Wed, 10 Jan 2024 06:55:20 -0500 Original-Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]:55554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNXAz-0000qh-OX for 8724@debbugs.gnu.org; Wed, 10 Jan 2024 06:55:18 -0500 Original-Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-555f581aed9so4711363a12.3 for <8724@debbugs.gnu.org>; Wed, 10 Jan 2024 03:55:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704887704; x=1705492504; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=VWYT732sR1QNyAVmGk+dv54voVJPNd7S+1BvoIhadlQ=; b=CcDZ0vtgOICLCQT4dKwoJJTQXMGfglboIa66tXcC05ZOe8b18sPYC6n6MDFig9sgv4 oZDhEgx5+lvifzU69Gah9FjrtIWBOsQ+776Bxsv1eXLkfZI/scM4kLerbD7e4LDVnUG5 W1HaRTTCGlI9JErxQlVGBOFSyEmscoYERi2oyC8njfhLIqvFefGlQgxgB+ojEToUFWuZ 4GQbLpMC0CXfOeBL2A26jhAG6e50QfnhC/y08WifKGaT44dQQbg9n2IZWw/smGeXn+FK Qa6vxzd4yxkqX/7Rj6YnbcZ1M7w4+lMJ4MmKLTLuZcxEqP2ERWTbvC4dAhhYXkuylPEM ecHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704887704; x=1705492504; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VWYT732sR1QNyAVmGk+dv54voVJPNd7S+1BvoIhadlQ=; b=TqnLzMY1MqxlVOPNV62W8nnJB8wv7roTUOYcM4bObuDuodu7XNj4CyRvkPrtYUDrji NOU8uEb4O4/AWZV8Ocm7N5VCjohrmN8i/cEXtY2YIXgVwUzRqpqDIXFOoKiRfUgkYCfa XvdUO3tJlBVUbTA4y49E3tGN0hJjDn0Xg/PaII/i3dBypFqpfS1n8tNCD/oUWDML7Soc OGAYu6w37i+Pr50XVs/oqwwnIpX5L6t6G/j2v3qi2gNUOq2KMX7X2+Jrdq7DWk2Xi3vl 7rXu8KXUjWpmVh7bvi+I+b3UA4/xNt6GjrPjE3CLwIVp3Y64TKVsRco4kpI2mlSA2X0I FK0w== X-Gm-Message-State: AOJu0YxgvpRfNqXYcZepy78khmcVSLw1YnyW86PvphyEckcyLZ1sH5ld GX9mqD64W/H6FEzypg96NNGazuIsM1KsXxUiP3w= X-Google-Smtp-Source: AGHT+IEZQgW04d7z/nIU46ydZEcgPtyxrIIOWeT98frHuAWiE9PZ2TD7f1RoR8OSuHsO9RpQboo/+H/uPg3vOB2ePuo= X-Received: by 2002:a50:b410:0:b0:558:5cd2:7646 with SMTP id b16-20020a50b410000000b005585cd27646mr336895edh.51.1704887704414; Wed, 10 Jan 2024 03:55:04 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 10 Jan 2024 03:55:03 -0800 In-Reply-To: <96de25bd-511a-67c7-9253-1e7e29b1e021@yandex.ru> (Dmitry Gutov's message of "Sat, 5 Jun 2021 03:24:41 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277727 Archived-At: Dmitry Gutov writes: > On 02.06.2021 10:58, Lars Ingebrigtsen wrote: >> This was nine years ago -- was there any progress with this? (It sounds >> like a good change, but I haven't looked at the code.) > > Someone should really work in that direction, since in these nine years JS has > grown more ways to define a function: e.g. arrow functions, or 'const name> = ...'. > > I've tried simply replacing the definition. > > The patch kinda works, except I'm not sure about the (top) and (bottom) items > that it adds (we don't have any precedent for this, so I vote no), and there's > some sort of duplication of the entries: I see both (top) and the enclosed > function name repeated an extra time in the imenu index. Did you make any further progress here?