From: Stefan Kangas <stefan@marxist.se>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 43682@debbugs.gnu.org
Subject: bug#43682: 28.0.50; Clean up nnimap server buffers?
Date: Mon, 11 Oct 2021 05:53:26 -0700 [thread overview]
Message-ID: <CADwFkmm+GHQstgOdiDTO9gi4B2A3E-0Vi=mSKPe1VSAyYVu4Wg@mail.gmail.com> (raw)
In-Reply-To: <87sgax6eqb.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Thu, 01 Oct 2020 10:25:00 -0700")
Eric Abrahamsen <eric@ericabrahamsen.net> writes:
> On 10/01/20 18:01 PM, Lars Ingebrigtsen wrote:
>> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>>
>>> It's possible (I'm not claiming to understand all the code) that all we
>>> would need to do is fix `gnus-async-wait-for-article' to replace its
>>> calls to `nntp-find-connection' and `nntp-accept-process-output' with
>>> something generalized. Those two functions deal with directly with
>>> `nntp-connection-alist', so we'd need something that would do the
>>> equivalent with `nnimap-connection-alist'.
>>
>> Yup.
>
> This is something I wouldn't want to tackle until we have generic
> functions.
>
>>> Anyway, in the interest of completing this far less ambitious patch: if
>>> the nnimap connection has timed out, we should remove this connection
>>> from `nnimap-connection-alist', so this version of the patch does that.
>>> If async has opened a second connection, I guess we should leave that
>>> alone, though I don't have too much confidence that the whole process
>>> will recover gracefully from the main connection dying...
>>
>> Well, the connections are separate, and there's all kinds of reasons for
>> the server to close a connection, so...
>>
>>> + (unless (memq (process-status (get-buffer-process buffer))
>>> + '(open run))
>>
>> Aka `process-live-p'.
>
> I forgot we have that!
>
>> Otherwise looks fine to me (but I haven't tested the code).
>
> Okay, I'll run this for a bit, as well.
Any news here? Should the fix be installed?
next prev parent reply other threads:[~2021-10-11 12:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 23:37 bug#43682: 28.0.50; Clean up nnimap server buffers? Eric Abrahamsen
2020-09-29 7:42 ` Robert Pluim
2020-09-29 14:51 ` Lars Ingebrigtsen
2020-09-29 18:25 ` Eric Abrahamsen
2020-09-30 1:18 ` Lars Ingebrigtsen
2020-09-30 1:21 ` Lars Ingebrigtsen
2020-09-30 21:49 ` Eric Abrahamsen
2020-10-01 1:30 ` Lars Ingebrigtsen
2020-10-01 5:09 ` Eric Abrahamsen
2020-10-01 16:01 ` Lars Ingebrigtsen
2020-10-01 17:25 ` Eric Abrahamsen
2021-10-11 12:53 ` Stefan Kangas [this message]
2021-10-11 14:41 ` Eric Abrahamsen
2021-10-12 20:50 ` Eric Abrahamsen
2021-10-12 21:33 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmm+GHQstgOdiDTO9gi4B2A3E-0Vi=mSKPe1VSAyYVu4Wg@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=43682@debbugs.gnu.org \
--cc=eric@ericabrahamsen.net \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).