From: Stefan Kangas <stefan@marxist.se>
To: Bill Wohler <wohler@newt.com>,
Stephen Gildea <stepheng+emacs@gildea.com>
Cc: 51056@debbugs.gnu.org, Lars Ingebrigtsen <larsi@gnus.org>,
mh-e-devel@lists.sourceforge.net
Subject: bug#51056: 29.0.50; Making `gnus-define-keys' obsolete
Date: Mon, 11 Oct 2021 12:46:41 -0700 [thread overview]
Message-ID: <CADwFkmkzzzxsnsJ9bz_KHXxG_sdpGxTOy=AOM5+YgeTFcbNf3w@mail.gmail.com> (raw)
In-Reply-To: <1178966.1633978812@olgas.newt.com>
Bill Wohler <wohler@newt.com> writes:
> Thanks so much for the MH-E clean-ups! They are very much appreciated.
> So far, I haven't noticed any issues with your updates.
Thank you, that is an encouraging report.
If we do break something, we can always back those commits out for
further investigation, as I already had to do in one case. The culprit
was this change, but I can't say that I understand why:
diff --git a/lisp/mh-e/mh-tool-bar.el b/lisp/mh-e/mh-tool-bar.el
index 805408cfc7..7cc0a1e83c 100644
--- a/lisp/mh-e/mh-tool-bar.el
+++ b/lisp/mh-e/mh-tool-bar.el
@@ -27,8 +27,7 @@
;;; Code:
(require 'mh-e)
-(mh-do-in-gnu-emacs
- (require 'tool-bar))
+(require 'tool-bar)
;;; Tool Bar Commands
So this innocent looking change leads to this:
In mh-tool-bar-define:
mh-e/mh-tool-bar.el:180:62: Warning: reference to free variable ‘folder-docs’
mh-e/mh-tool-bar.el:222:36: Warning: reference to free variable
‘folder-button-setter’
mh-e/mh-tool-bar.el:226:36: Warning: reference to free variable
‘sequence-button-setter’
mh-e/mh-tool-bar.el:191:34: Warning: reference to free variable ‘show-buttons’
mh-e/mh-tool-bar.el:230:36: Warning: reference to free variable
‘show-button-setter’
mh-e/mh-tool-bar.el:234:36: Warning: reference to free variable
‘show-seq-button-setter’
mh-e/mh-tool-bar.el:295:41: Warning: reference to free variable
‘letter-buttons’
mh-e/mh-tool-bar.el:296:41: Warning: reference to free variable ‘letter-docs’
mh-e/mh-tool-bar.el:245:36: Warning: reference to free variable
‘letter-button-setter’
mh-e/mh-tool-bar.el:280:51: Warning: reference to free variable
‘folder-defaults’
mh-e/mh-tool-bar.el:291:51: Warning: reference to free variable
‘letter-defaults’
mh-e/mh-tool-bar.el:194:36: Warning: reference to free variable
‘folder-vectors’
mh-e/mh-tool-bar.el:195:11: Warning: reference to free variable ‘show-vectors’
mh-e/mh-tool-bar.el:196:11: Warning: reference to free variable
‘letter-vectors’
mh-e/mh-tool-bar.el:197:14: Warning: assignment to free variable
‘folder-defaults’
mh-e/mh-tool-bar.el:199:61: Warning: assignment to free variable
‘letter-defaults’
mh-e/mh-tool-bar.el:189:11: Warning: reference to free variable
‘folder-buttons’
mh-e/mh-tool-bar.el:189:36: Warning: assignment to free variable
‘folder-buttons’
mh-e/mh-tool-bar.el:189:36: Warning: assignment to free variable
‘letter-buttons’
mh-e/mh-tool-bar.el:189:36: Warning: assignment to free variable
‘show-buttons’
mh-e/mh-tool-bar.el:189:36: Warning: assignment to free variable ‘letter-docs’
mh-e/mh-tool-bar.el:285:41: Warning: assignment to free variable ‘folder-docs’
mh-e/mh-tool-bar.el:285:41: Warning: assignment to free variable
‘folder-vectors’
mh-e/mh-tool-bar.el:285:41: Warning: assignment to free variable
‘show-vectors’
mh-e/mh-tool-bar.el:285:41: Warning: assignment to free variable
‘letter-vectors’
mh-e/mh-tool-bar.el:301:1: Error: Symbol’s value as variable is void:
folder-docs
ELC mh-e/mh-xface.elc
make[2]: *** [Makefile:316: mh-e/mh-tool-bar.elc] Error 1
Any ideas here are welcome.
next prev parent reply other threads:[~2021-10-11 19:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 10:14 bug#51056: 29.0.50; Making `gnus-define-keys' obsolete Lars Ingebrigtsen
2021-10-06 14:01 ` Stephen Gildea
2021-10-06 21:09 ` Stefan Kangas
2021-10-07 2:48 ` Stephen Gildea
2021-10-11 19:00 ` Bill Wohler
[not found] ` <1178966.1633978812@olgas.newt.com>
2021-10-11 19:46 ` Stefan Kangas [this message]
2021-10-12 10:43 ` Lars Ingebrigtsen
[not found] ` <87o87ufrq8.fsf@gnus.org>
2021-10-12 11:44 ` Stefan Kangas
2021-10-07 7:46 ` bug#51070: " Lars Ingebrigtsen
2021-10-07 16:46 ` bug#51056: " Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmkzzzxsnsJ9bz_KHXxG_sdpGxTOy=AOM5+YgeTFcbNf3w@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=51056@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=mh-e-devel@lists.sourceforge.net \
--cc=stepheng+emacs@gildea.com \
--cc=wohler@newt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).