From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#65590: bug#65602: 30.0.50; eshell-test/{elisp,subcommand}-reset-in-pipeline fails intermittently on macOS Date: Wed, 13 Sep 2023 14:10:55 -0700 Message-ID: References: <7422c797-ff06-b05b-81e9-21b349be30ef@gmail.com> <2a74d651-d8ff-6981-192f-d2820da2edee@gmail.com> <60337c54-6344-7f1b-d6c9-1a21b0d65950@gmail.com> <6d07d208-b7f0-0dd2-b80a-3e05686fef9e@gmail.com> <721e36cb-2fed-fe1b-03ca-2c003474866d@gmail.com> <93bf6090-efb3-80e5-e0fc-88265f96b04f@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34147"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael.albinus@gmx.de, 65590@debbugs.gnu.org, 65602@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 13 23:12:10 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qgX9e-0008Wd-9f for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 13 Sep 2023 23:12:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qgX9S-0001fR-BY; Wed, 13 Sep 2023 17:11:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgX9R-0001Wh-1M for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2023 17:11:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qgX9Q-0007gJ-Pu for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2023 17:11:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qgX9W-00008P-6g for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2023 17:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Sep 2023 21:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65590 X-GNU-PR-Package: emacs Original-Received: via spool by 65590-submit@debbugs.gnu.org id=B65590.1694639472438 (code B ref 65590); Wed, 13 Sep 2023 21:12:02 +0000 Original-Received: (at 65590) by debbugs.gnu.org; 13 Sep 2023 21:11:12 +0000 Original-Received: from localhost ([127.0.0.1]:36234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgX8h-00006u-CR for submit@debbugs.gnu.org; Wed, 13 Sep 2023 17:11:12 -0400 Original-Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]:55661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgX8e-00006P-7J; Wed, 13 Sep 2023 17:11:09 -0400 Original-Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-501be2d45e0so368364e87.3; Wed, 13 Sep 2023 14:11:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694639456; x=1695244256; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=ziWKl7RUqyW4gWj+YwNzbNiskQRo7s7PNWn0OxytuN0=; b=cOjjfOkDWlleVEpfHI5ekfSOmGTrP6kDNA8POMGPAhPqoUvT5uS6jw0gvL5QbedTMM 6uMoZD60HXl7aO+XJ8oUxZ3zFbKgJ7n8K0pbwrmBQ0jd3h3WOU5PZNgQTibJu8w6EYoj hTAuG2lmxGGNvVRbWCX95MQb5LtTYfWZe+k0ThTnmFcvH8FL961lA3qFD+hNipil0Wv1 8MbCDRm66t2cKRwYSjqROvyeUWw1DvbqFbxG+2nKbvo6VkaJxRW4MlbfSazWW5XYYgns 7uf6aeXH7IejDon2IH/9lD2acRSDZNJKQcQ+2X7WHx7zHM3nbYo63NXJ7Z7HZhoI1B12 W9cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694639456; x=1695244256; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ziWKl7RUqyW4gWj+YwNzbNiskQRo7s7PNWn0OxytuN0=; b=t3svM8bJVkwBUUecwKpOjnQdYH8jIuIn1D5qSPAJhiAU5RExTZNxLbJ3xc1MWDwEj8 ixzsRZljCAaEwRYs1de8X8Ft7IlcH1jQlBVFTwR+FEjMRS0JSwWj095cTJu68Znf5fiF vOzyhnyLYA4g9Bkzt+QvmxbDiWd1pjwpWiEEdGioR5xegrphasmQ2VM/O60pygqR401d LrKYdK/GiClSEuemgEwKV3S0VkcJFHThjwdhcVpri4i5ERBj6ZcJlPX5fE23+8u97nOk 6yYLy/dIr+C6MvADl2PpUDIqsE6v8EtT7q/zLRTWewu3lN79/oVWGDfT4vVYBORqkzIA PnZQ== X-Gm-Message-State: AOJu0YwaHiipJBriQ7cKSSrL7W1O5kfaGz8gj9aTPknzdCiIo33ejU8v JRXUHS/uaB/AEGgmFawg9uQB3GzGRYObroCB5pE= X-Google-Smtp-Source: AGHT+IFDJ8ZIZlUCAhPnywLplICBVbPbXyDAnYntqFYCiG3ev3MU51Zn5+0+GHu7n3mJowPwkShRzc6W1Vdu5RLiIdA= X-Received: by 2002:ac2:4a91:0:b0:4f8:ff52:93b7 with SMTP id l17-20020ac24a91000000b004f8ff5293b7mr2771290lfp.30.1694639456061; Wed, 13 Sep 2023 14:10:56 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 13 Sep 2023 14:10:55 -0700 In-Reply-To: (Stefan Kangas's message of "Wed, 13 Sep 2023 13:48:05 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270368 Archived-At: Stefan Kangas writes: > Jim Porter writes: > >> Thanks. Pushed to master as 9838f786ded. This hopefully resolves this >> bug, along with bug#59103 and bug#65601. > > Thanks for the fix, and feel free to close this bug and the others (note > that I merged some of them). > > We can always reopen this if these issues resurface. I spoke too soon, as I'm now seeing the below two failures. FAILED 42/110 esh-var-test/interp-var-indices-subcommand (0.787189 sec) at lisp/eshell/esh-var-tests.el:184 FAILED 5/11 eshell-test/eshell-command/simple (0.670351 sec) at lisp/eshell/eshell-tests.el:41 I'm trying to reproduce it a second time, but they don't always show up. Meanwhile, here is the complete log: Running 110 tests (2023-09-13 22:35:13+0200, selector =E2=80=98(not (or (ta= g :expensive-test) (tag :unstable) (tag :nativecomp)))=E2=80=99) Loading em-alias... Loading em-banner... Loading em-basic... Loading em-cmpl... Loading em-extpipe... Loading em-glob... Loading em-hist... Loading em-ls... Loading em-pred... Loading em-prompt... Loading em-script... Loading em-term... Loading em-unix... passed 1/110 esh-var-test/alias/export (0.088465 sec) passed 2/110 esh-var-test/alias/function (0.002535 sec) passed 3/110 esh-var-test/alias/function-pair (0.001671 sec) passed 4/110 esh-var-test/alias/local-variables (0.005713 sec) passed 5/110 esh-var-test/alias/string (0.003960 sec) passed 6/110 esh-var-test/alias/string/prefer-lisp (0.002671 sec) passed 7/110 esh-var-test/alias/symbol (0.003753 sec) passed 8/110 esh-var-test/alias/symbol-pair (0.002834 sec) passed 9/110 esh-var-test/columns-var (0.002136 sec) passed 10/110 esh-var-test/command-interp (0.001959 sec) passed 11/110 esh-var-test/command-interp-splice (0.002680 sec) passed 12/110 esh-var-test/export (0.002692 sec) passed 13/110 esh-var-test/gid-var (0.001037 sec) passed 14/110 esh-var-test/inside-emacs-var (0.003868 sec) passed 15/110 esh-var-test/inside-emacs-var-split-indices (0.002742 s= ec) passed 16/110 esh-var-test/interp-cmd (0.010029 sec) passed 17/110 esh-var-test/interp-cmd-external (0.109887 sec) passed 18/110 esh-var-test/interp-cmd-external-indices (0.119196 sec) passed 19/110 esh-var-test/interp-cmd-indices (0.017139 sec) passed 20/110 esh-var-test/interp-concat-cmd (0.230823 sec) passed 21/110 esh-var-test/interp-concat-cmd-external (0.113160 sec) passed 22/110 esh-var-test/interp-concat-cmd2 (0.006122 sec) passed 23/110 esh-var-test/interp-concat-lisp (0.002987 sec) passed 24/110 esh-var-test/interp-concat-lisp2 (0.002998 sec) passed 25/110 esh-var-test/interp-convert-cmd-multiline (0.006679 sec= ) passed 26/110 esh-var-test/interp-convert-cmd-number (0.001994 sec) passed 27/110 esh-var-test/interp-convert-cmd-split-indices (0.003176= sec) passed 28/110 esh-var-test/interp-convert-cmd-string-newline (0.001614 sec) passed 29/110 esh-var-test/interp-convert-quoted-var-number (0.004028= sec) passed 30/110 esh-var-test/interp-convert-quoted-var-split-indices (0.002890 sec) passed 31/110 esh-var-test/interp-convert-var-number (0.002947 sec) passed 32/110 esh-var-test/interp-convert-var-split-indices (0.007150= sec) passed 33/110 esh-var-test/interp-lisp (0.001717 sec) passed 34/110 esh-var-test/interp-lisp-indices (0.001671 sec) passed 35/110 esh-var-test/interp-list-var (0.001838 sec) passed 36/110 esh-var-test/interp-list-var-concat (0.001501 sec) passed 37/110 esh-var-test/interp-quoted-var (0.003192 sec) passed 38/110 esh-var-test/interp-quoted-var-concat (0.003008 sec) passed 39/110 esh-var-test/interp-temp-cmd (0.015746 sec) passed 40/110 esh-var-test/interp-var (0.001530 sec) passed 41/110 esh-var-test/interp-var-assoc (0.004526 sec) Test esh-var-test/interp-var-indices-subcommand backtrace: signal(ert-test-failed (((should (eshell-command-result--equal comma ert-fail(((should (eshell-command-result--equal command (eshell-test eshell-command-result-equal("echo $eshell-test-value[${*echo 0} ${*e #f(compiled-function () #)() ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name esh-var-test/interp-var-indices-subco ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) ( ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/eshell/esh-var-tests command-line() normal-top-level() Test esh-var-test/interp-var-indices-subcommand condition: Command logs: command: "echo $eshell-test-value[${*echo 0} ${*echo 2}]" ---------------------------------------- [process] started external process =E2=80=98echo=E2=80=99 ---------------------------------------- [process] sentinel for external process =E2=80=98echo=E2= =80=99: "finished " ---------------------------------------- [process] finished external process =E2=80=98echo=E2=80= =99 ---------------------------------------- [process] started external process =E2=80=98echo=E2=80=99 ---------------------------------------- [process] received output from process =E2=80=98echo=E2= =80=99 2 ---------------------------------------- [process] sentinel for external process =E2=80=98echo=E2= =80=99: "finished " ---------------------------------------- [process] finished external process =E2=80=98echo=E2=80= =99 (ert-test-failed ((should (eshell-command-result--equal command (eshell-test-command-result command) result)) :form (eshell-command-result--equal "echo $eshell-test-value[${*echo 0} ${*echo 2}]" (nil "two") ("zero" "two")) :value nil :explanation (nonequal-result (command "echo $eshell-test-value[${*echo 0} ${*echo 2}]") (result (nil "two")) (expected ("zero" "two"))))) FAILED 42/110 esh-var-test/interp-var-indices-subcommand (0.787189 sec) at lisp/eshell/esh-var-tests.el:184 passed 43/110 esh-var-test/interp-var-indices/list (0.019358 sec) passed 44/110 esh-var-test/interp-var-indices/ring (0.020269 sec) passed 45/110 esh-var-test/interp-var-indices/split (0.037000 sec) passed 46/110 esh-var-test/interp-var-indices/vector (0.026923 sec) passed 47/110 esh-var-test/interp-var-length-alist (0.010415 sec) passed 48/110 esh-var-test/interp-var-length-list (0.006603 sec) passed 49/110 esh-var-test/interp-var-length-string (0.002292 sec) passed 50/110 esh-var-test/interp-var-regexp-split-indices (0.242747 = sec) passed 51/110 esh-var-test/interp-var-splice (0.002365 sec) passed 52/110 esh-var-test/interp-var-splice-concat (0.004213 sec) passed 53/110 esh-var-test/interp-var-string-split-indices (0.016318 = sec) passed 54/110 esh-var-test/last-arg-var (0.009780 sec) passed 55/110 esh-var-test/last-arg-var-indices (0.039239 sec) passed 56/110 esh-var-test/last-arg-var-split-indices (0.028203 sec) passed 57/110 esh-var-test/last-result-var (0.006147 sec) passed 58/110 esh-var-test/last-result-var-ext-cmd (0.266221 sec) passed 59/110 esh-var-test/last-result-var-split-indices (0.010959 se= c) passed 60/110 esh-var-test/last-result-var-twice (0.006037 sec) passed 61/110 esh-var-test/last-status-var-ext-cmd (0.231988 sec) passed 62/110 esh-var-test/last-status-var-lisp-command (0.009926 sec= ) passed 63/110 esh-var-test/last-status-var-lisp-form (0.006611 sec) passed 64/110 esh-var-test/last-status-var-lisp-form-2 (0.005176 sec) passed 65/110 esh-var-test/lines-var (0.002246 sec) passed 66/110 esh-var-test/local-variables (0.006088 sec) passed 67/110 esh-var-test/pager-var/default (0.003803 sec) passed 68/110 esh-var-test/pager-var/set (0.005817 sec) passed 69/110 esh-var-test/pager-var/set-locally (0.012370 sec) passed 70/110 esh-var-test/pager-var/unset (0.005745 sec) passed 71/110 esh-var-test/path-var/local-directory (0.002657 sec) Tramp: Sending command =E2=80=98exec sh -i=E2=80=99 Tramp: Found remote shell prompt on =E2=80=98SK-MacBook-Pro=E2=80=99 passed 72/110 esh-var-test/path-var/preserve-across-hosts (0.633738 s= ec) passed 73/110 esh-var-test/path-var/remote-directory (0.008255 sec) passed 74/110 esh-var-test/path-var/set (0.002298 sec) passed 75/110 esh-var-test/path-var/set-locally (0.006185 sec) passed 76/110 esh-var-test/quote-interp-var-indices-subcommand (0.200504 sec) passed 77/110 esh-var-test/quoted-interp-cmd (0.003089 sec) passed 78/110 esh-var-test/quoted-interp-cmd-indices (0.003972 sec) passed 79/110 esh-var-test/quoted-interp-concat-cmd (0.002686 sec) passed 80/110 esh-var-test/quoted-interp-convert-cmd-multiline (0.002652 sec) passed 81/110 esh-var-test/quoted-interp-convert-cmd-number (0.002783= sec) passed 82/110 esh-var-test/quoted-interp-convert-cmd-split-indices (0.003088 sec) passed 83/110 esh-var-test/quoted-interp-convert-cmd-string-newline (0.004199 sec) passed 84/110 esh-var-test/quoted-interp-convert-quoted-var-number (0.006084 sec) passed 85/110 esh-var-test/quoted-interp-convert-quoted-var-split-indices (0.004098 sec) passed 86/110 esh-var-test/quoted-interp-convert-var-number (0.002988= sec) passed 87/110 esh-var-test/quoted-interp-convert-var-split-indices (0.004272 sec) passed 88/110 esh-var-test/quoted-interp-lisp (0.001916 sec) passed 89/110 esh-var-test/quoted-interp-lisp-indices (0.003084 sec) passed 90/110 esh-var-test/quoted-interp-list-var (0.001994 sec) passed 91/110 esh-var-test/quoted-interp-list-var-concat (0.001896 se= c) passed 92/110 esh-var-test/quoted-interp-quoted-var (0.002696 sec) passed 93/110 esh-var-test/quoted-interp-temp-cmd (0.014113 sec) passed 94/110 esh-var-test/quoted-interp-var (0.001652 sec) passed 95/110 esh-var-test/quoted-interp-var-assoc (0.003079 sec) passed 96/110 esh-var-test/quoted-interp-var-indices (0.006305 sec) passed 97/110 esh-var-test/quoted-interp-var-length-alist (0.004078 s= ec) passed 98/110 esh-var-test/quoted-interp-var-length-list (0.005522 se= c) passed 99/110 esh-var-test/quoted-interp-var-length-string (0.001733 = sec) passed 100/110 esh-var-test/quoted-interp-var-regexp-split-indices (0.006641 sec) passed 101/110 esh-var-test/quoted-interp-var-splice (0.001625 sec) passed 102/110 esh-var-test/quoted-interp-var-splice-concat (0.001853 = sec) passed 103/110 esh-var-test/quoted-interp-var-split-indices (0.004032 = sec) passed 104/110 esh-var-test/quoted-interp-var-string-split-indices (0.011405 sec) passed 105/110 esh-var-test/set/env-var (0.002622 sec) passed 106/110 esh-var-test/set/symbol (0.001815 sec) passed 107/110 esh-var-test/setq (0.001772 sec) passed 108/110 esh-var-test/uid-var (0.001575 sec) passed 109/110 esh-var-test/unset/env-var (0.002218 sec) passed 110/110 esh-var-test/unset/symbol (0.001740 sec) Ran 110 tests, 109 results as expected, 1 unexpected (2023-09-13 22:35:17+0200, 3.917546 sec) 1 unexpected results: FAILED esh-var-test/interp-var-indices-subcommand Running 11 tests (2023-09-13 22:35:15+0200, selector =E2=80=98(not (or (tag :expensive-test) (tag :unstable) (tag :nativecomp)))=E2=80=99) Loading em-alias... Loading em-banner... Loading em-basic... Loading em-cmpl... Loading em-extpipe... Loading em-glob... Loading em-hist... Loading em-ls... Loading em-pred... Loading em-prompt... Loading em-script... Loading em-term... Loading em-unix... passed 1/11 eshell-test/command-running-p (0.091010 sec) [echo]+ Done (/bin/echo hi) passed 2/11 eshell-test/eshell-command/background (0.127438 sec) [echo]+ Done (/bin/echo hi) [cat]+ Done (/bin/cat) passed 3/11 eshell-test/eshell-command/background-pipeline (0.128145 = sec) passed 4/11 eshell-test/eshell-command/pipeline (0.082343 sec) Test eshell-test/eshell-command/simple backtrace: signal(ert-test-failed (((should (equal (buffer-string) "hi\n")) :fo ert-fail(((should (equal (buffer-string) "hi\n")) :form (equal "" "h #f(compiled-function () #)() ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name eshell-test/eshell-command/simple :do ert-run-or-rerun-test(#s(ert--stats :selector (not (or ... ... ...)) ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) ( ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/eshell/eshell-tests" command-line() normal-top-level() Test eshell-test/eshell-command/simple condition: (ert-test-failed ((should (equal (buffer-string) "hi\n")) :form (equal "" "hi\n") :value nil :explanation (arrays-of-different-length 0 3 "" "hi\n" first-mismatch-at 0))) FAILED 5/11 eshell-test/eshell-command/simple (0.670351 sec) at lisp/eshell/eshell-tests.el:41 passed 6/11 eshell-test/flush-output (0.006822 sec) passed 7/11 eshell-test/forward-arg (0.004067 sec) passed 8/11 eshell-test/get-old-input (0.001915 sec) passed 9/11 eshell-test/get-old-input/rerun-command (0.007355 sec) passed 10/11 eshell-test/get-old-input/run-output (0.002997 sec) passed 11/11 eshell-test/queue-input (1.041617 sec) Ran 11 tests, 10 results as expected, 1 unexpected (2023-09-13 22:35:17+0200, 2.483635 sec) 1 unexpected results: FAILED eshell-test/eshell-command/simple GEN lisp/format-spec-tests.log make[3]: *** [lisp/eshell/eshell-tests.log] Error 1 make[3]: *** [lisp/eshell/esh-var-tests.log] Error 1