* bug#66556: 30.0.50; Missing choice in eglot-report-progress :type
@ 2023-10-15 13:40 Mauro Aranda
2023-10-15 13:45 ` Mauro Aranda
0 siblings, 1 reply; 5+ messages in thread
From: Mauro Aranda @ 2023-10-15 13:40 UTC (permalink / raw)
To: 66556
The docstring for eglot-report-progress says it value may be messages,
but its :type is just boolean.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#66556: 30.0.50; Missing choice in eglot-report-progress :type
2023-10-15 13:40 bug#66556: 30.0.50; Missing choice in eglot-report-progress :type Mauro Aranda
@ 2023-10-15 13:45 ` Mauro Aranda
2023-10-15 14:24 ` Stefan Kangas
0 siblings, 1 reply; 5+ messages in thread
From: Mauro Aranda @ 2023-10-15 13:45 UTC (permalink / raw)
To: 66556
[-- Attachment #1: Type: text/plain, Size: 40 bytes --]
tags 66556 patch
quit
Patch attached.
[-- Attachment #2: 0001-Fix-eglot-report-progress-type.patch --]
[-- Type: text/x-patch, Size: 1075 bytes --]
From 89b13f8dccd0cc14e78e9d953375da6dcc034103 Mon Sep 17 00:00:00 2001
From: Mauro Aranda <maurooaranda@gmail.com>
Date: Sun, 15 Oct 2023 10:43:50 -0300
Subject: [PATCH] Fix eglot-report-progress :type
* lisp/progmodes/eglot.el (eglot-report-progress): Change :type to
choice, to allow 'messages' as a value. (Bug#66556)
---
lisp/progmodes/eglot.el | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index e511df01850..da92647bc93 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -467,7 +467,9 @@ eglot-report-progress
"If non-nil, show progress of long running LSP server work.
If set to `messages', use *Messages* buffer, else use Eglot's
mode line indicator."
- :type 'boolean
+ :type '(choice (const :tag "Don't show progress" nil)
+ (const :tag "Show progress in *Messages*" messages)
+ (const :tag "Show progress in Eglot's mode line indicator" t))
:version "1.10")
(defcustom eglot-ignored-server-capabilities (list)
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* bug#66556: 30.0.50; Missing choice in eglot-report-progress :type
2023-10-15 13:45 ` Mauro Aranda
@ 2023-10-15 14:24 ` Stefan Kangas
2023-10-15 15:00 ` Mauro Aranda
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Kangas @ 2023-10-15 14:24 UTC (permalink / raw)
To: Mauro Aranda, 66556; +Cc: João Távora
Mauro Aranda <maurooaranda@gmail.com> writes:
> Patch attached.
Thanks, but this patch is against master, right? Should it be fixed in
emacs-29 as well?
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#66556: 30.0.50; Missing choice in eglot-report-progress :type
2023-10-15 14:24 ` Stefan Kangas
@ 2023-10-15 15:00 ` Mauro Aranda
2023-10-21 10:06 ` Stefan Kangas
0 siblings, 1 reply; 5+ messages in thread
From: Mauro Aranda @ 2023-10-15 15:00 UTC (permalink / raw)
To: Stefan Kangas, 66556; +Cc: João Távora
On 15/10/23 11:24, Stefan Kangas wrote:
> Mauro Aranda <maurooaranda@gmail.com> writes:
>
>> Patch attached.
>
> Thanks, but this patch is against master, right?
Right.
> Should it be fixed in emacs-29 as well?
There's no sign of eglot-handle-notification checking for a value of
messages in eglot-report-progress in emacs-29. So I don't think
anything needs to be changed there. Of course, João would know better.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#66556: 30.0.50; Missing choice in eglot-report-progress :type
2023-10-15 15:00 ` Mauro Aranda
@ 2023-10-21 10:06 ` Stefan Kangas
0 siblings, 0 replies; 5+ messages in thread
From: Stefan Kangas @ 2023-10-21 10:06 UTC (permalink / raw)
To: Mauro Aranda, 66556-done; +Cc: João Távora
Version: 30.1
Mauro Aranda <maurooaranda@gmail.com> writes:
> There's no sign of eglot-handle-notification checking for a value of
> messages in eglot-report-progress in emacs-29. So I don't think
> anything needs to be changed there. Of course, João would know better.
Thanks, so I installed the patch on master.
[1: cb89cbc406e]: 2023-10-21 12:05:31 +0200
Fix eglot-report-progress :type
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=cb89cbc406efeeadbb46eb6f4d81827c7c2caf94
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-10-21 10:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-15 13:40 bug#66556: 30.0.50; Missing choice in eglot-report-progress :type Mauro Aranda
2023-10-15 13:45 ` Mauro Aranda
2023-10-15 14:24 ` Stefan Kangas
2023-10-15 15:00 ` Mauro Aranda
2023-10-21 10:06 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).