From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#30085: 25.2: Documentation for cua-rectangle-mark-mode Date: Sat, 19 Oct 2019 03:21:52 +0200 Message-ID: References: <20180112071426.uq2x3nlcs6jo57hm@E15-2016.optimum.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="104361"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 30085@debbugs.gnu.org, Kim Storm To: Boruch Baum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 19 03:23:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iLdSY-000R1s-9R for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Oct 2019 03:23:10 +0200 Original-Received: from localhost ([::1]:47632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLdSX-0004Pk-09 for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Oct 2019 21:23:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42749) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLdSR-0004PZ-6F for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2019 21:23:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iLdSQ-0002yV-3m for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2019 21:23:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42916) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iLdSQ-0002yO-0u for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2019 21:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iLdSP-0002MQ-RV for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2019 21:23:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <20180112071426.uq2x3nlcs6jo57hm@E15-2016.optimum.net> Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Oct 2019 01:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30085 X-GNU-PR-Package: emacs Original-Received: via spool by 30085-submit@debbugs.gnu.org id=B30085.15714481319009 (code B ref 30085); Sat, 19 Oct 2019 01:23:01 +0000 Original-Received: (at 30085) by debbugs.gnu.org; 19 Oct 2019 01:22:11 +0000 Original-Received: from localhost ([127.0.0.1]:51737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iLdRb-0002LE-Cn for submit@debbugs.gnu.org; Fri, 18 Oct 2019 21:22:11 -0400 Original-Received: from mail-pf1-f176.google.com ([209.85.210.176]:34344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iLdRZ-0002L1-BW for 30085@debbugs.gnu.org; Fri, 18 Oct 2019 21:22:09 -0400 Original-Received: by mail-pf1-f176.google.com with SMTP id b128so4891854pfa.1 for <30085@debbugs.gnu.org>; Fri, 18 Oct 2019 18:22:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=d6y7M/F9oUPPhVF/VgU+Skw8HgMliimTBld+6iBc8kg=; b=kYO5ShD/ZGzwFPgY++ITFuL9+VPJ8MvjsAbC2+gZIE4kNBmjaIghOHsLPcyB/q2HAD tv9T9vQlGkOTEgY2ggSBuKTSt9Xsn1x7qDFRPK91HC2Pn5J0fXH7Z8emEnJfHe6Fj611 sv/9YpwS8M82zAiV9CRFklpVUfwZgxLW3ZsdMSnKt22zZgoOLOpdcpHTcuhXM6wFqYPJ 2CLK1Q61NyvyejbqiVpCdYQFWpNhJDc/7GWKoed3ld6L2R27F+hioiI5f47DcXMF3B9U MHOfSFAwGd9oWzuvB2qrG1aGxtwrsCPQAibjCSDz8xo0V/7T9awiawTxPRdbq59GM4Ax mFBg== X-Gm-Message-State: APjAAAVABY/2/ezsXRWsrfuhX4l9fuDFgwXUAWHkdRyv6bwbhLAgiP0c gkmfA0YaKmH7n3YGk+fiqzlsip/TuAJwBAhct98= X-Google-Smtp-Source: APXvYqztEmGeu/mIZjtzM8w3s+KhzUtljG60sNQaSj/rOWqyzIoMOFb/uxfJPK6U6doNIBkmnKvZ52eZr5k72mipz48= X-Received: by 2002:a17:90a:1b2a:: with SMTP id q39mr14371217pjq.119.1571448123356; Fri, 18 Oct 2019 18:22:03 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169691 Archived-At: Boruch Baum writes: > I had some time to look at the pacakge, and produced some notes and a > patch file, before realizing that it would be a good idea to consult > with you both before continuing and possibly wasting a lot of my > volunteer time-budget. That was in March 2018, but it seems like you unfortunately never got a reply here. Are you still working on this? Could you send the patch you wrote? > @Eli: In many places in the code, there exist in-line documentation that > would be appropriate as a doc-string; however, those cases are mostly > internal functions of the form `cua--foo', so the question arose for me: > is there emacs policy NOT to produce doc-strings for such functions. It's better if they have a doc string even if they are internal functions. It could make sense to rework comments into doc strings, but I don't know the specifics in this case. > @Kim & @ELi: My initial notes and patch file are attached, for feedback > if I got anything wrong, and for approval of the proposed changes: > > 1. The docstring issue, until I realized I should ask. > > 2. @Kim: At the end of the first diff block, I noted an issue about the > `cua--last-killed-rectangle' data structure. Could you set me right > about it? > > 3. I noticed that `M-m' was bound to `cua-copy-rectangle-as-text' > instead of `back-to-indentation', so I took the liberty of writing a > function `cua-resize-rectangle-back-to-indentation' and binding it to > `M-m', which is what most users would expect. If this approved, to > what should be bound `cua-copy-rectangle-as-text' > > 4. Function `cua-resize-rectangle-bot' had a bug in that it always > placed point at the actual (point-max) even though the rectangle > corner would not be there. This would occur when (point-max) was at a > column number smaller than the left edge of the rectangle. The patch > file includes the fix. > > 5. Two commonly used navigation functions, normally bound to `C-a' and > `C-e' were not remapped. (DONE) > > 6. The help message is remapped from `C-?' to `M-?' for the sanity of > people like me who use emacs-nox and can only perform a `C-?' by > typing `C-x @ c ?'. > > 7. The current keybindings are made using an old method of keystroke > definition that I find a bit scary. Is it OK / desirable to change > the method uniformly to use `kbd'? > > First slow steps. Best regards, Stefan Kangas