From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#59458: [PATCH] Fix tracing for advanced scoring Date: Thu, 7 Sep 2023 14:07:57 -0700 Message-ID: References: <20221121213055.2387178-1-stlman@poczta.fm> <831qpsyaar.fsf@gnu.org> <877czkf8g3.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25489"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Lars Ingebrigtsen , 59458@debbugs.gnu.org, =?UTF-8?Q?=C5=81ukasz?= Stelmach To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 07 23:09:08 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qeMFP-0006PI-Rs for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Sep 2023 23:09:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qeMFJ-0007To-SV; Thu, 07 Sep 2023 17:09:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeMFI-0007NU-FZ for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2023 17:09:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qeMFI-000600-7C for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2023 17:09:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qeMFK-0007ig-0t for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2023 17:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Sep 2023 21:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59458 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59458-submit@debbugs.gnu.org id=B59458.169412089029612 (code B ref 59458); Thu, 07 Sep 2023 21:09:01 +0000 Original-Received: (at 59458) by debbugs.gnu.org; 7 Sep 2023 21:08:10 +0000 Original-Received: from localhost ([127.0.0.1]:41523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeMET-0007hY-Pq for submit@debbugs.gnu.org; Thu, 07 Sep 2023 17:08:10 -0400 Original-Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]:47187) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeMEP-0007gi-IR for 59458@debbugs.gnu.org; Thu, 07 Sep 2023 17:08:08 -0400 Original-Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-5007f3d3235so2328546e87.2 for <59458@debbugs.gnu.org>; Thu, 07 Sep 2023 14:08:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694120878; x=1694725678; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=UWvvDK4mMdqcID08NZirGV4rxV+AvVAWoch+8bj4z44=; b=DzVJhoU1m+hcKiE1aeWLCB4O6LA22UTZiSSdk9wPU8zOlTYVyhkvLip3up4fiBFVsO JElRT/k43o6Vr8Cihe346LNOGhA6YJMjAwPAdEXno+wtgexn1tGxHCmiGQqb51/Qzvb2 kSFVcmTcQSqsYdDl835f1De6glqg2HgSWpSzKTTLeHYnEb1EvLd6kekmLls2hm4bP/mT 9DSduR+n8llA0U5Vnu6Gn+ufvH62T5kpX9KpEE17T2UTzcb+xmmMlnZO1rkO6WqfJ0+9 iknNsU7kPEi4dDW1J/92Mot6mr7HZ1PGljdXV/7FXWPfgLLnuKmBp3X6ZsZVM65AdWxx p7nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694120878; x=1694725678; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=UWvvDK4mMdqcID08NZirGV4rxV+AvVAWoch+8bj4z44=; b=qNt7qoByiUzlw8u0RMxfiKC//0w94Ul8sjk4vRtxpC3awjitrhm760+OWF0V/O53v3 qF9lwyh+IXttGnWKSTqAyquVnwrwn3MSdRXRU71AjZvqz7xZFRSO68TpaaoNP8VCAr0K z6J/jQNPrNOoi+k9U9bpaSDn8asYUMdyzySS9CA0wP847+XdYis1555HQ3fpuDHK9XN3 dGqhrdTwR6VRXs3PsbxnKJjaV2PGAcuI94btFr0r4ZMgG9H+lTmoJvWHVy0vxPAbcW3q cq7CGd+6h5rJBNbxTnyuubG6sRZXVEerjp4ImfOmiwKcMbU/I8e//Z3ZeuShu63kmuP4 pZJQ== X-Gm-Message-State: AOJu0YxllQXbjqWH7MIpGR/lSNsHQJ+76biUqfgPYqr1d1RA0gBQ+JLf Rck8/cQDzYFg58d66EXvxrT+7rcW4rkKC3s32OY= X-Google-Smtp-Source: AGHT+IFwpE51S2RGQM6wYIwcdRTAulKGdvw3kriRZSd7toYeX9rElP4HcMv7KIZUwlBS87IPSf7rga2tPEql9T/SXVE= X-Received: by 2002:a05:6512:238e:b0:500:91c1:9642 with SMTP id c14-20020a056512238e00b0050091c19642mr480188lfv.21.1694120877609; Thu, 07 Sep 2023 14:07:57 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 7 Sep 2023 14:07:57 -0700 In-Reply-To: <877czkf8g3.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Thu, 24 Nov 2022 11:39:40 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269700 Archived-At: Eric Abrahamsen writes: > Eli Zaretskii writes: > >>> Cc: =C5=81ukasz Stelmach >>> From: =C5=81ukasz Stelmach >>> Date: Mon, 21 Nov 2022 22:30:55 +0100 >>> >>> * lisp/gnus/gnus-logic.el (gnus-score-advanced): Move the tracing >>> code outside of if so it's executed for both branches. > > I'm not very familiar with this code (this is actually the first I'm > hearing of gnus-logic.el), so I hope Lars will chime in. It makes sense > that tracing should happen whether or not the rule matched? But what > about the sexp before that? Would we be pushing the mail-header-number > and new score to `gnus-newsgroup-score' only if the rule *wasn't* > successful? > > I think this one should wait for Lars. If we don't hear from him and > it's holding things up, I can look more closely. Eric, It would be great if you could help review this. Thanks in advance.