From: Stefan Kangas <stefankangas@gmail.com>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: "Eli Zaretskii" <eliz@gnu.org>,
"Lars Ingebrigtsen" <larsi@gnus.org>,
59458@debbugs.gnu.org, "Łukasz Stelmach" <stlman@poczta.fm>
Subject: bug#59458: [PATCH] Fix tracing for advanced scoring
Date: Thu, 7 Sep 2023 14:07:57 -0700 [thread overview]
Message-ID: <CADwFkmktKbcFeuQ=3G8ztgbihxz4wQ=nZFtWEgAbGg2GaQ-xmg@mail.gmail.com> (raw)
In-Reply-To: <877czkf8g3.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Thu, 24 Nov 2022 11:39:40 -0800")
Eric Abrahamsen <eric@ericabrahamsen.net> writes:
> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> Cc: Łukasz Stelmach <stlman@poczta.fm>
>>> From: Łukasz Stelmach <stlman@poczta.fm>
>>> Date: Mon, 21 Nov 2022 22:30:55 +0100
>>>
>>> * lisp/gnus/gnus-logic.el (gnus-score-advanced): Move the tracing
>>> code outside of if so it's executed for both branches.
>
> I'm not very familiar with this code (this is actually the first I'm
> hearing of gnus-logic.el), so I hope Lars will chime in. It makes sense
> that tracing should happen whether or not the rule matched? But what
> about the sexp before that? Would we be pushing the mail-header-number
> and new score to `gnus-newsgroup-score' only if the rule *wasn't*
> successful?
>
> I think this one should wait for Lars. If we don't hear from him and
> it's holding things up, I can look more closely.
Eric,
It would be great if you could help review this. Thanks in advance.
next prev parent reply other threads:[~2023-09-07 21:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 21:30 bug#59458: [PATCH] Fix tracing for advanced scoring Łukasz Stelmach
2022-11-24 9:24 ` Eli Zaretskii
2022-11-24 19:39 ` Eric Abrahamsen
2023-09-07 21:07 ` Stefan Kangas [this message]
2023-09-08 6:04 ` Eli Zaretskii
2023-09-12 0:07 ` Eric Abrahamsen
2023-09-12 0:32 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmktKbcFeuQ=3G8ztgbihxz4wQ=nZFtWEgAbGg2GaQ-xmg@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=59458@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=eric@ericabrahamsen.net \
--cc=larsi@gnus.org \
--cc=stlman@poczta.fm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).