From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#58801: [PATCH] Autoload the `calc-eval-error' variable Date: Sun, 5 Nov 2023 08:38:21 -0800 Message-ID: References: <87fsfaa56t.fsf@rfc20.org> <8735ak6pq7.fsf@rfc20.org> <87o7std54i.fsf@rfc20.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="368"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58801-done@debbugs.gnu.org To: Matt Armstrong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 05 17:39:45 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qzgA4-000ATp-K2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Nov 2023 17:39:44 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qzg9p-0008RY-HE; Sun, 05 Nov 2023 11:39:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qzg9l-0008Qr-GE for bug-gnu-emacs@gnu.org; Sun, 05 Nov 2023 11:39:26 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qzg9l-0007L3-7d for bug-gnu-emacs@gnu.org; Sun, 05 Nov 2023 11:39:25 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qzgAL-00008t-R0 for bug-gnu-emacs@gnu.org; Sun, 05 Nov 2023 11:40:01 -0500 Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Nov 2023 16:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 58801 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 58801@debbugs.gnu.org, stefankangas@gmail.com, matt@rfc20.org Original-Received: via spool by 58801-done@debbugs.gnu.org id=D58801.1699202348462 (code D ref 58801); Sun, 05 Nov 2023 16:40:01 +0000 Original-Received: (at 58801-done) by debbugs.gnu.org; 5 Nov 2023 16:39:08 +0000 Original-Received: from localhost ([127.0.0.1]:38090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzg9T-00007N-Ks for submit@debbugs.gnu.org; Sun, 05 Nov 2023 11:39:07 -0500 Original-Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]:55780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzg9R-00006l-Hf for 58801-done@debbugs.gnu.org; Sun, 05 Nov 2023 11:39:06 -0500 Original-Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2c501bd6ff1so52195151fa.3 for <58801-done@debbugs.gnu.org>; Sun, 05 Nov 2023 08:38:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699202302; x=1699807102; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=w0YWn4Wu8t/tdGSMrIedTNPDrI+lZ+zejMv3oNkuHfg=; b=NNvVPSHwxjBuQix0Sh3vHDNXw7La67wt4tyKKpD+YL4GNY9+8jMI3VgWH8t+5JChcj Of8CUbpIljZoUDsvavmtV0d9z6a5jRyaCFqiW/mLQ3Cisnkscovn6UG6rrZUv3cvu0zI fs7VcbpNhuEsFYwDsVbL+WLq+DSksoWq6wz1JKDaZXvggfXnGyVZOBlV973GpJC5NYuG V+N8rqcTw1PDZVWq3wQ69ECww2bB+tpZR3MY3Pc8782flYJ0qL/8UaxhHZ/7fkR5oeQt Hphj5ROMfnB4Fg9yN+ehHMrO4ZetCdE+KmOtUqmGm7JT5rJO1sj5f4YH6qJiuFRyPojy oqcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699202302; x=1699807102; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=w0YWn4Wu8t/tdGSMrIedTNPDrI+lZ+zejMv3oNkuHfg=; b=t3lcUvERncHuiY0ddFDG47dQ4KVb1YmNWe14pzbL7VVYggSJ8lOlfOemc0NMLub/IM 1MqQr4TtVmCWr2Vfd7ycZbB0jM8od4MAioU7m/ojtBVhIqU6V/2i1zn6jflEmidQZ5TJ qOis2EQvpLUUOxD1Bveedc/dyJf398r2AsbKvHOcgGWStAHDkNRjOR/E5dYhCpQ/rAz5 5MeBasyA75UZu87E+E6/+dm/s1WqaUfFcilmSk0tfB4vo3324vkPgxG7JruTYll13lUw P/Dd0ew/3yK9liRWUu7/SXB3vgO2MV2OwR29eEeRBQ4voZRGNzbd2lOR/PjgUGE3ZVmb oP8g== X-Gm-Message-State: AOJu0YxXFvDHRF5Rj7wve3XReAitQhZjAKacPOtl7XXsTfRja0UFcUMd j32cqTP+eZF5LaQvA1UWW/4IdAmz6zpuRfqoaVw9f2qe X-Google-Smtp-Source: AGHT+IGDQd8ANpn73xoBU99FqlxwAOWdVxu98S+ChvzKWzFp6LR4/5fHW2h0d3IK9X89PL70rMLxMbKqcKsQT8U1lZc= X-Received: by 2002:a05:651c:2203:b0:2c5:128c:fae8 with SMTP id y3-20020a05651c220300b002c5128cfae8mr25815325ljq.30.1699202302393; Sun, 05 Nov 2023 08:38:22 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 5 Nov 2023 08:38:21 -0800 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273832 Archived-At: Version: 30.1 Stefan Kangas writes: > We typically avoid autoloading variables, and I'm not sure it's > justified here. See (info "(elisp) When to Autoload") for details. > > Could we instead just declare it in calc.el? I believe that should > silence any warnings from the byte-compiler. It's a one line change: > > (defvar calc-eval-error) > > Or will that not work in your use case for some reason? > >> (In the particular case of the Calc package, dozens of functions and >> variables are already autoloaded. The omission of `calc-eval-error' >> also seems more an oversight than intentional.) > > FWIW, I couldn't find any autoloaded variables in calc-loaddefs.el. > What am I missing? No further comments here within 2 months, so I've pushed the above proposed fix to master, and I'm closing this bug. If this is still an issue, please reply to this email (use "Reply to all" in your email client) and we can reopen the bug report. [1: ad82bc9b29e]: 2023-11-05 17:36:21 +0100 Declare calc-eval-error in calc.el https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=ad82bc9b29eacad29a441bbb4e87bd09ef1ff1c4