From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#65475: 29.1; package-selected-packages variable is not updated when the last package is deleted Date: Sat, 26 Aug 2023 14:07:05 +0200 Message-ID: References: <61352d45-21a6-466b-be7b-7755a6260356@gmail.com> <83a5uemfxy.fsf@gnu.org> <87o7iutg4i.fsf@posteo.net> <87fs46ovun.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20674"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Andrey Samsonov , Eli Zaretskii , Stefan Monnier , 65475@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 26 14:08:09 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qZs5I-00059G-So for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 26 Aug 2023 14:08:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qZs59-0004wA-K1; Sat, 26 Aug 2023 08:07:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZs57-0004vz-Ej for bug-gnu-emacs@gnu.org; Sat, 26 Aug 2023 08:07:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qZs57-0005qX-3Y for bug-gnu-emacs@gnu.org; Sat, 26 Aug 2023 08:07:57 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qZs5C-00058B-39 for bug-gnu-emacs@gnu.org; Sat, 26 Aug 2023 08:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Aug 2023 12:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65475 X-GNU-PR-Package: emacs Original-Received: via spool by 65475-submit@debbugs.gnu.org id=B65475.169305165119684 (code B ref 65475); Sat, 26 Aug 2023 12:08:02 +0000 Original-Received: (at 65475) by debbugs.gnu.org; 26 Aug 2023 12:07:31 +0000 Original-Received: from localhost ([127.0.0.1]:41856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZs4g-00057P-Ru for submit@debbugs.gnu.org; Sat, 26 Aug 2023 08:07:31 -0400 Original-Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]:60575) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZs4e-00057C-8t for 65475@debbugs.gnu.org; Sat, 26 Aug 2023 08:07:29 -0400 Original-Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-500a398cda5so2767153e87.0 for <65475@debbugs.gnu.org>; Sat, 26 Aug 2023 05:07:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693051637; x=1693656437; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=EOxI6okbD0rBVNgwBJLYigrQi+JHHjigMh+MhLhrovY=; b=QfIpkkfyA+4aVFyFqKRMVTx/HmSxYlYOsOS5/jv3YCropLNorbjfmyP4mxfgTDJrcY 4MrD+H7cDYaAYsxUMJZ9qOGM2Y8udEXdhrFW6YgRVaKBHiVDAHDEISrOZ8LZPNb7+HbR IlwOCYuTIIYo8F71cmyS/+48Hh/VnJXUb/GCLeI0TkGBa6GzMs0ny2VE+duhFPndsOYZ 4//shLHyQiJyOyhW086Jxi25pd0BxxsjnrR8jrO1z2qEZwV/3zasx/y7OXq/MhW9mo+v qRUhufY1h0N1I7yd2DFM9hd9TXnsIkvQc3wlKlHAigPDSlqP2vETWWTm63YopZKIs2zY ihbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693051637; x=1693656437; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EOxI6okbD0rBVNgwBJLYigrQi+JHHjigMh+MhLhrovY=; b=ICyqKCQ6kuy53fbG9Pka4NdiMPLGqvY81W59YKmDcc50QqAwirG1It41eNdWAKOUhB B7EwUpUQEyPoQcAHVclFXPQRk9Qs5jRWfSZFtip/wpn6Da94VE4eMHRzufgBeXTmLoL9 lcgBx0Gc7M839N2JPnARE9jg1iuNkiz09epJCbVcCzzrKl8ohFWdk7sSEe5qPBAFJ0g7 ZLpG26m4Wzd42+yDpXvmc9S0orVUhCVBeNl/9F4krfCO8RyVmaRd9KvrzrZBW5Heefdk zUqkZxEoOwY+P+E+6GjTlHcy7zqj9OXlYd1m4P+oczqHtdQPGE/prH2nuuxxy3JdY3Ix mBoQ== X-Gm-Message-State: AOJu0YyiWx08cYr4a3B0ulvTOq36TVCzvXnlEWs3/aF5lD63JXH9F26a vjS2W3Ryc8mml9Pqk3us9TX0+sKuvE/w9lwOOR0= X-Google-Smtp-Source: AGHT+IEEhajeWdyI3kbvauJz2Q1h/MsOGgy/ePmIKqQRAAP+tvVzzrGmL9tdzJO3A2SA7eey+Jeq4wIOJxbtrz1abXo= X-Received: by 2002:a05:6512:b20:b0:4fe:1681:9377 with SMTP id w32-20020a0565120b2000b004fe16819377mr14547366lfu.44.1693051636943; Sat, 26 Aug 2023 05:07:16 -0700 (PDT) In-Reply-To: <87fs46ovun.fsf@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268503 Archived-At: Philip Kaludercic writes: > > (defun package--save-selected-packages (&optional value) > > "Set and save `package-selected-packages' to VALUE." > > - (when value > > + (when (or value after-init-time) > > (setq package-selected-packages value)) > > (if after-init-time > > (customize-save-variable 'package-selected-packages > > package-selected-packages) > > It seems to be that this should also work, given that > `package--save-selected-packages' is a package.el internal function, and > there are no assurances that the current behaviour is to be expected in > this edge-case. Given the docstring "Set and save `package-selected-packages' to VALUE.", it is my impression that the above patch would simply fix a regression introduced in d0a5162fd825.