From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#72532: [PATCH] ; lisp/progmodes/which-func.el (which-function-mode): check buffer Date: Fri, 9 Aug 2024 09:45:25 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19897"; mail-complaints-to="usenet@ciao.gmane.io" To: Raffael Stocker , 72532@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 09 11:47:53 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1scMDx-0004yd-25 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 09 Aug 2024 11:47:53 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1scMDe-0001Bs-Uy; Fri, 09 Aug 2024 05:47:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1scMDe-0001Bk-DK for bug-gnu-emacs@gnu.org; Fri, 09 Aug 2024 05:47:34 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1scMDe-0002ED-4F for bug-gnu-emacs@gnu.org; Fri, 09 Aug 2024 05:47:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:MIME-Version:References:In-Reply-To:From:To:Subject; bh=r7neEqE5PZybfRouIpoUZ26RntNAyCZT9w++W87s8CE=; b=u078dOUV6AH4mTxWizpPfg4dA53pnj8yywen7x7pmzkJa4nuAhQGxNVUNbSJ700r2bxSqSaYOFxxJH5tVQGmHtIvkJsjzcXI1fLvFmoA4PT217oUod2BQ9fnesFuk9oDPPau2wmY6kiuHILe6rhfaJu5tbb8MSLC4DqxtkgprVFiO3Wsye4T+3xi3k07qbqAGYDcDsj86hmFW3n2qasX1ufPWBciCOMPnodAOS+x9Kg+gdtf21JMmAcjl1sngjmt7KeDrma7lyhNrhiNnfxOaNIgaKyYSadU/Y25kyR5H48HAFtr0R/yKKBhAzuaGX+3o2vvY3rz15aRse5nBSTk0g==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1scME5-0001u3-Ql for bug-gnu-emacs@gnu.org; Fri, 09 Aug 2024 05:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Aug 2024 09:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72532 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 72532-submit@debbugs.gnu.org id=B72532.17231968237239 (code B ref 72532); Fri, 09 Aug 2024 09:48:01 +0000 Original-Received: (at 72532) by debbugs.gnu.org; 9 Aug 2024 09:47:03 +0000 Original-Received: from localhost ([127.0.0.1]:37698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1scMD8-0001sc-Dy for submit@debbugs.gnu.org; Fri, 09 Aug 2024 05:47:02 -0400 Original-Received: from mail-ed1-f46.google.com ([209.85.208.46]:42160) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1scMD6-0001s9-3I for 72532@debbugs.gnu.org; Fri, 09 Aug 2024 05:47:00 -0400 Original-Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5b8c2a6135eso2809047a12.0 for <72532@debbugs.gnu.org>; Fri, 09 Aug 2024 02:46:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723196726; x=1723801526; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=r7neEqE5PZybfRouIpoUZ26RntNAyCZT9w++W87s8CE=; b=HprxQSuU/atw6bZId07rpzcBT4KE1od1YxXXqYSpBK9R1zTT9zb2yOj5ELIMx8BMpH FgkcVzobd3UlP642/Rg8nK59jLnVctE+6c8sQDTBRCtESK3OtifQgANbN1yy3QfMcMQ8 gI9MdsFF9a0B6rNfcjjLLgMac/Ll5lz3ByMN5V1XFTUo7McR4061z8Jdh3fREwBMWvMB ECGo8pdM9ydPEz5tlzJUGpNwmHh5ttvQAYWHl1wQvGeiHrCgPbbDTrSrU4kjhgyIUB0T LJbqejLrSbZ93RgSpgw1FXX/lF2qQ8meiR5Qf5iOtnx06CELt41uN3DWzjqAJ7/GpJIo XPxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723196726; x=1723801526; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=r7neEqE5PZybfRouIpoUZ26RntNAyCZT9w++W87s8CE=; b=LqDTFi2LVKWsRsdEYbp9xIAG0NugNuHU+w/Mt43pyotuumaysVLrQPvor634hInMmZ HBoZ3CzFDYWdC2oCousHOZMRIjYefTxIl4PEY87oJ5/j9TMm1mibDhJpMT7Tlh9/NyEC qd3NeRK9DJaVN86sMLEt0xhoptiP/LCQggQuppKhY62rNngZUEML3PNNL40VrEiTZgx+ MXiUGFGmE1vsEQFpUB8pU3YukuSsuAO0B3AB30vu8lrQK3bDxpezP8Snzkrd+xCUdA/p zwEOUwxaI26+uc5+Ss2SfSmvW4bCl5yQ63AkAi4F0ZFaV/iAxPV4qSrJe3vGYwd8oOQf i/WA== X-Forwarded-Encrypted: i=1; AJvYcCWsHun9VOX22v4u0IQdAbPO34pzD9F01F99B3JKSDMEMPJCV/QLNZI8bgO9RRS8xgIA3TbhXD5MXDEPuAy+Y2KMbUfDxJk= X-Gm-Message-State: AOJu0Yz40p1TNgGHAqH66gFf32r12RrvO5od0MGGb0vuDqgeMpO9h9wC J6k9j7vf9Ai0/bsZFJab8S7RMXXfl2PCjhROWd1BeafP4r3/ZGRjDOoXl0NrgVMtbAWCeOCQ1vH 4NO/wNOm2Cyk9uoO9d4aU47B+zSc= X-Google-Smtp-Source: AGHT+IEnSKVp6fqBGxN1QyC9AkTCUB2LfCEw5KCv7V3g/Ubw/crrvZPGIPn5WUgHJslpoFeNKGvqt1NOcKV0c8dBPTw= X-Received: by 2002:a05:6402:3585:b0:5a2:bfd1:b892 with SMTP id 4fb4d7f45d1cf-5bbb3c41273mr4332120a12.11.1723196726083; Fri, 09 Aug 2024 02:45:26 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 9 Aug 2024 09:45:25 +0000 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289963 Archived-At: Raffael Stocker writes: > From cd8b170f2c716cf67623c4ffc4ae38dc63c49496 Mon Sep 17 00:00:00 2001 > From: Raffael Stocker > Date: Thu, 8 Aug 2024 21:38:14 +0200 > Subject: [PATCH] ; lisp/progmodes/which-func.el (which-function-mode): check > buffer > > Ensure we are not selecting a deleted buffer. > --- > lisp/progmodes/which-func.el | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/lisp/progmodes/which-func.el b/lisp/progmodes/which-func.el > index 28aacd335ba..5326be5e877 100644 > --- a/lisp/progmodes/which-func.el > +++ b/lisp/progmodes/which-func.el > @@ -309,9 +309,10 @@ which-function-mode > (setq which-func-update-timer > (run-with-idle-timer which-func-update-delay t #'which-func-update))) > (dolist (buf (buffer-list)) > - (with-current-buffer buf > - (which-func--header-line-remove) > - (which-func-ff-hook)))) > + (when (buffer-live-p buf) > + (with-current-buffer buf > + (which-func--header-line-remove) > + (which-func-ff-hook))))) `buffer-list' is documented to return a list of all live buffers, so it would be good to understand why buffers are getting killed in this loop. In other words, are we sure that your patch is not just covering up some problem elsewhere? > > (defvar which-function-imenu-failed nil > "Locally t in a buffer if `imenu--make-index-alist' found nothing there.") > -- > 2.46.0