From: Stefan Kangas <stefankangas@gmail.com>
To: Stephen Berman <stephen.berman@gmx.net>
Cc: 44068@debbugs.gnu.org
Subject: bug#44068: 28.0.50; Faulty uses of tabulated-list-format
Date: Fri, 30 Oct 2020 23:51:21 +0000 [thread overview]
Message-ID: <CADwFkmksAXV5Uo6gTK0k3HhK9sCPVU+MfC2Ua4aH1p7jyzj+GA@mail.gmail.com> (raw)
In-Reply-To: <875z6rmlrj.fsf@rub.de>
Stephen Berman <stephen.berman@gmx.net> writes:
> It seems to. I did experiment a bit with the width when I made the
> patch just for the selected column and thought the length I used there
> gave the best results, but maybe that was too cautious. Does this patch
> give better results (it differs from the previous one only in the
> lengths checked and used for truncating):
I think this looks very good, yes. It works fully as I would expect, at
least: it seems to always correctly show the sorting indicator and the
ellipsis.
(I tested using list-buffers, list-bookmarks, list-packages,
list-processes, list-dynamic-libraries, org-lint and
flymake-diagnostics-buffer-mode.)
Perhaps we could just go over the list above as you did in your first
patch and make sure that there is enough space for all of these to show
a sorting indicator without it touching the next column label.
> It might be better to take more width parameters into account, as
> tabulated-list-print-col does, but that seems rather more complicated
> and I currently don't have time to pursue it.
I imagine we can come back to and improve on this later.
> I wish I had more time for it but at the moment I don't.
What you have here is already a big improvement, thank you.
I would recommend to push this to master.
next prev parent reply other threads:[~2020-10-30 23:51 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-18 20:00 bug#44068: 28.0.50; Faulty uses of tabulated-list-format Stephen Berman
2020-10-18 21:33 ` Drew Adams
2020-10-18 22:01 ` Stefan Kangas
2020-10-18 22:15 ` Drew Adams
2020-10-18 22:18 ` Stephen Berman
2020-10-18 22:01 ` Stefan Kangas
2020-10-18 22:17 ` Stephen Berman
2020-10-18 22:35 ` Stephen Berman
2020-10-18 23:13 ` Stefan Kangas
2020-10-19 9:04 ` Stephen Berman
2020-10-19 13:52 ` Eli Zaretskii
2020-10-19 18:20 ` Stephen Berman
2020-10-19 18:43 ` Eli Zaretskii
2020-10-19 19:12 ` Stephen Berman
2020-10-20 16:09 ` Stephen Berman
2020-10-29 16:58 ` Stefan Kangas
2020-10-29 22:48 ` Stephen Berman
2020-10-30 1:06 ` Stefan Kangas
2020-10-30 21:44 ` Stephen Berman
2020-10-30 23:51 ` Stefan Kangas [this message]
2020-11-01 23:07 ` Stephen Berman
2020-11-02 17:12 ` Eli Zaretskii
2020-11-02 22:37 ` Stephen Berman
2020-11-03 3:27 ` Eli Zaretskii
2020-11-03 23:12 ` Stephen Berman
2020-11-04 15:09 ` Eli Zaretskii
2020-11-04 22:55 ` Stephen Berman
2020-11-04 12:02 ` Stefan Kangas
2020-11-04 22:53 ` Stephen Berman
2020-11-12 16:38 ` Stefan Kangas
2020-11-12 22:51 ` Stephen Berman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmksAXV5Uo6gTK0k3HhK9sCPVU+MfC2Ua4aH1p7jyzj+GA@mail.gmail.com \
--to=stefankangas@gmail.com \
--cc=44068@debbugs.gnu.org \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).