From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#48079: Temporary files while building after native-comp merge Date: Sun, 2 May 2021 05:12:24 -0500 Message-ID: References: <835z06hanw.fsf@gnu.org> <83y2d2fv6c.fsf@gnu.org> <87r1ipimla.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000e2c2d605c15614d8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14407"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Andrea Corallo , 48079@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 02 12:13:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ld966-0003dk-Na for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 May 2021 12:13:10 +0200 Original-Received: from localhost ([::1]:44756 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ld965-0006GG-Qn for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 May 2021 06:13:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47060) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ld95y-0006Fs-Ae for bug-gnu-emacs@gnu.org; Sun, 02 May 2021 06:13:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58678) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ld95y-0001DU-34 for bug-gnu-emacs@gnu.org; Sun, 02 May 2021 06:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ld95x-00013d-UE for bug-gnu-emacs@gnu.org; Sun, 02 May 2021 06:13:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 May 2021 10:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48079 X-GNU-PR-Package: emacs Original-Received: via spool by 48079-submit@debbugs.gnu.org id=B48079.16199503544057 (code B ref 48079); Sun, 02 May 2021 10:13:01 +0000 Original-Received: (at 48079) by debbugs.gnu.org; 2 May 2021 10:12:34 +0000 Original-Received: from localhost ([127.0.0.1]:41990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ld95V-00013I-Mn for submit@debbugs.gnu.org; Sun, 02 May 2021 06:12:34 -0400 Original-Received: from mail-pg1-f179.google.com ([209.85.215.179]:46613) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ld95T-000133-1q for 48079@debbugs.gnu.org; Sun, 02 May 2021 06:12:32 -0400 Original-Received: by mail-pg1-f179.google.com with SMTP id q9so1658407pgl.13 for <48079@debbugs.gnu.org>; Sun, 02 May 2021 03:12:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=/tmhCYkw6SaXm3plkf04YxG1yBBCpMmXOTBbawswTTQ=; b=Jzjnaq6Mex1gunuFZJzdDlD5hG1Uq9A1umtiiTWqi7/AH6IsspbL6t4PAIf9Oh7SE5 0wZ+6K9M/1iAvs6YLbalVr+ZJRhVqLKoBSDugbQUlU1Tr/wIO53bck/4BFxvn75rSW4X acnU7ObQmN1FMQmPGBApL3JZJ28mWes425QIGKGNGMwOm94kmiVFUgoNyIdzgdMX0HSb HrizBLMDn1WQoAlqu9gIjhAshpBtYr45O2Xdn/67HxLjFU70QXrRqUeezSe0sTbS9jqn eTLqAbKlqn5eHoKrH/qhgkggTvP/37yIUDlE79BZUbtxF62jmD5WgEVNOTkskbJkuE1r wn2Q== X-Gm-Message-State: AOAM531nza1JPVXrWJvQHUQmpswgqwyQrjrDJdRLSPwKD+06Lx1F6tXM rIu58CF80T+/CIOYhyJQpvcaw7zjHhp+11sm0i4= X-Google-Smtp-Source: ABdhPJxKQ4ukJZa/AiXAb/Uyw8EmrywmBlTmA670spO72WvAx16+f+CQJwIyVgg2LAjq9S6p/OSDy3SDbxXnFJ3dGH4= X-Received: by 2002:a65:6386:: with SMTP id h6mr11130765pgv.67.1619950345236; Sun, 02 May 2021 03:12:25 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 2 May 2021 05:12:24 -0500 In-Reply-To: <87r1ipimla.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205418 Archived-At: --000000000000e2c2d605c15614d8 Content-Type: text/plain; charset="UTF-8" tags 48079 - patch thanks Lars Ingebrigtsen writes: > Stefan Kangas writes: > >> But perhaps the fix is as simple as: >> >> diff --git a/.gitignore b/.gitignore >> index fcbc9cd7f4..e27ebe36d0 100644 >> --- a/.gitignore >> +++ b/.gitignore >> @@ -135,6 +135,7 @@ src/gl-stamp >> *.dll >> *.core >> *.elc >> +*.elc[0-9A-Za-z][0-9A-Za-z][0-9A-Za-z][0-9A-Za-z][0-9A-Za-z][0-9A-Za-z] >> *.eln >> *.o >> *.res > > Sounds like a good idea to me. (But add a comment about what these > files are.) Thanks. But now I am seeing that some of these files have not been deleted in my tree: lisp/emacs-lisp/comp.elcivrXZS lisp/window.elc9aaVMg This might be because I interrupted the build process at some point; I don't know. These files don't get removed when I run extraclean or bootstrap. So if we just ignore them there is a risk that these files will slowly build up over time. Perhaps we should also make sure they get cleaned up when building, as in the attached. Another alternative, arguably more correct, would be to figure out exactly under which circumstances these files gets left over and delete them there. (There is a let-bound `kill-emacs-hook' in `byte-compile-file', which might be a good place to start looking.) What makes this a bit tricky is that this is somewhat hard to reproduce. --000000000000e2c2d605c15614d8 Content-Type: text/x-diff; charset="US-ASCII"; name="0001-Delete-temporary-.elcXXXXXX-files-created-when-compi.patch" Content-Disposition: attachment; filename="0001-Delete-temporary-.elcXXXXXX-files-created-when-compi.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: 377026a40a13826e_0.1 RnJvbSA1NGE1N2E3Nzc5NjhkYzVhZTEyMjU2YTY2MWFkMmQ1NDhjYzliZmQwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5AbWFyeGlzdC5zZT4KRGF0 ZTogVGh1LCAyOSBBcHIgMjAyMSAxMzoxNjoxMyArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIERlbGV0 ZSB0ZW1wb3JhcnkgKi5lbGNYWFhYWFggZmlsZXMgY3JlYXRlZCB3aGVuIGNvbXBpbGluZwoKKiBs aXNwL01ha2VmaWxlLmluIChjb21waWxlLWNsZWFuKToKKiB0ZXN0L01ha2VmaWxlLmluIChjbGVh bik6IERlbGV0ZSBsZWZ0LW92ZXIgKi5lbGNYWFhYWFggZmlsZXMgY3JlYXRlZAp3aGVuIGNvbXBp bGluZy4KCiogLmdpdGlnbm9yZTogSWdub3JlIHRlbXBvcmFyeSAqLmVsY1hYWFhYWCBmaWxlcyBj cmVhdGVkIHdoZW4KY29tcGlsaW5nLiAgKEJ1ZyM0ODA3OSkKLS0tCiAuZ2l0aWdub3JlICAgICAg IHwgMyArKysKIGxpc3AvTWFrZWZpbGUuaW4gfCAyICsrCiB0ZXN0L01ha2VmaWxlLmluIHwgMiAr LQogMyBmaWxlcyBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYg LS1naXQgYS8uZ2l0aWdub3JlIGIvLmdpdGlnbm9yZQppbmRleCBmY2JjOWNkN2Y0Li4xNDg4MmI1 MzUzIDEwMDY0NAotLS0gYS8uZ2l0aWdub3JlCisrKyBiLy5naXRpZ25vcmUKQEAgLTE0OCw2ICsx NDgsOSBAQCBvby1zcGQvCiBzcmMvKi5tYXAKIHZnY29yZS4qWzAtOV0KIAorIyBUZW1wb3Jhcnkg ZmlsZXMgd2hlbiBieXRlLWNvbXBpbGluZy4KKyouZWxjWzAtOUEtWmEtel1bMC05QS1aYS16XVsw LTlBLVphLXpdWzAtOUEtWmEtel1bMC05QS1aYS16XVswLTlBLVphLXpdCisKICMgVGVzdHMuCiB0 ZXN0L21hbnVhbC9iaWRpdGVzdC50eHQKIHRlc3QvbWFudWFsL2V0YWdzL3NyY2xpc3QKZGlmZiAt LWdpdCBhL2xpc3AvTWFrZWZpbGUuaW4gYi9saXNwL01ha2VmaWxlLmluCmluZGV4IGI5NzA0NTFk ZDIuLmRlMmM4ZmNhZDEgMTAwNjQ0Ci0tLSBhL2xpc3AvTWFrZWZpbGUuaW4KKysrIGIvbGlzcC9N YWtlZmlsZS5pbgpAQCAtMzQ1LDYgKzM0NSw3IEBAIGNvbXBpbGUtbWFpbjoKIAogLlBIT05ZOiBj b21waWxlLWNsZWFuCiAjIEVyYXNlIGxlZnQtb3ZlciAuZWxjIGZpbGVzIHRoYXQgZG8gbm90IGhh dmUgYSBjb3JyZXNwb25kaW5nIC5lbCBmaWxlLgorIyBBbHNvIGVyYXNlIGFueSBsZWZ0LW92ZXIg dGVtcG9yYXJ5IGZpbGVzIHN1Y2ggYXMgIiouZWxjaXZyWFpTIi4KIGNvbXBpbGUtY2xlYW46CiAJ QGNkICQobGlzcCkgJiYgXAogCWVsY3M9YGVjaG8gIiR7U1VCRElSU19SRUx9ICIgfCBzZWQgLWUg J3N8L1wuL3wvfGcnIC1lICdzfC9cLiB8IHxnJyAtZSAnc3wgfC8qLmVsYyB8ZydgOyBcCkBAIC0z NTQsNiArMzU1LDcgQEAgY29tcGlsZS1jbGVhbjoKIAkgICAgcm0gIiQke2VsfWMiOyBcCiAJICBm aTsgXAogCWRvbmUKKwlmaW5kICQobGlzcCkgLW5hbWUgJyouZWxjWzAtOUEtWmEtel1bMC05QS1a YS16XVswLTlBLVphLXpdWzAtOUEtWmEtel1bMC05QS1aYS16XVswLTlBLVphLXpdJyAkKEZJTkRf REVMRVRFKQogCiAuUEhPTlk6IGdlbi1saXNwIGxlaW0gc2VtYW50aWMKIApkaWZmIC0tZ2l0IGEv dGVzdC9NYWtlZmlsZS5pbiBiL3Rlc3QvTWFrZWZpbGUuaW4KaW5kZXggODRhYjRlNzBhZS4uZDA0 Mzc2YmU1NiAxMDA2NDQKLS0tIGEvdGVzdC9NYWtlZmlsZS5pbgorKysgYi90ZXN0L01ha2VmaWxl LmluCkBAIC0zMzksNyArMzM5LDcgQEAgbW9zdGx5Y2xlYW46CiAJcm0gLWYgLi8qLnRtcAogCiBj bGVhbjoKLQlmaW5kIC4gJygnIC1uYW1lICcqLmxvZycgLW8gLW5hbWUgJyoubG9nficgJyknICQo RklORF9ERUxFVEUpCisJZmluZCAuICcoJyAtbmFtZSAnKi5sb2cnIC1vIC1uYW1lICcqLmxvZ34n IC1vIC1uYW1lICcqLmVsY1swLTlBLVphLXpdWzAtOUEtWmEtel1bMC05QS1aYS16XVswLTlBLVph LXpdWzAtOUEtWmEtel1bMC05QS1aYS16XScgJyknICQoRklORF9ERUxFVEUpCiAJcm0gLWYgJCh0 ZXN0X21vZHVsZV9kaXIpLyoubyAkKHRlc3RfbW9kdWxlX2RpcikvKi5zbyBcCiAJICAkKHRlc3Rf bW9kdWxlX2RpcikvKi5kbGwKIAotLSAKMi4zMC4yCgo= --000000000000e2c2d605c15614d8--