From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#13780: 24.2; Making find-file-hook customizable seems to cause troublle Date: Wed, 25 Nov 2020 16:07:00 -0500 Message-ID: References: <87k3q1gpba.fsf@sc3d.org> <83sg9ycrgp.fsf@gnu.org> <83sg8xsbu8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16555"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 13780@debbugs.gnu.org, monnier@iro.umontreal.ca, rrt@sc3d.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 25 22:08:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ki21P-0004Dk-Sr for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Nov 2020 22:08:15 +0100 Original-Received: from localhost ([::1]:48538 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ki21O-00018p-T2 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Nov 2020 16:08:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56506) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ki21D-00017J-5V for bug-gnu-emacs@gnu.org; Wed, 25 Nov 2020 16:08:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53994) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ki21C-0007CY-KC for bug-gnu-emacs@gnu.org; Wed, 25 Nov 2020 16:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ki21C-00010I-Fd for bug-gnu-emacs@gnu.org; Wed, 25 Nov 2020 16:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Nov 2020 21:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13780 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 13780-submit@debbugs.gnu.org id=B13780.16063384383784 (code B ref 13780); Wed, 25 Nov 2020 21:08:02 +0000 Original-Received: (at 13780) by debbugs.gnu.org; 25 Nov 2020 21:07:18 +0000 Original-Received: from localhost ([127.0.0.1]:37301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ki20K-0000yn-SB for submit@debbugs.gnu.org; Wed, 25 Nov 2020 16:07:18 -0500 Original-Received: from mail-ed1-f41.google.com ([209.85.208.41]:43295) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ki20I-0000yG-VO for 13780@debbugs.gnu.org; Wed, 25 Nov 2020 16:07:08 -0500 Original-Received: by mail-ed1-f41.google.com with SMTP id q16so4017739edv.10 for <13780@debbugs.gnu.org>; Wed, 25 Nov 2020 13:07:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=R5MakfGuNifGxYeQrbLLwjTJnGTYJgMo72a1wGmlhg0=; b=HZk6BgjuXVz5NNnklGkrOEQerNdDjl65+wzkbxQsNvu+aniNb76DxRz9N8c7xe+ViK HXjhXFOIqLrfEJBsU2YnjJskARC3KSL280XNzypoL+p2W03VhvorqABvFpJpmCAkHWJl YANt7DAMNKspiOWCqpsGJgipEMeJrPRivrf7Pk4HQsIJZfEVf0jXeeCwgkx2FVLizhfH LV2DysKFeUnHVG/kBg4C3padF2Hvcxo+pvXdDoC5J0fxRzqJXuyrul86vKQrZsJefB6d 6GU7kFtbHB+WZjlQMODhYiwRyIPR4hp4uAqHCeR0eJq/H2u9q7J0qQCtv6sc+tweGXrF OOkg== X-Gm-Message-State: AOAM533Bk+XRsBgYqCC/2qWBWONyOFBW5DDs/6zrTei9+vi4qYt8rfF0 lt2YrZ7R1IpZF+wPsBrr8HtiVbo7lL//yzAn+lVhraBcNRo= X-Google-Smtp-Source: ABdhPJyAuZIUwFwPrUGE8R6RCW0Y1obZ23vm2txsQhzMLeRRx0ry8bZImo8SfdfialVdztCbhOGSW7m9nkEcn7IwpCU= X-Received: by 2002:a50:da84:: with SMTP id q4mr3719028edj.377.1606338421350; Wed, 25 Nov 2020 13:07:01 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 25 Nov 2020 16:07:00 -0500 In-Reply-To: <83sg8xsbu8.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194246 Archived-At: Eli Zaretskii writes: >> Stefan Monnier writes: >> >> >>> So until Custom is fixed to actually properly handle customisation o= f >> >>> hooks (e.g. by storing "add functions foo, bar, and baz" rather than >> >>> "ignore current value and just set it to (foo bar baz)"). >> >> This sentence seems to be missing its main clause=E2=80=A6 >> > >> > That's not just an appearance. Its main clause is: >> > >> > So until Custom ...blabla... I think it's better to use defcustom f= or >> > hooks very sparingly, i.e. only for those hook we can reasonably >> > expect will only be modified by the user's customization. > > IMO, this rationale is good for future additions, not for > already-existing user options. We cannot un-defcustom a user option > just because someone became confused by some subtle use case. This is > the price we pay for the flexibility and power we have in Emacs. Fine by me.