From: Stefan Kangas <stefankangas@gmail.com>
To: john muhl <jm@pub.pink>
Cc: 71736-done@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#71736: Small cleanup patches for lua-ts-mode
Date: Fri, 28 Jun 2024 12:56:09 -0700 [thread overview]
Message-ID: <CADwFkmkpnK7AhiED0vxOgOEvsM8+a13kyKfw3Jr5NHiqn+-rzQ@mail.gmail.com> (raw)
In-Reply-To: <871q4h3tfi.fsf@pub.pink>
Version: 30.1
john muhl <jm@pub.pink> writes:
> Stefan Kangas <stefankangas@gmail.com> writes:
>
>> I think patch 2 should go to master, but it doesn't apply cleanly.
>> John, could you please rebase it and resend?
>
> Oops, I see now it included a bit of unrelated local changes.
>
> Here’s another try. I rebased it and checked that it applies to
> emacs-30 and master.
Thanks!
> Out of curiousity, what makes it unfit for the emacs-30 branch?
We prefer not to put code cleanups on the release branch.
So I've now pushed it to `master`, and I'm closing this bug report.
BTW, is there any reason not to use `defvar-keymap' in lua-ts-mode.el?
Does it need to be compatible with Emacs 28?
next prev parent reply other threads:[~2024-06-28 19:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-23 14:41 bug#71736: Small cleanup patches for lua-ts-mode john muhl
2024-06-23 14:58 ` john muhl
2024-06-23 15:51 ` Stefan Kangas
2024-06-23 16:12 ` john muhl
2024-06-27 9:02 ` Eli Zaretskii
2024-06-27 23:05 ` Stefan Kangas
2024-06-28 16:24 ` john muhl
2024-06-28 19:56 ` Stefan Kangas [this message]
2024-06-28 22:16 ` john muhl
2024-06-29 2:59 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmkpnK7AhiED0vxOgOEvsM8+a13kyKfw3Jr5NHiqn+-rzQ@mail.gmail.com \
--to=stefankangas@gmail.com \
--cc=71736-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=jm@pub.pink \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).