unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Juri Linkov <juri@linkov.net>
Cc: 50674@debbugs.gnu.org
Subject: bug#50674: Major mode for etc/AUTHORS with basic font-locking
Date: Sun, 19 Sep 2021 10:38:32 -0700	[thread overview]
Message-ID: <CADwFkmkpY+YDNrc6ypKwVjx7JjQjVnQxrjvo+dr0R9=ZE_sn_g@mail.gmail.com> (raw)
In-Reply-To: <87o88oikye.fsf@mail.linkov.net>

Juri Linkov <juri@linkov.net> writes:

>> +;;;###autoload
>> +(define-derived-mode etc-authors-mode special-mode "Authors View"
>> +  "Major mode for viewing \"etc/AUTHORS\" from the Emacs distribution.
>> +Provides some basic font locking and not much else."
>> +  (setq-local font-lock-defaults
>> +              '(etc-authors-mode-font-lock-keywords nil nil ((?_ . "w"))))
>> +  (setq font-lock-multiline nil)
>> +  (etc-authors-mode--hide-local-variables))
>
> Isn't generic-x.el a more suitable place for such small modes?

The problem I see is that this does not use `define-generic-mode',
unlike the other modes in there, and also I'm not sure it makes sense to
drop autoloaded functions in there.  AFAIU, that file and its modes is
supposed to be optional (not that I agree that they should be).





  reply	other threads:[~2021-09-19 17:38 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-19 14:12 bug#50674: Major mode for etc/AUTHORS with basic font-locking Stefan Kangas
2021-09-19 15:19 ` Lars Ingebrigtsen
2021-09-19 16:25 ` Eli Zaretskii
2021-09-19 21:58   ` Stefan Kangas
2021-09-21 19:54     ` Stefan Kangas
2021-09-19 16:33 ` Juri Linkov
2021-09-19 17:38   ` Stefan Kangas [this message]
2021-09-20  6:41     ` Juri Linkov
2021-09-20  7:42       ` Stefan Kangas
2021-09-20  9:14         ` Stefan Kangas
2021-09-20 15:24           ` Juri Linkov
2021-09-21  6:12             ` Lars Ingebrigtsen
2021-09-21  6:25               ` Eli Zaretskii
2021-09-21  6:28                 ` Lars Ingebrigtsen
2021-09-21  7:57                   ` Stefan Kangas
2021-09-21  8:36                   ` Eli Zaretskii
2021-09-21  8:58                     ` Stefan Kangas
2021-09-21  9:24                       ` Eli Zaretskii
2021-09-21 11:18                         ` Stefan Kangas
2021-09-21 11:25                           ` Eli Zaretskii
2021-09-21  8:28               ` Stefan Kangas
2021-09-21 16:51                 ` Lars Ingebrigtsen
2021-09-21 17:56                 ` Lars Ingebrigtsen
2021-09-21 18:33                   ` Stefan Kangas
2021-09-21 18:41                     ` Juri Linkov
2021-09-21 18:56                       ` Eli Zaretskii
2021-09-21 19:22                       ` Stefan Kangas
2021-09-21 17:28 ` Juri Linkov
2021-09-21 18:33   ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkmkpY+YDNrc6ypKwVjx7JjQjVnQxrjvo+dr0R9=ZE_sn_g@mail.gmail.com' \
    --to=stefan@marxist.se \
    --cc=50674@debbugs.gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).