From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#73568: 30.0.91; which-key error in speedbar (wrong-type-argument wholenump -13) Date: Mon, 30 Sep 2024 14:53:43 -0700 Message-ID: References: <877catggky.fsf@ice9.digital> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1560"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Justin Burkett To: Morgan Willcock , 73568@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 30 23:55:44 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1svOMq-0000GY-7x for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Sep 2024 23:55:44 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1svOMf-00014Q-Lz; Mon, 30 Sep 2024 17:55:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svOMb-00013y-PY for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2024 17:55:29 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1svOMb-0000XR-Gv for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2024 17:55:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:MIME-Version:References:In-Reply-To:From:To:Subject; bh=JTJG4jqS9IxTOV/IEZMWq+R+rucXZq+t7e4Q4ij8etg=; b=DQGBpIY0R8kwBtElzxalwvpNKmp31R5QH9up0UZPSk24wlrHU80JFVaNEHe3BKyxlN5/Hdb1uXu+19FncnKgJlGHqACAOFwTJpKfzPHU3YiCMQcumFn4M512huVmyiuCpgb+DK8tHPFB6xsclduguCJGQOBAqb7K+77RFnFoYEEDE3vAFdOfIwduIpdBd638HHTiYaZ1obdqq9tELmXZEvOHJT/WNEXEpN5ZklXJX0gYKromPDgyHUkbpdnEQvhDY+Xt/JWpwPPj2EBOxQ8pt+hMq5OuGkLvx+9wDfa7G++QbGlExgzl44bPVKs7KtxTyMLAdq4XX3SU6BYTtRMKrw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1svON8-0004Yu-Ee for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2024 17:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Sep 2024 21:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73568 X-GNU-PR-Package: emacs Original-Received: via spool by 73568-submit@debbugs.gnu.org id=B73568.172773333116985 (code B ref 73568); Mon, 30 Sep 2024 21:56:02 +0000 Original-Received: (at 73568) by debbugs.gnu.org; 30 Sep 2024 21:55:31 +0000 Original-Received: from localhost ([127.0.0.1]:47362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svOMd-0004Pt-5g for submit@debbugs.gnu.org; Mon, 30 Sep 2024 17:55:31 -0400 Original-Received: from mail-lj1-f181.google.com ([209.85.208.181]:60687) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svOMV-0004Pe-VK for 73568@debbugs.gnu.org; Mon, 30 Sep 2024 17:55:28 -0400 Original-Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-2f75aaaade6so48579221fa.1 for <73568@debbugs.gnu.org>; Mon, 30 Sep 2024 14:54:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727733224; x=1728338024; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=JTJG4jqS9IxTOV/IEZMWq+R+rucXZq+t7e4Q4ij8etg=; b=SU9xabYJAoywOnb26/NDrtIvToZ2uvS03PZCIFCspM4RABMtn6+CR9YFS4Wwlxf6Xu AWy4ZVsKGmrq5K2Z7Vqd0GURjogijm0xlXAAXL6gStSlboTiTZDOWjBuxHeMw3kWmEMN NPeFCggaZ4VvP+ppT5zKYA7vOXU86RjYIBOMEC0fBf7zm+vL2Ccq46qm3HmQo7FGDUy3 4/YPOtkodzoxmcHDEmcugL110HT0H03f1CA7kN2wrn31xYFKM/ZHR59pWFNnEsCAM3Qq xXIE1BClvtfzyHDiARBMyQ8pUeAM2FwB7uzzzrUdb7EVrhcNaqYWbLPmcig0hFK11HkW RX/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727733224; x=1728338024; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JTJG4jqS9IxTOV/IEZMWq+R+rucXZq+t7e4Q4ij8etg=; b=ZnfMUuv6gnrXKQCqv+O1ybyeJtfqZW96VDmE+a6lKvCu4qOoaMtS+3z85cm800YHnh I3FCxMGG/rR0Fq6UTlsJjiJoBVNBKQqk6fvGZ21Vqiu3Iovwy+rT+2cSbNamDQ1/qt0U R67L8qNgY9jyD2kLwprQAnADHzlRr/bi+1+JaxrTAucGcNKe0Ezpix5TJLQ0Jsyf4Poq rlPx63yBVty+5Ho9ptSmH3ECTnzTrcbbP/9eeL2E+oyL9rjWfpZb2FxLqZ0v/saiXe0+ woo+8PeozNhuksCYSTmDsxmRV9boSZTQdqP+x0stMdkadS6xSiNI6l6rkYcA4jH6hDxd b+DA== X-Forwarded-Encrypted: i=1; AJvYcCWvXkHGR8QS1VIUSPt4P1j68KjND10l1JYZQlqjwCCV9MhQ6OdgMV4gDDXbK1RgVfzgfv2APw==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yy5+WsQZFxqbONncb4dHRNJCd0c50PxZgytJ0Qn2TFVnTj8Snwv iEUCRdyXDdPeU2de5QPKAvImynvQa5oUSqR+176I5lkBy/GnAEWQgqpT8NPi1drxjDgNKT4KWTx dknBJGdSxsbv61cohBDJyUbIyon8= X-Google-Smtp-Source: AGHT+IFcceT7EngKlm0bxyuzdOjZ36AP5hSmJl+sXO+0incFQP3rjU5q5gNyuYmPpGrfthTLrO4TLVLHtGKLuqEUiNc= X-Received: by 2002:a2e:4e12:0:b0:2f5:abe:b6bd with SMTP id 38308e7fff4ca-2f9d41b456dmr59896411fa.42.1727733224137; Mon, 30 Sep 2024 14:53:44 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 30 Sep 2024 14:53:43 -0700 In-Reply-To: <877catggky.fsf@ice9.digital> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292741 Archived-At: Morgan Willcock writes: > An error is signalled when which-key is activated, point is within the > speedbar frame, and a portion of a key-sequence has been typed > (e.g. C-x). > > To generate an example backtrace: > > emacs -Q \ > --eval "(which-key-mode)" \ > --eval "(speedbar-get-focus)" \ > --eval "(toggle-debug-on-error)" \ > --eval "(setq unread-command-events (listify-key-sequence \"\C-x\"))" Here's the error I get: Debugger entered--Lisp error: (wrong-type-argument wholenump -14) make-string(-14 32) The problem occurs is in `which-key--pad-column': the speedbar frame is only 14 characters wide, and so can't fit longer strings than that. I actually see two bugs here: 1. Create a regular Emacs frame of width 14, enable `which-key-mode' and press some key, e.g. C-h. You now get a similar backtrace. Probably `which-key' should simply be smarter in this case, for example by truncating instead of padding. 2. With a dframe, as in speedbar, I guess `which-key' should try to display it's help window in the original frame? I'm copying in Justin Burkett.