* bug#57000: Wrong entry "c-mode" in definition prefix for semantic
@ 2022-08-05 10:06 Stefan Kangas
2022-08-05 10:51 ` Stefan Kangas
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Kangas @ 2022-08-05 10:06 UTC (permalink / raw)
To: 57000
Severity: minor
I see in loaddefs.el:
(register-definition-prefixes "semantic/bovine/c" '("c-mode" "semantic"))
I think "c-mode" shouldn't be there, but I can't seem to figure out why
it is.
^ permalink raw reply [flat|nested] 4+ messages in thread* bug#57000: Wrong entry "c-mode" in definition prefix for semantic
2022-08-05 10:06 bug#57000: Wrong entry "c-mode" in definition prefix for semantic Stefan Kangas
@ 2022-08-05 10:51 ` Stefan Kangas
2022-08-05 12:07 ` Lars Ingebrigtsen
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Kangas @ 2022-08-05 10:51 UTC (permalink / raw)
To: 57000
Stefan Kangas <stefan@marxist.se> writes:
> I see in loaddefs.el:
>
> (register-definition-prefixes "semantic/bovine/c" '("c-mode" "semantic"))
>
> I think "c-mode" shouldn't be there, but I can't seem to figure out why
> it is.
This is caused by
defcustom-mode-local-semantic-dependency-system-include-path
One possible fix below, but I'm not sure we want to do this generally:
diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddefs-gen.el
index afba9f8fbc..8aa17be765 100644
--- a/lisp/emacs-lisp/loaddefs-gen.el
+++ b/lisp/emacs-lisp/loaddefs-gen.el
@@ -68,6 +68,7 @@ autoload-ignored-definitions
"define-short-documentation-group"
"def-edebug-elem-spec"
"defvar-mode-local"
+ "defcustom-mode-local-semantic-dependency-system-include-path"
"define-ibuffer-column"
"define-ibuffer-sorter")
"List of strings naming definitions to ignore for prefixes.
@@ -456,7 +457,7 @@ loaddefs-generate--compute-prefixes
(let ((prefs nil))
;; Avoid (defvar <foo>) by requiring a trailing space.
(while (re-search-forward
- "^(\\(def[^ \t]+\\)[ \t]+['(]*\\([^' ()\"\n]+\\)[\n \t]" nil t)
+ "^(\\(def[^ \t\n]+\\)[ \t\n]+['(]*\\([^' ()\"\n]+\\)[\n \t]" nil t)
(unless (member (match-string 1) autoload-ignored-definitions)
(let ((name (match-string-no-properties 2)))
(when (save-excursion
^ permalink raw reply related [flat|nested] 4+ messages in thread* bug#57000: Wrong entry "c-mode" in definition prefix for semantic
2022-08-05 10:51 ` Stefan Kangas
@ 2022-08-05 12:07 ` Lars Ingebrigtsen
2022-08-05 18:27 ` Stefan Kangas
0 siblings, 1 reply; 4+ messages in thread
From: Lars Ingebrigtsen @ 2022-08-05 12:07 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 57000
Stefan Kangas <stefan@marxist.se> writes:
> This is caused by
>
> defcustom-mode-local-semantic-dependency-system-include-path
>
> One possible fix below, but I'm not sure we want to do this generally:
The patch just allows a newline after the (def* form? I think that
makes sense.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#57000: Wrong entry "c-mode" in definition prefix for semantic
2022-08-05 12:07 ` Lars Ingebrigtsen
@ 2022-08-05 18:27 ` Stefan Kangas
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Kangas @ 2022-08-05 18:27 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 57000-done
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Stefan Kangas <stefan@marxist.se> writes:
>
>> This is caused by
>>
>> defcustom-mode-local-semantic-dependency-system-include-path
>>
>> One possible fix below, but I'm not sure we want to do this generally:
>
> The patch just allows a newline after the (def* form? I think that
> makes sense.
Yes, indeed. Now done on master (commit ea6c2e9295).
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-05 18:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-05 10:06 bug#57000: Wrong entry "c-mode" in definition prefix for semantic Stefan Kangas
2022-08-05 10:51 ` Stefan Kangas
2022-08-05 12:07 ` Lars Ingebrigtsen
2022-08-05 18:27 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).