From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#47047: [External] : Re: bug#47047: 28.0.50; 'help-key-binding' face's background sub-optimal Date: Wed, 29 Sep 2021 16:21:51 -0700 Message-ID: References: <834khjp1nm.fsf@gnu.org> <87im5ykceh.fsf@mail.linkov.net> <83blbqojtc.fsf@gnu.org> <87czor9xxs.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21771"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "47047@debbugs.gnu.org" <47047@debbugs.gnu.org>, Juri Linkov To: Drew Adams , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 30 01:23:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mVius-0005Im-Gq for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Sep 2021 01:23:10 +0200 Original-Received: from localhost ([::1]:56680 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mViur-0004oj-8b for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Sep 2021 19:23:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mViuk-0004oB-Pl for bug-gnu-emacs@gnu.org; Wed, 29 Sep 2021 19:23:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39410) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mViuk-0002kv-I3 for bug-gnu-emacs@gnu.org; Wed, 29 Sep 2021 19:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mViuk-0002SD-6s for bug-gnu-emacs@gnu.org; Wed, 29 Sep 2021 19:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Sep 2021 23:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47047 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 47047-submit@debbugs.gnu.org id=B47047.16329577229345 (code B ref 47047); Wed, 29 Sep 2021 23:23:02 +0000 Original-Received: (at 47047) by debbugs.gnu.org; 29 Sep 2021 23:22:02 +0000 Original-Received: from localhost ([127.0.0.1]:50956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVitm-0002Qd-6G for submit@debbugs.gnu.org; Wed, 29 Sep 2021 19:22:02 -0400 Original-Received: from mail-pj1-f52.google.com ([209.85.216.52]:35500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mViti-0002Q8-H3 for 47047@debbugs.gnu.org; Wed, 29 Sep 2021 19:22:01 -0400 Original-Received: by mail-pj1-f52.google.com with SMTP id d13-20020a17090ad3cd00b0019e746f7bd4so5359314pjw.0 for <47047@debbugs.gnu.org>; Wed, 29 Sep 2021 16:21:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=ejG3GDF4BPw06goR5on6XiRdlV8lEk0D2CD6RMgSP2w=; b=JpBuS02+RLGJrdgV3aUemKR9Yp3j3/SZPvpcSyL2pl1Jr4JJqzEYDyEyLW/2tPrQgE k3zbReGHQ2HTggRXaOpXygd7P/FWkfikaVm+5lEHwptPlGhHCytDxiu4rtc0ckcytm9X bigVzIE5JguK+8FalXxboNIDxHR7qOGEtrE0301xK+nHVmXoh+8Ms8ka4cOVE684fuvp EhxqnWJqin715MwEEMjdeHPl4FxBHHNk4bbH5cijwUqBzAITt/+VOa4DftdzmQnXct3Y vzflLN2OGSjdJwM5IqvVdUf/V0oTiOpWY3gKJJb5Z8f/TsWz4La0t3hI3kCyGSF8zTh6 2fhg== X-Gm-Message-State: AOAM532hjxY3id4R9W3RxzPc2CMcJ7//WF1W00YwKoCbhybcdpNUiJPo DuvZzITh8drqShqG25/oKmJ2K5VAPodGhsXh9Jk= X-Google-Smtp-Source: ABdhPJwyPongmYnVu8e05B+HoxrwNA3zaUTep0WFlOlnlQM+bDLbs5yfzPMGGixAviCrNgWyPGNq/Ff1pYzmvvPa42Q= X-Received: by 2002:a17:902:c1c5:b0:13e:2e1e:aaa4 with SMTP id c5-20020a170902c1c500b0013e2e1eaaa4mr1212208plc.32.1632957711691; Wed, 29 Sep 2021 16:21:51 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 29 Sep 2021 16:21:51 -0700 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215926 Archived-At: Drew Adams writes: > What do you mean by "faces defined"? Do you mean new > faces added by the theme, or existing faces redefined > by the theme, or something else? > > Existing faces that are not redefined are nevertheless > covered (still defined), I'd think. I mean that the theme makes no special effort to support various modes. So you might have a theme with a background color that is very close to the foreground of a face defined in some package, leaving things completely unreadable. I've seen it many, many times. > What inconsistent results have you identified? What > kinds of inconsistency? I mean, you can literally just open up any special-mode and have a look. For example, with `light-blue-theme', the eshell prompt is all but unreadable, and `eshell-prompt' is not defined in the theme itself. If you don't like that example, try some other modes like Gnus, notmuch, mu4e, ERC, etc. Whatever you like. You will find problems, I promise, and you won't even have to dig deep. There is just no way to theme Emacs by just throwing some 25 odd face definitions in a theme and call it a day. Take a look at e.g. manoj-dark.el for something a bit more realistic. > There's plenty of code that's part of Emacs that hasn't > been changed an iota over the years, but still works. > Does that mean that it's necessarily unmaintained or > incomplete? Certainly any code could be enhanced, but > that's something different, and not a requirement for > its continuation. I'm talking about themes that are very old, unmaintained and not very complete. In any case, I don't think we are going to get anywhere by just exchanging emails in this already closed bug report. I hope I made my reasoning somewhat more clear at least.