From: Stefan Kangas <stefankangas@gmail.com>
To: Po Lu <luangruo@yahoo.com>, JD Smith <jdtsmith@gmail.com>
Cc: Ben Simms <bsimms.simms@gmail.com>,
73384@debbugs.gnu.org, Arash Esbati <arash@gnu.org>
Subject: bug#73384: [PATCH] Draw coloured stipples on NS
Date: Sun, 29 Sep 2024 13:33:30 -0700 [thread overview]
Message-ID: <CADwFkmkmKS+hHX=1jP1QcVJNnnghwMiQEwK+nMir6W8fXZqBGA@mail.gmail.com> (raw)
In-Reply-To: <s1r34ljibkb.fsf@yahoo.com>
Po Lu <luangruo@yahoo.com> writes:
> JD Smith <jdtsmith@gmail.com> writes:
>
>> On Sep 21, 2024, at 11:08 AM, Arash Esbati <arash@gnu.org>
>> wrote:
>>
>> Stefan Kangas <stefankangas@gmail.com> writes:
>>
>> Could you please also provide a simple recipe for testing this
>> change?
>>
>> It would be good to move quickly to assess and integrate this patch in
>> time for Emacs 30, since it fixes an existing bug in the display of :stipple
>> face attributes on the NS port, which will likely confuse users. Po I
>> believe implemented the partial fix to NS stipples in ef6ffbdc79.
>>
>> See bug#73082 for more (and a test recipe).
>
> We cannot install changes for Mac OS that use Mac-specific graphics
> features, and in consequence, break the GNUstep build.
We can make them conditional on macOS though, right?
next prev parent reply other threads:[~2024-09-29 20:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 7:57 bug#73384: [PATCH] Draw coloured stipples on NS Ben Simms
2024-09-21 11:41 ` Stefan Kangas
2024-09-21 15:08 ` Arash Esbati
2024-09-28 18:30 ` JD Smith
2024-09-28 23:49 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-29 17:51 ` JD Smith
2024-09-29 20:33 ` Stefan Kangas [this message]
2024-09-29 23:31 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-30 0:13 ` Stefan Kangas
2024-09-30 11:24 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmkmKS+hHX=1jP1QcVJNnnghwMiQEwK+nMir6W8fXZqBGA@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=73384@debbugs.gnu.org \
--cc=arash@gnu.org \
--cc=bsimms.simms@gmail.com \
--cc=jdtsmith@gmail.com \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).