From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#75192: [PATCH] Update fontification for attribute values in heex-ts-mode Date: Fri, 3 Jan 2025 09:14:50 -0600 Message-ID: References: <86zfk9k3xr.fsf@gnu.org> <86ttahk2j2.fsf@gnu.org> <86o70pjl16.fsf@gnu.org> <62396379-9915-49AD-8C2D-0CAF8ED4F063@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37970"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Wilhelm Kirschbaum , 75192-done@debbugs.gnu.org To: Yuan Fu , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 03 16:15:18 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tTjOO-0009fh-Un for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Jan 2025 16:15:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tTjOD-00027w-7P; Fri, 03 Jan 2025 10:15:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTjOB-00025o-D7 for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2025 10:15:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tTjOB-0006uH-2F for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2025 10:15:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:MIME-Version:References:In-Reply-To:From:To:Subject; bh=f3oX37qQ1NXDTSIwyLQLaICDDTYJtIqFf2/xrtGaDAw=; b=sQH547aUms3xFZP8gADM3BaXYZtJvYbXSXORHgxkpllpqIhcoGXnmG7F0JMjDAoTuDUm8qpA7UX9286Lp4B0eyor8ArAPJ0/GPLFhq/1u5QKPiyyBAPO43O/SFPx8bII+JflWflVPbqUBkeL6Yo4dPiDDVXr9jBJKeKrfyGojrI2JPOQsPA+e9N1/VffWnxi4PS7Zbf3gEc8aARJFSs1IbQrfGge9hVPTK9jcliQIqonDqwx/Eh9sa9ZyWbfH21IADHa5EVJoeawGzV5b34taPdFLuaHTRMwB46Pava4e67xLnWY/Wa7GwaCaK6aqYiuOmNajcVCbV4jTDqabGahMQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tTjOA-0004wH-Im for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2025 10:15:02 -0500 Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Jan 2025 15:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 75192 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 75192@debbugs.gnu.org, stefankangas@gmail.com, wkirschbaum@gmail.com Original-Received: via spool by 75192-done@debbugs.gnu.org id=D75192.173591730118969 (code D ref 75192); Fri, 03 Jan 2025 15:15:02 +0000 Original-Received: (at 75192-done) by debbugs.gnu.org; 3 Jan 2025 15:15:01 +0000 Original-Received: from localhost ([127.0.0.1]:51568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tTjO8-0004vh-VA for submit@debbugs.gnu.org; Fri, 03 Jan 2025 10:15:01 -0500 Original-Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]:52438) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tTjO5-0004vR-KF for 75192-done@debbugs.gnu.org; Fri, 03 Jan 2025 10:14:59 -0500 Original-Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-aa6b4cc7270so1773778166b.0 for <75192-done@debbugs.gnu.org>; Fri, 03 Jan 2025 07:14:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735917291; x=1736522091; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=f3oX37qQ1NXDTSIwyLQLaICDDTYJtIqFf2/xrtGaDAw=; b=DTVrrrRM2a9ieZ7jQmHBub2LiVqM1m3iH2mPBiHdPt1teKS+0hKE3+XsU3/WcHiLbW Exu8+o5PmplLYT2b0W2TjE5Xgqc397gRXVMurJiwYQp+Hwitg0dKBRRD8iLP4rLFEvXC u9cETtM+LV82I2/5Gsmdd0CvCxkfCZzCp14UEIdqLmqYjbyyuQKjxn920kbMwAt8qp9d jI6cZf0WYWTe12NMSCKmwSOQHuLFXqAmLcKZO7SU9ai0oyhWIAIg77nl5Sjs48Vw6wjN 4dhzqFqSkNczJd4LYPoE7c91BOBKOBIPoPOCqL2VCTZoMu9uE658aA1sALNAwW9405US K1Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735917291; x=1736522091; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=f3oX37qQ1NXDTSIwyLQLaICDDTYJtIqFf2/xrtGaDAw=; b=oPUqxmUYML3wkUiyorDwBlvOtF08cBBQAvRm/32T6bNnbLsJrpm+nyIpYBfkID95Ay J51OMCbE986WS9GNvjSufO8TRSx/iEhZhS0Df4u72MLykKygQfYaptQNCRG5iUnVS62V GmeZELRrLvHqdm6nSKJ79+1jEit85/41MOchOWL1ImNDYm/GvuxonpNVl2I5+IQGWLuJ v7/0Y8HSmGJ7gPu84eYNcUPhtPoX2yOhBn0g7/tfvOmzfHqc9f7xIeGeWkKMGp1t9cz3 9xcAvbOWohEVli4QQcpvl48HzhHfdkq8LyLJioHpoGjfVveRPG+v/MhhXsGqVrzhZo/R C/sg== X-Forwarded-Encrypted: i=1; AJvYcCUgDgI3xAzrhatBbfzjNhCMs/0+zn26BcS9KiTp8wGvJeN9HByfEWlvmo9AFxgjFnd2f/Xnjxtmcrk+@debbugs.gnu.org X-Gm-Message-State: AOJu0Yw/JUNEkdWUhitNmdOsGx0tXotMHzodVeTQQdCpUOp0dOoYgJdC XbPuDYbiNAWkfkzy2Ue88fvwCXGTQqH3TmHrtROvUWMI1eV1FdPVY6DlPE8q3pyc8I5wFyXOwLn 2LLAXn6R9cqaxyqyAEcz82mZb9jg= X-Gm-Gg: ASbGnct0htiwwYFu6gLLMcQUsyrW6NKaAGW+iwIJZofGPa+uTmNrX3pmLhr8ZkM/8E/ IKxDkwzeQjKITCa3/W/VN2eevG3uFGgHp2JE8ubwF X-Google-Smtp-Source: AGHT+IE5ivd7DD6tqZbxMk/LqmQWYdg7j/QG0xifLewueVqu9VP0IFY1e7oAtz4fXBs2WJaj/Ez88HB8covakmw2fsY= X-Received: by 2002:a05:6402:2802:b0:5d3:cff5:635e with SMTP id 4fb4d7f45d1cf-5d81de065b8mr116873563a12.26.1735917291071; Fri, 03 Jan 2025 07:14:51 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 3 Jan 2025 09:14:50 -0600 In-Reply-To: <62396379-9915-49AD-8C2D-0CAF8ED4F063@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298286 Archived-At: Version: 30.1 Yuan Fu writes: >> On Jan 2, 2025, at 7:24=E2=80=AFAM, Eli Zaretskii wrote: >> >>> From: Wilhelm Kirschbaum >>> Date: Thu, 2 Jan 2025 12:13:27 +0200 >>> Cc: Stefan Kangas , 75192@debbugs.gnu.org, caso= uri@gmail.com >>> >>>>> attribute be highlighted as a string? >>>> >>>> I'm not familiar with HEEx and can't share a useful opinion, but FWIW,= I >>>> simply noted that the code directly above the change said >>>> >>>> :feature 'heex-string >>>> >>>> which is why I assumed that using a string face should make sense. >>> >>> So we think that the current face is just a typo? >>> >>> Originally I was not sure what would be more appropriate, but got a com= ment from a user and saw >>> html-ts-mode uses string so thought it would be good to change before i= t gets released. >> >> OK, then I think installing this on emacs-30 is TRT. > > Agree. Thanks all, installed on emacs-30 as commit 921f454f508. Closing.