From: Stefan Kangas <stefankangas@gmail.com>
To: Shynur Xie <one.last.kiss@outlook.com>
Cc: Eli Zaretskii <eliz@gnu.org>, Drew Adams <drew.adams@oracle.com>,
"65621@debbugs.gnu.org" <65621@debbugs.gnu.org>
Subject: bug#65621: [PATCH] `dired-next-line' go to meaningful line
Date: Thu, 31 Aug 2023 23:35:26 +0200 [thread overview]
Message-ID: <CADwFkmkiOsMnE1M0h8qT37=7V9BnWUmfQttY_bkFFDo=DXuAKg@mail.gmail.com> (raw)
In-Reply-To: <PH0PR11MB7470C711EBAB79091E0EC63FD7E5A@PH0PR11MB7470.namprd11.prod.outlook.com>
Shynur Xie <one.last.kiss@outlook.com> writes:
> The final patch is attached. (See the end for how to test it.)
Thanks.
> There is totally 4 (not 6) kinds of combinations of the 2 new options:
>
> 1. (setq dired-cursor-goto-meaningful-line 'bounded
> dired-headerline-is-meaningful nil)
> 2. (setq dired-cursor-goto-meaningful-line 'cycle
> dired-headerline-is-meaningful nil)
> 3. (setq dired-cursor-goto-meaningful-line 'bounded
> dired-headerline-is-meaningful t)
> 4. (setq dired-cursor-goto-meaningful-line 'cycle
> dired-headerline-is-meaningful t)
I'll review your patch in detail as soon as I can find some time.
Just two initial comments:
I like the option `dired-cursor-goto-meaningful-line', which seems to
both add wrap-around and make the feature as a whole optional. But in
Emacs, we say "point" rather than "cursor", so we'd have to change
that. I suggest naming it `dired-movement-style', or something along
those lines.
But is `dired-headerline-is-meaningful' really needed? It seems like
an unnecessary complication.
next prev parent reply other threads:[~2023-08-31 21:35 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 13:02 bug#65621: [PATCH] `dired-next-line' go to meaningful line Shynur Xie
2023-08-30 13:36 ` Eli Zaretskii
2023-08-30 13:50 ` Shynur Xie
2023-08-30 14:20 ` Eli Zaretskii
2023-08-30 19:14 ` Stefan Kangas
2023-08-30 20:58 ` Drew Adams
2023-08-30 21:34 ` Stefan Kangas
2023-08-30 22:36 ` Drew Adams
2023-08-31 5:45 ` Shynur Xie
2023-08-31 15:35 ` Drew Adams
2023-08-31 15:46 ` Shynur Xie
2023-08-31 15:55 ` Drew Adams
2023-08-31 18:15 ` Shynur Xie
2023-08-31 19:10 ` Drew Adams
2023-08-31 19:17 ` Drew Adams
2023-08-31 19:44 ` Shynur Xie
2023-08-31 21:51 ` Drew Adams
2023-08-31 21:35 ` Stefan Kangas [this message]
2023-08-31 21:37 ` Stefan Kangas
2023-09-01 17:29 ` Shynur Xie
2023-09-01 18:46 ` Drew Adams
2023-09-01 20:51 ` Shynur Xie
2023-09-01 21:06 ` Drew Adams
2023-09-02 12:05 ` Shynur Xie
2023-09-02 12:13 ` Eli Zaretskii
2023-09-02 12:18 ` Shynur Xie
2023-09-02 12:39 ` Eli Zaretskii
2023-09-02 14:40 ` Shynur Xie
2023-09-10 7:45 ` Eli Zaretskii
2023-09-03 21:47 ` Drew Adams
2023-09-07 15:04 ` Shynur Xie
2023-08-30 14:54 ` Drew Adams
2023-08-30 15:39 ` Shynur Xie
2023-08-30 15:55 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmkiOsMnE1M0h8qT37=7V9BnWUmfQttY_bkFFDo=DXuAKg@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=65621@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
--cc=eliz@gnu.org \
--cc=one.last.kiss@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).