bug#44673: [PATCH] Use lexical-binding in time-stamp.el

bug#44673: [PATCH] Use lexical-binding in time-stamp.el

[Stefan Kangas]

[-- Attachment #1: Type: text/plain, Size: 295 bytes --]

Severity: wishlist

Hi Stephen,

I see that you have put a lot of work into building a test suite for
time-stamp.el - thanks!

Do you think we could safely enable lexical-binding in time-stamp.el?
I ran the test suite with the attached patch and all tests are still
passing.

Thanks in advance.

[-- Attachment #2: 0001-Use-lexical-binding-in-time-stamp.el.patch --]
[-- Type: text/x-diff, Size: 2036 bytes --]

From e4c89c884e3b2d9ab8c22dc8cfa7e8372cd1c0a7 Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefan@marxist.se>
Date: Sun, 15 Nov 2020 20:12:45 +0100
Subject: [PATCH] Use lexical-binding in time-stamp.el

* lisp/time-stamp.el: Use lexical-binding.  Remove redundant :group
args.
---
 lisp/time-stamp.el | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/lisp/time-stamp.el b/lisp/time-stamp.el
index 7c64f2903b..c50d68b60a 100644
--- a/lisp/time-stamp.el
+++ b/lisp/time-stamp.el
@@ -1,4 +1,4 @@
-;;; time-stamp.el --- Maintain last change time stamps in files edited by Emacs
+;;; time-stamp.el --- Maintain last change time stamps in files edited by Emacs  -*- lexical-binding: t -*-
 
 ;; Copyright (C) 1989, 1993-1995, 1997, 2000-2020 Free Software
 ;; Foundation, Inc.
@@ -87,7 +87,6 @@ time-stamp-format
 The behavior of `%5z' is new in Emacs 27.  If your files might be
 edited by older versions of Emacs also, do not use this format yet."
   :type 'string
-  :group 'time-stamp
   :version "27.1")
 ;;;###autoload(put 'time-stamp-format 'safe-local-variable 'stringp)
 
@@ -102,8 +101,7 @@ time-stamp-active
 or customize option `before-save-hook'.
 
 See also the variable `time-stamp-warn-inactive'."
-  :type 'boolean
-  :group 'time-stamp)
+  :type 'boolean)
 
 (defcustom time-stamp-warn-inactive t
   "Have \\[time-stamp] warn if a buffer did not get time-stamped.
@@ -111,7 +109,6 @@ time-stamp-warn-inactive
 deactivated time stamping and the buffer contains a template that
 otherwise would have been updated."
   :type 'boolean
-  :group 'time-stamp
   :version "19.29")
 
 (defcustom time-stamp-time-zone nil
@@ -125,7 +122,6 @@ time-stamp-time-zone
                        (integer :tag "Offset (seconds east of UTC)")
                        (string :tag "Time zone abbreviation"))
                  (integer :tag "Offset (seconds east of UTC)"))
-  :group 'time-stamp
   :version "20.1")
 ;;;###autoload(put 'time-stamp-time-zone 'safe-local-variable 'time-stamp-zone-type-p)
 
-- 
2.29.2

bug#44673: [PATCH] Use lexical-binding in time-stamp.el

[Stephen Gildea]

>   Do you think we could safely enable lexical-binding in time-stamp.el?
>   I ran the test suite with the attached patch and all tests are still
>   passing.

I reviewed the code, and lexical binding looks good to me.

Thank you.

 < Stephen

bug#44673: [PATCH] Use lexical-binding in time-stamp.el

[Stefan Kangas]

close 44673 28.1
thanks

Stephen Gildea <stepheng+emacs@gildea.com> writes:

>>   Do you think we could safely enable lexical-binding in time-stamp.el?
>>   I ran the test suite with the attached patch and all tests are still
>>   passing.
>
> I reviewed the code, and lexical binding looks good to me.
>
> Thank you.

Thanks!  Pushed to master as commit 7dd671f7f2.