From: Stefan Kangas <stefankangas@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>,
Gregory Heytings <gregory@heytings.org>
Cc: Heime <heimeborgia@protonmail.com>, Eli Zaretskii <eliz@gnu.org>,
65459@debbugs.gnu.org
Subject: bug#65459: completing-read INITIAL-VALUE unaware of COLLECTION and REQUIRE-MATCH
Date: Mon, 4 Sep 2023 15:16:15 -0700 [thread overview]
Message-ID: <CADwFkmkfYdNs5vSkbgt_T2ht22hTXkUzn7bpBmwBgnKbbTRJMg@mail.gmail.com> (raw)
In-Reply-To: <jwvpm2xmxnx.fsf-monnier+emacs@gnu.org>
Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs@gnu.org> writes:
>> Thanks, that clarifies that question! Perhaps a paragraph along those lines
>> could be added to "(elisp)Advising Functions"?
>
> What about the following?
I think it's a good addition.
> diff --git a/doc/lispref/functions.texi b/doc/lispref/functions.texi
> index 53525e6b386..236b823e7e6 100644
> --- a/doc/lispref/functions.texi
> +++ b/doc/lispref/functions.texi
> @@ -1994,9 +1994,16 @@ Advising Named Functions
> debugging does not notice or remember that the function has been modified
> by advice.
>
> - For these reasons, advice should be reserved for the cases where you
> -cannot modify a function's behavior in any other way. If it is
> -possible to do the same thing via a hook, that is preferable
> + Note that the problems are not due to advice per se, but to the act
> +of modifying a named function. It is even more problematic to modify
> +a named function via lower-level primitives like @code{fset},
> +@code{defalias}, or @code{cl-letf}. From that point of view, advice
> +is the better way to modify a named function because it keeps track of
> +the modifications, so they can be listed and undone.
> +
> + Modifying a named function should be reserved for
> +the cases where you cannot modify Emacs' behavior in any other way.
> +If it is possible to do the same thing via a hook, that is preferable
> (@pxref{Hooks}). If you simply want to change what a particular key
> does, it may be better to write a new command, and remap the old
> command's key bindings to the new one (@pxref{Remapping Commands}).
next prev parent reply other threads:[~2023-09-04 22:16 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 22:04 bug#65459: completing-read INITIAL-VALUE unaware of COLLECTION and REQUIRE-MATCH Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-23 11:29 ` Eli Zaretskii
2023-08-23 11:57 ` Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-23 13:07 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-23 15:29 ` Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-23 16:05 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-23 16:39 ` Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-23 16:58 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-23 18:12 ` Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-23 21:27 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-23 22:44 ` Drew Adams
2023-08-23 23:06 ` Gregory Heytings
2023-08-24 2:30 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-24 12:30 ` Gregory Heytings
2023-08-24 13:19 ` Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-25 6:59 ` Juri Linkov
2023-08-24 13:46 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-26 8:06 ` Gregory Heytings
2023-08-31 9:42 ` Eli Zaretskii
2023-09-04 21:35 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-04 22:16 ` Stefan Kangas [this message]
2023-09-05 11:05 ` Eli Zaretskii
2023-09-05 12:59 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-05 13:14 ` Eli Zaretskii
2023-08-24 9:02 ` Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-24 13:36 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-24 14:51 ` Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-24 16:45 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-24 18:50 ` Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-24 19:35 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-24 20:22 ` Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-24 21:02 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-24 21:45 ` Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-26 8:10 ` Gregory Heytings
2023-08-26 14:27 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-27 6:45 ` Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-27 14:40 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-27 16:21 ` Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-27 16:26 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-27 16:35 ` Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-27 18:01 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-27 21:11 ` Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-27 21:48 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-27 22:59 ` Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-28 3:12 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-28 9:14 ` Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-28 12:44 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-28 12:50 ` Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-28 13:04 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-28 13:13 ` Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-27 16:42 ` Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-27 18:02 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-27 20:54 ` Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-27 21:26 ` Heime via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmkfYdNs5vSkbgt_T2ht22hTXkUzn7bpBmwBgnKbbTRJMg@mail.gmail.com \
--to=stefankangas@gmail.com \
--cc=65459@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=gregory@heytings.org \
--cc=heimeborgia@protonmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).