unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Lassi Kortela <lassi@lassi.io>, 66660@debbugs.gnu.org
Subject: bug#66660: [PATCH] Fix dns-mode-syntax-table
Date: Sat, 21 Oct 2023 02:41:43 -0700	[thread overview]
Message-ID: <CADwFkmkfF8UTyZp_jTyp+L1O-b-J=4excnBC209NEfqOVp+CzQ@mail.gmail.com> (raw)
In-Reply-To: <7fe6185c-2dac-7464-1394-0bf4dd3b652f@lassi.io>

Lassi Kortela <lassi@lassi.io> writes:

> On the following two lines, the text in double quotes was not
> highlighted.
>
> @ IN TXT "v=spf1 include:simplelists.com -all"
>
> srfi IN TXT "v=spf1 include:simplelists.com -all"
>
> On the following line, the part "k=rsa was not highlighted, and the
> rest of the line ;p=MIGf[...]QAB" starting at the semicolon was
> incorrectly highlighted as a comment instead of a string literal.
>
> selector1._domainkey.srfi IN TXT "k=rsa;p=MIGf[...]QAB"
>
> The patch causes the parts in double quotes to be highlighted as string
> literals. Since the part starting at the semicolon is inside a string,
> it is no longer incorrectly highlighted as a comment.
>
> Motion commands such as forward-sexp are likewise fixed.

Thanks, this seems to have already been fixed on master:

    commit c586d984f279aa61de4f5dfc4f6df660188dd0f6
    Author: Stefan Kangas <stefankangas@gmail.com>
    Date:   Tue Sep 5 23:06:21 2023 +0200

        Make `dns-mode` fontify quoted values correctly

        * lisp/textmodes/dns-mode.el (dns-mode-syntax-table): Fontify
        quoted values correctly.  (Bug#62214)
        Suggested by Trent W. Buck <trentbuck@gmail.com>.

However, the patch on master only has:

+    (modify-syntax-entry ?\" "\""   table)

But your patch has this:

+    (modify-syntax-entry ?\" "\"" table)
+    (modify-syntax-entry ?\\ "\\" table)

Do we need the second line there, too?  If yes, why?

Perhaps this fix should be cherry-picked to emacs-29, as well.

Thanks.





  reply	other threads:[~2023-10-21  9:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-20 16:21 bug#66660: [PATCH] Fix dns-mode-syntax-table Lassi Kortela
2023-10-21  9:15 ` Stefan Kangas
2023-10-21  9:31   ` Lassi Kortela
2023-10-21  9:41     ` Stefan Kangas [this message]
2023-10-21  9:49       ` Lassi Kortela
2023-10-21  9:58         ` Stefan Kangas
2023-10-21 10:15           ` Lassi Kortela
2023-10-21 10:30             ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkmkfF8UTyZp_jTyp+L1O-b-J=4excnBC209NEfqOVp+CzQ@mail.gmail.com' \
    --to=stefankangas@gmail.com \
    --cc=66660@debbugs.gnu.org \
    --cc=lassi@lassi.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).