From: Stefan Kangas <stefankangas@gmail.com>
To: Gabriel <gabriel376@hotmail.com>, 59443@debbugs.gnu.org
Subject: bug#59443: 29.0.50; [PATCH] Allow goto-address-at-point to use secondary browser
Date: Mon, 21 Nov 2022 05:52:41 -0800 [thread overview]
Message-ID: <CADwFkmkfDBz5+pLHu3d03JV=_97RJpjh73w+faHc8FudmmcCRA@mail.gmail.com> (raw)
In-Reply-To: <SJ0PR06MB86091C174BEEA94D04C7A1888B0A9@SJ0PR06MB8609.namprd06.prod.outlook.com>
I didn't really study the patch or the issue, but here are two nits.
Gabriel <gabriel376@hotmail.com> writes:
> * lisp/net/dictionary.el (goto-address-at-point): Call
> `browse-url-button-open-url', so a prefix argument uses
> `browse-url-secondary-browser-function'.
^^
We do not indent the commit message like this. It should start at
column 0.
> ;;;###autoload
> (defun goto-address-at-point (&optional event)
> - "Send to the e-mail address or load the URL at point.
> -Send mail to address at point. See documentation for
> -`goto-address-find-address-at-point'. If no address is found
> -there, then load the URL at or before point."
> + "Compose a new message to the e-mail address or browse the URL at
> +point.
The first line of a docstring should be a complete sentence (for
e.g. eldoc and apropos).
next prev parent reply other threads:[~2022-11-21 13:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 11:45 bug#59443: 29.0.50; [PATCH] Allow goto-address-at-point to use secondary browser Gabriel
2022-11-21 13:52 ` Stefan Kangas [this message]
2022-11-21 15:03 ` Gabriel
2022-11-21 16:51 ` Visuwesh
2022-11-21 18:31 ` Gabriel
2022-11-25 0:34 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmkfDBz5+pLHu3d03JV=_97RJpjh73w+faHc8FudmmcCRA@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=59443@debbugs.gnu.org \
--cc=gabriel376@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).