From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#59458: [PATCH] Fix tracing for advanced scoring Date: Mon, 11 Sep 2023 17:32:20 -0700 Message-ID: References: <20221121213055.2387178-1-stlman@poczta.fm> <831qpsyaar.fsf@gnu.org> <877czkf8g3.fsf@ericabrahamsen.net> <871qf4ntjf.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29255"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 59458-done@debbugs.gnu.org, Lars Ingebrigtsen , =?UTF-8?Q?=C5=81ukasz?= Stelmach To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 12 02:33:30 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qfrLO-0007O5-8M for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 Sep 2023 02:33:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qfrKu-00085s-53; Mon, 11 Sep 2023 20:33:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfrKs-00084U-MV for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2023 20:32:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qfrKs-0004Kf-E3 for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2023 20:32:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qfrKw-00049P-G4 for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2023 20:33:02 -0400 Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Sep 2023 00:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 59458 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 59458@debbugs.gnu.org, stefankangas@gmail.com, stlman@poczta.fm Original-Received: via spool by 59458-done@debbugs.gnu.org id=D59458.169447875415913 (code D ref 59458); Tue, 12 Sep 2023 00:33:02 +0000 Original-Received: (at 59458-done) by debbugs.gnu.org; 12 Sep 2023 00:32:34 +0000 Original-Received: from localhost ([127.0.0.1]:55414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfrKU-00048a-CY for submit@debbugs.gnu.org; Mon, 11 Sep 2023 20:32:34 -0400 Original-Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]:50266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfrKR-00048M-Mt for 59458-done@debbugs.gnu.org; Mon, 11 Sep 2023 20:32:33 -0400 Original-Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-5007abb15e9so8587206e87.0 for <59458-done@debbugs.gnu.org>; Mon, 11 Sep 2023 17:32:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694478741; x=1695083541; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=7I+YYxpOzy/7YSBZvw0gWI/ffyi1fWp2ST5A1FopA5Y=; b=hL2lLBbHIUHXmFHMK+yKDiDRcrxSKQNtbCTbdKhJUvrxMUw+HB3Lqt6oqqK6lgJwVA aO4gy1yDD1+6w3YyvBnwGTo5CnXjkOAz0m7m93+lh3BmLgoLmhvHysoEt9XwcKvZy2zF boNDhA9GIs9/9j7/+Bz3kDvjZg/R36S+0dT9B3QVw246Ber3pR1OtkQrtDCjNw+FPqng 3V5Clh3I0U4EuzCtfuYw5a+wCLeMNShKRRipKZdDAfntle0jPkQWPeryovriYfkpEWFs tCKTe39/qlzrBphTdQhR0xFMP9Zy3vpdH8BKtY/vDTKGBz5r30Z49KE4Yo/AHIyvYqHS 0HIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694478741; x=1695083541; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7I+YYxpOzy/7YSBZvw0gWI/ffyi1fWp2ST5A1FopA5Y=; b=E4m84HmNCqUk4SM5uIG+sSYnToIeWBaVNIl0hb04RDONrpPtwnJhs0hLbEL8ca4V7G nou6MvXOTEN/ozJYRMmAxKWiiElsp/JbwAUdx1Rt5zAc6kLST1eH/uRB2AdQBr/mEInJ S+GqHcYIc5XxCyVW0dvUzsFrCmTIb0iZ7fqiKL2NMIbxOBnPqCk8HPT3NAIY3uVnr/OH pw0yJRQwNKX9qeiMgQa4LwGq5k0g+W4W0PUoFVMJ04gbwBVr0xZorVEAI7RnXUj+IGzu +LN7gGxWbYiqsNhBb/egS6AylIvEM+NcyW261Fvw5rAVAT2RoaVFp+r1bQ1LCLY37yhT LGPQ== X-Gm-Message-State: AOJu0YzC5WsH5oBG6ON5n9yq5b/9T+VuWvFAW5X7PFOUTgZzre+ges6w fOp6pRFhlAWxGNADcODRZw6NTVY40Dte0kEgAUc= X-Google-Smtp-Source: AGHT+IHQ2LK8+0QYur986EKhuqsiXr8XM6BnPdkJImMXuTGmTBFkE4RHgLiUMqRSF2Zq7tfVc+UVvvL2enyqQPjgkOQ= X-Received: by 2002:a2e:8752:0:b0:2bd:1246:cdce with SMTP id q18-20020a2e8752000000b002bd1246cdcemr9391356ljj.10.1694478741236; Mon, 11 Sep 2023 17:32:21 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 11 Sep 2023 17:32:20 -0700 In-Reply-To: <871qf4ntjf.fsf@ericabrahamsen.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270120 Archived-At: Version: 30.1 Eric Abrahamsen writes: > On 09/07/23 14:07 PM, Stefan Kangas wrote: > >> Eric, >> >> It would be great if you could help review this. Thanks in advance. > > I've taken a closer look, and I do think this is okay. The `when' after > the `dolist' only fires if the rule matches, the `if' is only there to > see if this article has been previously scored or not. So moving the > "(when trace" up to the top-level of the containing `when' (ie, out of the > `if') does look like the right thing to do. Thanks. Installed it on master as commit e25ad6e2a30.