From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer Date: Sat, 24 Oct 2020 17:01:19 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26931"; mail-complaints-to="usenet@ciao.gmane.io" To: Kevin Foley , 44202@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 25 02:02:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kWTUB-0006tI-Bi for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Oct 2020 02:02:11 +0200 Original-Received: from localhost ([::1]:39728 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kWTUA-0002jx-9N for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Oct 2020 20:02:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33440) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kWTU2-0002jm-Se for bug-gnu-emacs@gnu.org; Sat, 24 Oct 2020 20:02:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52169) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kWTU2-0000jJ-JR for bug-gnu-emacs@gnu.org; Sat, 24 Oct 2020 20:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kWTU2-0002W8-Hw for bug-gnu-emacs@gnu.org; Sat, 24 Oct 2020 20:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Oct 2020 00:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44202 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44202-submit@debbugs.gnu.org id=B44202.16035840899636 (code B ref 44202); Sun, 25 Oct 2020 00:02:02 +0000 Original-Received: (at 44202) by debbugs.gnu.org; 25 Oct 2020 00:01:29 +0000 Original-Received: from localhost ([127.0.0.1]:35482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWTTV-0002VL-8T for submit@debbugs.gnu.org; Sat, 24 Oct 2020 20:01:29 -0400 Original-Received: from mail-ej1-f43.google.com ([209.85.218.43]:34265) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWTTR-0002V5-Mg for 44202@debbugs.gnu.org; Sat, 24 Oct 2020 20:01:27 -0400 Original-Received: by mail-ej1-f43.google.com with SMTP id gs25so8075346ejb.1 for <44202@debbugs.gnu.org>; Sat, 24 Oct 2020 17:01:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to; bh=5weMhcL6AUu7eckEJChQ3gQcCkWkqTYBFwMz0ovKa8k=; b=mF8Bx1cJM4CMwDgNXY6HSMrplRSp2mf5uHO8KYrJRh6Dpw9ME3gR/MYcrRuE1l69Am 1GOXo0xSEG64l3XF5tWgjaRuHoz6ynD1hzlRSfjVph3B4/SKT7YrkV2u2Tw/e2QkUrHe NAVSwnwKjcxQjZ4V0LVpmjVTqcol4tBM+8FSfJIjwAZo/trV35ey6AtfgKuwefXEJK46 KHoADhJr8aASb7ZH3mfX4j1YKxrE6iEVRB2U7qUc9Tb8U80pYU5Q/+AcKiUbcNudCuLW TZD6V2acOflu0JLSdtco2FlsUKMYFnoXl94gfZqliK5EGpy2SoqxkFkw0P9ooMH0zQv0 8AAA== X-Gm-Message-State: AOAM5336a3JukdQqTkz+hTV/Ou4wFczWXRV5ZraJ52GNmOYm5AImII51 3EuclOcd20RW98cfYYZfXr3lCgz8AA7E7rBes/c= X-Google-Smtp-Source: ABdhPJwEpD5hwSj2AdePfr1IPp/DlIeSY3KKK74DAX8AfByCyunjtE9CLxjU5OT/Tw0B7sHOY3yJMkNFuqWgOqJuSpI= X-Received: by 2002:a17:906:3cd:: with SMTP id c13mr8641846eja.25.1603584079643; Sat, 24 Oct 2020 17:01:19 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 24 Oct 2020 17:01:19 -0700 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:191462 Archived-At: Kevin Foley writes: > Allows users to control the `noconfirm' parameter of > `help-mode-revert-buffer'. > > I've assigned copyright to FSF but this is my first patch on this list > so please let me know if I've missed any standards. Thanks, it looks useful. I have added my comments below. Your patch seems to be lacking ChangeLog entries as described in etc/CONTRIBUTE. You would help us if you could add such entries, especially if you are planning to do more changes. > +(defcustom help-mode-revert-buffer-noconfirm nil This would change the default, right? Any rationale for that? Perhaps we could keep this new behavior optional for now? We could consider changing it later once we get some experience with it. > + "Indicates whether to prompt for confirmation when reverting a > +help buffer." The first sentence of a doc string should fit on one line. Perhaps you could use something like: "If non-nil, prompt before reverting a help buffer." > (defun help-mode-revert-buffer (_ignore-auto noconfirm) > - (when (or noconfirm (yes-or-no-p "Revert help buffer? ")) > + "Revert help-mode buffer. See > +`help-mode-revert-buffer-noconfirm' to control whether user is > +prompted for confirmation." The first line should be one sentence only, and the second sentence start on the second line. Other than those nits, the patch looks good to me.