From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#18573: 24.3.93; set-face-attribute crashes Emacs when started with -nw Date: Thu, 26 Sep 2019 22:57:26 +0200 Message-ID: References: <5426E238.6060301@vsm.in> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="250660"; mail-complaints-to="usenet@blaine.gmane.org" Cc: enquiries@vsm.in, 18573@debbugs.gnu.org To: Jan =?UTF-8?Q?Dj=C3=A4rv?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 26 22:58:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iDaq4-00134j-Kn for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Sep 2019 22:58:12 +0200 Original-Received: from localhost ([::1]:44354 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDaq3-0006CR-Dk for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Sep 2019 16:58:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39972) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDapu-0006CB-UN for bug-gnu-emacs@gnu.org; Thu, 26 Sep 2019 16:58:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iDapu-0007Jl-0J for bug-gnu-emacs@gnu.org; Thu, 26 Sep 2019 16:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36568) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iDapt-0007JH-TX for bug-gnu-emacs@gnu.org; Thu, 26 Sep 2019 16:58:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iDapt-0006g7-PS for bug-gnu-emacs@gnu.org; Thu, 26 Sep 2019 16:58:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <5426E238.6060301@vsm.in> Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Sep 2019 20:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18573 X-GNU-PR-Package: emacs Original-Received: via spool by 18573-submit@debbugs.gnu.org id=B18573.156953146725629 (code B ref 18573); Thu, 26 Sep 2019 20:58:01 +0000 Original-Received: (at 18573) by debbugs.gnu.org; 26 Sep 2019 20:57:47 +0000 Original-Received: from localhost ([127.0.0.1]:45386 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iDape-0006fE-VK for submit@debbugs.gnu.org; Thu, 26 Sep 2019 16:57:47 -0400 Original-Received: from mail-pg1-f178.google.com ([209.85.215.178]:36139) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iDapb-0006el-4M for 18573@debbugs.gnu.org; Thu, 26 Sep 2019 16:57:43 -0400 Original-Received: by mail-pg1-f178.google.com with SMTP id t14so2202847pgs.3 for <18573@debbugs.gnu.org>; Thu, 26 Sep 2019 13:57:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc :content-transfer-encoding; bh=UyX4gtXq5QuiS601kky3KMe55kv/Pm8Hd07gj89XU3Y=; b=XxfRKGtdZAzlUl465O8PtVFTa3wRKGrdc5p1uEsHoqLBQOeQjf9SI3GVLVIT4/YWqE lSS1ciPAxsJ7meQ4TetHFv8SVmfbwJtpBp8fjScIx/sVOx7g0QW2/GDgAuKFCzQj3Bcm SVv8DKcdafiRjuHmqMIYKj6bUdI56Pp5SHsZlqNZAFUvhEYYkP7Ziq9q/FxW7/srzqMB tiTeNDs7Slo//xPJHjPrKrXeBhinfwxPDuGiFQv0uIFuEsTGgJqTlXbwCAdoC010TB7S kRey/Db52duLkn8KMKoeiw8/1Z5rS1c/kW83B+qaQ5EcFb29aiY25IA7Pe9xIYXz+ybR iyyA== X-Gm-Message-State: APjAAAXFz/CpWwiJTeEWohE3gNMV3K7roYpAFKNygaDlD1F62ax8+M45 5bAu1pfr8/OZ8Y5jCuXm21Q6I8sRycl+GJjiocQ= X-Google-Smtp-Source: APXvYqw1I415hZfP+9izS5Lpn+fzjk7wUNdDaVkr1KIC2ry6uukcc9KIhQzXJ3dyoKZe5KDZnIF3nJgmcENGtJmo0XI= X-Received: by 2002:a63:1310:: with SMTP id i16mr5014339pgl.200.1569531456991; Thu, 26 Sep 2019 13:57:36 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167334 Archived-At: fixed 18573 24.4 close 18573 quit Jan Dj=C3=A4rv writes: > For now I comitted the "wont crash" solution (don't execute the code for = tty > frames) in the emacs 24 branch. No error is signalled and no looping is = done to > find a GUI frame. I'm not sure if we should do that. I think that fixed the issue; I can no longer reproduce it. I don't see anything else outstanding, besides the FIXME added in: commit 335e9627ca78f7be9eea27f38a530fd51a1e6995 Author: Jan Dj=C3=A4rv Date: Wed Oct 1 20:10:21 2014 +0200 * xfaces.c (Finternal_set_lisp_face_attribute): Added FIXME comment. But that is just a possible improvement, and keeping this bug open won't do much to help direct any efforts to doing that. If anything it will confuse it by mixing it up with a crash that has been fixed for a long time. I'm therefore closing this bug. If anyone disagrees, feel free to reopen. Best regards, Stefan Kangas