From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#68246: 30.0.50; Add non-TS mode as extra parent of TS modes Date: Mon, 8 Jan 2024 20:49:57 -0800 Message-ID: References: <83edeww73j.fsf@gnu.org> <83o7dzvrmf.fsf@gnu.org> <838r53vlo5.fsf@gnu.org> <831qavvcbo.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11959"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov , Eli Zaretskii , casouri@gmail.com, 68246@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 09 05:51:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rN450-0002zC-W3 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Jan 2024 05:51:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rN44n-0003C7-9b; Mon, 08 Jan 2024 23:50:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rN44l-0003Bp-O0 for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2024 23:50:55 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rN44l-0000sQ-Ff for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2024 23:50:55 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rN44s-0004nH-1f for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2024 23:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jan 2024 04:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68246 X-GNU-PR-Package: emacs Original-Received: via spool by 68246-submit@debbugs.gnu.org id=B68246.170477581218356 (code B ref 68246); Tue, 09 Jan 2024 04:51:02 +0000 Original-Received: (at 68246) by debbugs.gnu.org; 9 Jan 2024 04:50:12 +0000 Original-Received: from localhost ([127.0.0.1]:38063 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rN444-0004m0-GD for submit@debbugs.gnu.org; Mon, 08 Jan 2024 23:50:12 -0500 Original-Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]:50613) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rN442-0004lf-No for 68246@debbugs.gnu.org; Mon, 08 Jan 2024 23:50:11 -0500 Original-Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2cd1a1c5addso29331921fa.1 for <68246@debbugs.gnu.org>; Mon, 08 Jan 2024 20:50:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704775798; x=1705380598; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=xDuL0q1xiyNu0ztUH7UA6SEpQDVz0ucerAFD8IEf1nY=; b=DfnfmB+L2PDqKz4nrJM6SgyeYm9LZPdEjc1jTOwwi+Cg5QUQIPob70HXm0my838sVQ 6bt70K7CGEN0OLFZUeS7N/sAiZ40u4Xv9ZiZAMmGhkmyVLmEUDzItXzFsR28nEx9xJx4 sepv/iYbaqJidDlp8/1cIfAkpPL+hhQbRSNYh1dJLDn4XtOti8amCDOvph9aYMXtxmna C82gtulVuEZaiamsNkTVCrHq9zq7EAVYH9EzokznlYkUe5s92Uet++6fHjppQokJj0l+ og9qp6ztGjinvDo5gfrwiPbXM+tkBn6D+nfF86gHfQ8y9crUWVm2LMd2PXySdgpvAFlg 9Vcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704775798; x=1705380598; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=xDuL0q1xiyNu0ztUH7UA6SEpQDVz0ucerAFD8IEf1nY=; b=lUdbjHcWbc8cAdlKIU+Tnx+YENkEWPiwV3FFCviW279xOjoicz0BcNTpbnHGDDy8cQ QAZPrUXzOU5BrXpTsScRvk5rQvzNbhA+jQXw5kNInI7yMVV2bdcbROqwDUJhpSQF6XgK bOjOnVQFhCEc3NdQywh8v3e3X5g7dCN7hGQJp/GnFpyg+eT6dcP35Si+dAhk5+RWK7Pl JiTUrrYdR3HLy6vRj6mOQaDIBM1dHKK7jJnmNv61ER77OBmjhwiwqyHq8fkExiRFS9K6 PadWEbFfV4tBKNK7h4xpwRkHqzzjgW5MVsc1eGzEG3mXMoAx6hsIfVMRAYI/x5cCXmLy KwrA== X-Gm-Message-State: AOJu0YzHFweCPXDUG6DgSo56MfiqvkNpawEKy5/BwyjzxrSF36wbh0Td k2FlF4RuJYQYV3tqje9VXwUncKZmvYlhrp/Ygsk= X-Google-Smtp-Source: AGHT+IGAgLIWI8Ss8eHocEgrCRvPPWMkHSTNnbfqDsp9MVuy4/zHOIIknHoUNotokztOceCbF34NuQaPZ/1vbRiEfaQ= X-Received: by 2002:a2e:a7cc:0:b0:2cd:360:135f with SMTP id x12-20020a2ea7cc000000b002cd0360135fmr2635822ljp.73.1704775797969; Mon, 08 Jan 2024 20:49:57 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 8 Jan 2024 20:49:57 -0800 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277604 Archived-At: Jo=C3=A3o T=C3=A1vora writes: >> Not sure how making it a separate commit will help. > > It will say "Stefan Monnier: reformat things", and i will trust that > commit changes nothing functionally. Also, git log -L is pretty smart. Making cleanup type changes is useful for git spelunking, but more importantly it simplifies reviewing. You do not have to manually separate the functional changes from the non-functional ones every time you look at some commit in the future. I'd certainly encourage that practice. Git commits are cheap.