From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#59601: 29.0.50; csharp-mode variables missing prefix Date: Sun, 10 Sep 2023 12:30:06 -0700 Message-ID: References: <87lenx4jbo.fsf@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34429"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acm@muc.de, 59601@debbugs.gnu.org, Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 10 21:31:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qfQ9Q-0008ly-DP for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Sep 2023 21:31:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qfQ96-0007lK-PZ; Sun, 10 Sep 2023 15:31:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfQ94-0007kv-Qy for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2023 15:30:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qfQ94-0001Pj-Fb for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2023 15:30:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qfQ98-000731-28 for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2023 15:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Sep 2023 19:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59601 X-GNU-PR-Package: emacs Original-Received: via spool by 59601-submit@debbugs.gnu.org id=B59601.169437422020936 (code B ref 59601); Sun, 10 Sep 2023 19:31:02 +0000 Original-Received: (at 59601) by debbugs.gnu.org; 10 Sep 2023 19:30:20 +0000 Original-Received: from localhost ([127.0.0.1]:51367 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfQ8R-0005QR-Km for submit@debbugs.gnu.org; Sun, 10 Sep 2023 15:30:19 -0400 Original-Received: from mail-lj1-x22f.google.com ([2a00:1450:4864:20::22f]:51214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfQ8O-00050t-Sz for 59601@debbugs.gnu.org; Sun, 10 Sep 2023 15:30:18 -0400 Original-Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2bf66a32f25so40546961fa.2 for <59601@debbugs.gnu.org>; Sun, 10 Sep 2023 12:30:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694374207; x=1694979007; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=ifbFAuJlo1tf9hb1wEcXYz0M1Z2jZrlHHLVVtNFoNU0=; b=HEXAUZKgHY1nuFLpF2qlPeFGg3y44e7HRV77kgEcw71yiQYEHD5WITAUyWutIs8mEw k43g4Bl+p6Vb5uATy5RN4UoABuoqhr0DXL/h2glC/rH5b/Z8I8/VunVTnZJ/cVs9KW33 e/vwm2mZzPEUSkT04Na0HlnkKzMXlUXvzdjvweBJQK8dTTU9k1mgx/rU19Rb/aQ4EpHO Je4MAS3A9kdqq86LaLyZAzCrw7g66JpQ7fVTGG1zJ2TI1/EVTH5obNx9NN5r1xzsbVSC yZrnqayk7ufv63i6JdPKuihkeS+jGe8xwRDjbnd9vyjkiDqNNNZOcUrw/TKoGqX+rjE7 OJag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694374207; x=1694979007; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ifbFAuJlo1tf9hb1wEcXYz0M1Z2jZrlHHLVVtNFoNU0=; b=jP5EBEDb1o/jQgZGuMPbctddixSszFNah7dhbGzzKCa/ZwJ+Zc8fUAG41iMXk6TYxq J20bR+DM6SbOW0Gn/8LwBMmXXQKEVhK4u6KqLTDXhI6f/bdDAIIZShhcnrWu0ITE6QZl 3pl0wSTQ1GlkB3yFqLWhmEjtpsIbGI2LW1WNrjtrW+7IsporPuIMMURWzzVKIMndhpd0 R10mmgQ6VRXHbxbXzK+wOQlak0wmQIodL/oZxPSKU9OLW0TDGFK5N5P0gUobWlSSXPiO gNWh7jJtQ5CAQb6C025af8IyxzHLUbJeA0+b7lXhP1V9TKqgLXOEJ/M59R+CZ9ck2Gx5 18ZQ== X-Gm-Message-State: AOJu0Yyc1HTUE4gAKpl07PP4hnOlZqT87tKhH9s9YipFHnKZoqsliZo8 FRuTUmCqD2Ru6v3FPMj1cXiYqGt1OPVpo3HxYXQ= X-Google-Smtp-Source: AGHT+IGhzk96kQpeIoOOVmlUWV4f/ABwmkj2eIwk0ykGdKX59SsmRKMju8m+GraFeP3j+KTS8gc4kzybZzf1y1692iY= X-Received: by 2002:a05:651c:1994:b0:2bf:789e:b5dd with SMTP id bx20-20020a05651c199400b002bf789eb5ddmr4201094ljb.53.1694374207179; Sun, 10 Sep 2023 12:30:07 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 10 Sep 2023 12:30:06 -0700 In-Reply-To: <87lenx4jbo.fsf@thornhill.no> (Theodor Thornhill's message of "Sat, 26 Nov 2022 20:16:59 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270003 Archived-At: Theodor Thornhill writes: > Stefan Kangas writes: > >> Severity: wishlist >> >> Should these variables have the prefix `csharp-'? >> >> `codedoc-font-lock-doc-comments' >> `codedoc-font-lock-keywords' >> >> I also see that `codedoc-font-lock-keywords' seems to be unused? > > I believe they need to be like this, for some CC Mode magic reason. See > `javadoc-font-lock-keywords' and friends. I believe CC Mode picks them > up and that they should follow that naming convention. I've CC'd Alan > just to confirm. If you agree Alan then they could be part of > cc-fonts.el now that csharp-mode is in core. What do you think? Ping. Alan, do you have any comments?