From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#15809: 24.3.50; wrong defcustom type for `suggest-key-bindings' Date: Fri, 24 Sep 2021 16:34:38 -0700 Message-ID: References: <87txca8ede.fsf@building.gnus.org> <87zh46wzj7.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000dc7b9705ccc630b2" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27456"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 15809@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 25 01:35:20 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mTuit-0006xm-Of for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Sep 2021 01:35:19 +0200 Original-Received: from localhost ([::1]:48518 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mTuis-0002mi-OS for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 Sep 2021 19:35:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58078) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTuic-0002mR-Fo for bug-gnu-emacs@gnu.org; Fri, 24 Sep 2021 19:35:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47983) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mTuic-0007EH-7T for bug-gnu-emacs@gnu.org; Fri, 24 Sep 2021 19:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mTuic-0008W5-5H for bug-gnu-emacs@gnu.org; Fri, 24 Sep 2021 19:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Sep 2021 23:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15809 X-GNU-PR-Package: emacs Original-Received: via spool by 15809-submit@debbugs.gnu.org id=B15809.163252648632693 (code B ref 15809); Fri, 24 Sep 2021 23:35:02 +0000 Original-Received: (at 15809) by debbugs.gnu.org; 24 Sep 2021 23:34:46 +0000 Original-Received: from localhost ([127.0.0.1]:59527 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTuiM-0008VE-B1 for submit@debbugs.gnu.org; Fri, 24 Sep 2021 19:34:46 -0400 Original-Received: from mail-pj1-f44.google.com ([209.85.216.44]:55101) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTuiK-0008Uy-Gq for 15809@debbugs.gnu.org; Fri, 24 Sep 2021 19:34:45 -0400 Original-Received: by mail-pj1-f44.google.com with SMTP id me1so8036647pjb.4 for <15809@debbugs.gnu.org>; Fri, 24 Sep 2021 16:34:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=LdjsvLZsu04rTSMce3WETkikGn9T3x0aZg5GclqTfn0=; b=CxnSQILzpCqQTsIEWYeJj/FgGQQRMDsvltZCf/l1/Dp1iZuXw9xMKlfbVuspgmeKm0 KtAgIJw22CPQaeH0vAPVPu2xxRsQ3bJvU/W/GgmAWcJaIRAuWn8rjje+Kk9EDpYjBtk1 1oOWHWUvdHHI6GQ4yOehammcMNMr6+lg9rCbuTJ+/k6h3F5+0qn9OblNGLRge2SOqee2 09oGx9xP3Nl0g6X4SnhI47gga9oT8FYdoeFcdlN2MwpHFHuYJbtMtGijz1aT03Y3orIh tlVZ3y6ej1oj9jDNOMsCvl1Z6XF5XgRTuo18k1kjfRkWuG0rWyHjaOuCZfdBFB8fglzf I56w== X-Gm-Message-State: AOAM531KxZp2X4OG0x9v8z2i9l8Tj7cTvXTuCs446xkqdVGYDtV/EsLr 2ecxkd7+/pm/C9HrxFUHv5arvFOpIGO8fWhRcQw= X-Google-Smtp-Source: ABdhPJwppM5O21lX54f3qhMQGNywHAufwFlGVHk+DgC6OQGrcehZIjlK2y4UmYchExn7fTuT04abCgKZMwy2yR8D42A= X-Received: by 2002:a17:90a:5583:: with SMTP id c3mr5106583pji.133.1632526478892; Fri, 24 Sep 2021 16:34:38 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 24 Sep 2021 16:34:38 -0700 In-Reply-To: <87zh46wzj7.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 28 Oct 2020 09:00:28 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215352 Archived-At: --000000000000dc7b9705ccc630b2 Content-Type: text/plain; charset="UTF-8" tags 15809 + patch thanks Lars Ingebrigtsen writes: > Stefan Kangas writes: > >>> Or to be more general, perhaps there should be a custom interval type? Like >>> >>> (integer :minimum 1) >>> >>> ? >>> >>> Or just `natnum'? >> >> natnum sounds like it could be generally useful, yes. We have plenty of >> customizable things that should never be negative. > > Yeah, that's the most common numerical restriction (by far), and the few > variables that are numbers with other ranges can be done with a > defcustom predicate. How about the attached? --000000000000dc7b9705ccc630b2 Content-Type: text/x-diff; charset="US-ASCII"; name="0001-New-type-natnum-for-defcustom.patch" Content-Disposition: attachment; filename="0001-New-type-natnum-for-defcustom.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f41b1bc94f6c0035_0.1 RnJvbSA3MzEzZDYwYTE2M2I2NmFmMDM5ZWZjNjkwNDZlNGRmNGRmZjIxNDU3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5AbWFyeGlzdC5zZT4KRGF0 ZTogU2F0LCAyNSBTZXAgMjAyMSAwMToxNTo0OSArMDIwMApTdWJqZWN0OiBbUEFUQ0ggMS8yXSBO ZXcgOnR5cGUgbmF0bnVtIGZvciBkZWZjdXN0b20KCiogbGlzcC93aWQtZWRpdC5lbCAobmF0bnVt KTogTmV3IHdpZGdldCB0eXBlLiAgKEJ1ZyMxNTgwOSkKKiBkb2MvbGlzcHJlZi9jdXN0b21pemUu dGV4aSAoU2ltcGxlIFR5cGVzKTogRG9jdW1lbnQgaXQuCi0tLQogZG9jL2xpc3ByZWYvY3VzdG9t aXplLnRleGkgfCAzICsrKwogZXRjL05FV1MgICAgICAgICAgICAgICAgICAgfCA1ICsrKysrCiBs aXNwL3dpZC1lZGl0LmVsICAgICAgICAgICB8IDcgKysrKysrKwogMyBmaWxlcyBjaGFuZ2VkLCAx NSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZG9jL2xpc3ByZWYvY3VzdG9taXplLnRleGkg Yi9kb2MvbGlzcHJlZi9jdXN0b21pemUudGV4aQppbmRleCBiYzM1OTgyYzE3Li5iOTNiOGJjMDE1 IDEwMDY0NAotLS0gYS9kb2MvbGlzcHJlZi9jdXN0b21pemUudGV4aQorKysgYi9kb2MvbGlzcHJl Zi9jdXN0b21pemUudGV4aQpAQCAtNTk0LDYgKzU5NCw5IEBAIFNpbXBsZSBUeXBlcwogQGl0ZW0g aW50ZWdlcgogVGhlIHZhbHVlIG11c3QgYmUgYW4gaW50ZWdlci4KIAorQGl0ZW0gbmF0bnVtCitU aGUgdmFsdWUgbXVzdCBiZSBhIG5vbm5lZ2F0aXZlIGludGVnZXIuCisKIEBpdGVtIG51bWJlcgog VGhlIHZhbHVlIG11c3QgYmUgYSBudW1iZXIgKGZsb2F0aW5nIHBvaW50IG9yIGludGVnZXIpLgog CmRpZmYgLS1naXQgYS9ldGMvTkVXUyBiL2V0Yy9ORVdTCmluZGV4IGMyNjZkZGRhZmEuLmIyZTcz MzE1MTcgMTAwNjQ0Ci0tLSBhL2V0Yy9ORVdTCisrKyBiL2V0Yy9ORVdTCkBAIC0zNzI0LDYgKzM3 MjQsMTEgQEAgaW5zdGVhZCBvZiBvbmx5IGJlY29taW5nIGF2YWlsYWJsZSBhZnRlciBkb2luZyAo Zm9yIGluc3RhbmNlKQogLS0tCiAqKiAnOnNhZmUnIHNldHRpbmdzIGluICdkZWZjdXN0b20nIGFy ZSBub3cgcHJvcGFnYXRlZCB0byB0aGUgbG9hZGRlZnMgZmlsZXMuCiAKKysrKworKiogTmV3ICc6 dHlwZScgZm9yICdkZWZjdXN0b20nIGZvciBub25uZWdhdGl2ZSBpbnRlZ2Vycy4KK1RoZSBuZXcg J25hdG51bScgdHlwZSBjYW4gYmUgdXNlZCBmb3Igb3B0aW9ucyB0aGF0IHNob3VsZCBiZQorbm9u bmVnYXRpdmUgaW50ZWdlcnMuCisKICsrKwogKiogRVJUIGNhbiBub3cgb3V0cHV0IG1vcmUgdmVy Ym9zZSB0ZXN0IGZhaWx1cmUgcmVwb3J0cy4KIElmIHRoZSAnRU1BQ1NfVEVTVF9WRVJCT1NFJyBl bnZpcm9ubWVudCB2YXJpYWJsZSBpcyBzZXQsIGZhaWx1cmUKZGlmZiAtLWdpdCBhL2xpc3Avd2lk LWVkaXQuZWwgYi9saXNwL3dpZC1lZGl0LmVsCmluZGV4IGFiMzU4ZGE3ZTMuLjcyMzUzYjkxOTAg MTAwNjQ0Ci0tLSBhL2xpc3Avd2lkLWVkaXQuZWwKKysrIGIvbGlzcC93aWQtZWRpdC5lbApAQCAt MzY0NCw2ICszNjQ0LDEzIEBAICdpbnRlZ2VyCiAgIDp0eXBlLWVycm9yICJUaGlzIGZpZWxkIHNo b3VsZCBjb250YWluIGFuIGludGVnZXIiCiAgIDptYXRjaC1hbHRlcm5hdGl2ZXMgJyhpbnRlZ2Vy cCkpCiAKKyhkZWZpbmUtd2lkZ2V0ICduYXRudW0gJ3Jlc3RyaWN0ZWQtc2V4cAorICAiQSBub25u ZWdhdGl2ZSBpbnRlZ2VyLiIKKyAgOnRhZyAiSW50ZWdlciAocG9zaXRpdmUpIgorICA6dmFsdWUg MAorICA6dHlwZS1lcnJvciAiVGhpcyBmaWVsZCBzaG91bGQgY29udGFpbiBhIG5vbm5lZ2F0aXZl IGludGVnZXIiCisgIDptYXRjaC1hbHRlcm5hdGl2ZXMgJyhuYXRudW1wKSkKKwogKGRlZmluZS13 aWRnZXQgJ251bWJlciAncmVzdHJpY3RlZC1zZXhwCiAgICJBIG51bWJlciAoZmxvYXRpbmcgcG9p bnQgb3IgaW50ZWdlcikuIgogICA6dGFnICJOdW1iZXIiCi0tIAoyLjMwLjIKCg== --000000000000dc7b9705ccc630b2 Content-Type: text/x-diff; charset="US-ASCII"; name="0002-Set-type-of-suggest-key-bindings-to-natnum.patch" Content-Disposition: attachment; filename="0002-Set-type-of-suggest-key-bindings-to-natnum.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f41b1bc94f6c0035_0.2 RnJvbSA5NTEyN2YwZDc0NDE5OTljNzhlNGM0ZTlhYjgyMTc3NTcxNDhlNWM5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5AbWFyeGlzdC5zZT4KRGF0 ZTogU2F0LCAyNSBTZXAgMjAyMSAwMToyNTo0NyArMDIwMApTdWJqZWN0OiBbUEFUQ0ggMi8yXSBT ZXQgOnR5cGUgb2Ygc3VnZ2VzdC1rZXktYmluZGluZ3MgdG8gbmF0bnVtCgoqIGxpc3Avc2ltcGxl LmVsIChzdWdnZXN0LWtleS1iaW5kaW5ncyk6IFNldCA6dHlwZSB0bwpuYXRudW0uICAoQnVnIzE1 ODA5KQotLS0KIGxpc3Avc2ltcGxlLmVsIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0 aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9zaW1wbGUuZWwgYi9saXNw L3NpbXBsZS5lbAppbmRleCAyOThlM2VhNWVlLi5kZDQ4MDM5NmY2IDEwMDY0NAotLS0gYS9saXNw L3NpbXBsZS5lbAorKysgYi9saXNwL3NpbXBsZS5lbApAQCAtMjE0NCw3ICsyMTQ0LDcgQEAgc3Vn Z2VzdC1rZXktYmluZGluZ3MKIFxcW2V4ZWN1dGUtZXh0ZW5kZWQtY29tbWFuZF0gZm9yIGFsbCBj b21tYW5kcyB0aGF0IGhhdmUgdGhlbS4iCiAgIDpncm91cCAna2V5Ym9hcmQKICAgOnR5cGUgJyhj aG9pY2UgKGNvbnN0IDp0YWcgIm9mZiIgbmlsKQotICAgICAgICAgICAgICAgICAoaW50ZWdlciA6 dGFnICJ0aW1lIiAyKQorICAgICAgICAgICAgICAgICAobmF0bnVtIDp0YWcgInRpbWUiIDIpCiAg ICAgICAgICAgICAgICAgIChvdGhlciA6dGFnICJvbiIpKSkKIAogKGRlZmN1c3RvbSBleHRlbmRl ZC1jb21tYW5kLXN1Z2dlc3Qtc2hvcnRlciB0Ci0tIAoyLjMwLjIKCg== --000000000000dc7b9705ccc630b2--