From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#15112: 24.3; package.el byte compile autoloads Date: Thu, 26 Nov 2020 05:18:36 -0500 Message-ID: References: <8738q96sb1.fsf@blah.blah> <85zhjtibwn.fsf@gmail.com> <87im9s8nrz.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30297"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Noam Postavsky , 15112@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 26 11:19:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kiEMq-0007kB-2Q for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Nov 2020 11:19:12 +0100 Original-Received: from localhost ([::1]:55270 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiEMp-0001S6-2H for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Nov 2020 05:19:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43350) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiEMg-0001Rk-3p for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2020 05:19:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55255) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kiEMf-00065a-T3 for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2020 05:19:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kiEMf-0001Cu-Pc for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2020 05:19:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Nov 2020 10:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15112 X-GNU-PR-Package: emacs Original-Received: via spool by 15112-submit@debbugs.gnu.org id=B15112.16063859254617 (code B ref 15112); Thu, 26 Nov 2020 10:19:01 +0000 Original-Received: (at 15112) by debbugs.gnu.org; 26 Nov 2020 10:18:45 +0000 Original-Received: from localhost ([127.0.0.1]:38568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kiEMO-0001CP-M5 for submit@debbugs.gnu.org; Thu, 26 Nov 2020 05:18:44 -0500 Original-Received: from mail-ej1-f50.google.com ([209.85.218.50]:38214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kiEMN-0001CC-3t for 15112@debbugs.gnu.org; Thu, 26 Nov 2020 05:18:43 -0500 Original-Received: by mail-ej1-f50.google.com with SMTP id a16so2138568ejj.5 for <15112@debbugs.gnu.org>; Thu, 26 Nov 2020 02:18:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=0cHDOOGd0Cuf3J8EqXqsQ23beerggf79UcswfrXXXt0=; b=lSlelPoJ2QDIAQ7iWwzFQdRExs3prgCACcX/5ZwDWbfuCBEb56ohA30zYI9KR9xLer VKe/7VECwr6KIQZgFTknXN5ggpdDXXy4/QNha6J267AQ6vZIDyi2brDE2+98GCNwtWXY Qf2f5rCErAmBYmpXZZaJVxKdHPpHJVUnrT8Q+mIjF4we8569jc6Jpunq3EQm6NOVxhA6 57LRM6cUMm/SCZvTYGyk8nZLUGjQPSlOYLX0ew0Q2xRJvHAoi1748M0I33u2Xq4sYXoR YzR085uqgpp2XZKvocdbAgy8am5WZFMuFfivbxcnVQcy58bdDmrtGb3cNSXEtWiwRavK 2Bgg== X-Gm-Message-State: AOAM532gq4dnGv8wZTAy2uvJ8JjtJ8eS6QOoX8uVhzWYQ/SrjAx31pA3 pA7uMIE/3dgDKiKwq8dsqH6f3f1M6Jygdx6LzPg= X-Google-Smtp-Source: ABdhPJxCHAn0or2udoEj8i3XyFcZm9CFSEX4rGAJSm3Nj5M/RR3/d5ivIfxtNCeFZRrSkbsM6xECDrAp5jlKFPsj1P0= X-Received: by 2002:a17:906:11d0:: with SMTP id o16mr2037086eja.25.1606385917249; Thu, 26 Nov 2020 02:18:37 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 26 Nov 2020 05:18:36 -0500 In-Reply-To: <87im9s8nrz.fsf@gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194272 Archived-At: Hi Michael, Michael Albinus writes: >> I made a little experiment and of course byte-compiling these files >> gives us a ton of headaches, see below. So I'm not sure this is all >> worth it. Do we have reason to believe that byte-compiling these files >> would give any significant performance increase? >> >> ELC net/tramp-loaddefs.elc > > I don't know which kind of experiment you have applied, so I cannot say > anything about the compilation errors. However, I wonder where paths > like "net/tramp-loaddefs.elc" come from. We're speaking about > package.el, meaning we're speaking about ELPA. Tramp in ELPA doesn't use > any subdirectory "net". I used this patch: diff --git a/lisp/emacs-lisp/autoload.el b/lisp/emacs-lisp/autoload.el index 07bda537b3..e32d74fa7c 100644 --- a/lisp/emacs-lisp/autoload.el +++ b/lisp/emacs-lisp/autoload.el @@ -373,7 +373,7 @@ autoload-rubric ";;; Code:\n\n" (if lp "(add-to-list 'load-path (directory-file-name - (or (file-name-directory #$) (car load-path))))\n= \n") + (or (file-name-directory load-file-name) (car load-path))))\n\n") "=0C\n" ;; This is used outside of autoload.el, eg cus-dep, finder. (if feature @@ -382,7 +382,6 @@ autoload-rubric (file-name-sans-extension basename)))) ";; Local Variables:\n" ";; version-control: never\n" - ";; no-byte-compile: t\n" ;; #$ is byte-compiled into nil. ";; no-update-autoloads: t\n" ";; coding: utf-8\n" ";; End:\n" And ran "make bootstrap". > Anyway, I don't believe we'll see a performance boost after > byte-compiling loaddef files. They just contain function and variable > declarations, no implementation (but the initial values of variables). > > There are exceptions like in tramp-loaddefs.el, but they still don't > count wrt performance, I believe. This would be my guess too. It seems like more trouble than it's worth.