From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#50007: 28.0.50; normalize logic surrounding erc-server-reconnecting Date: Sun, 19 Sep 2021 09:36:14 -0700 Message-ID: References: <87a6lojcij.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20034"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Amin Bandali , 50007@debbugs.gnu.org To: "J.P." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 19 18:37:28 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRzom-0004zW-1F for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Sep 2021 18:37:28 +0200 Original-Received: from localhost ([::1]:37092 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRzok-0005RG-Eq for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Sep 2021 12:37:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43428) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRzoN-0005N9-Hg for bug-gnu-emacs@gnu.org; Sun, 19 Sep 2021 12:37:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56408) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mRzoN-00034c-AP for bug-gnu-emacs@gnu.org; Sun, 19 Sep 2021 12:37:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mRzoN-0004ua-88 for bug-gnu-emacs@gnu.org; Sun, 19 Sep 2021 12:37:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Sep 2021 16:37:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50007 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50007-submit@debbugs.gnu.org id=B50007.163206938218734 (code B ref 50007); Sun, 19 Sep 2021 16:37:03 +0000 Original-Received: (at 50007) by debbugs.gnu.org; 19 Sep 2021 16:36:22 +0000 Original-Received: from localhost ([127.0.0.1]:39701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRznh-0004s6-VF for submit@debbugs.gnu.org; Sun, 19 Sep 2021 12:36:22 -0400 Original-Received: from mail-pj1-f47.google.com ([209.85.216.47]:53993) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRzng-0004rj-9t for 50007@debbugs.gnu.org; Sun, 19 Sep 2021 12:36:21 -0400 Original-Received: by mail-pj1-f47.google.com with SMTP id j1so10294850pjv.3 for <50007@debbugs.gnu.org>; Sun, 19 Sep 2021 09:36:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=PJVA5Wgs5TB2Ecc9s8M97j64Ii+JTUFgm+oCC5pMkLY=; b=EQrXJnCyUKEMEj3zmynQzj5AcJ5kU5eZuMeA7j2I0bHsfSeykEBkhDzH5WG7a4rfmK /09L0toh6FXhwp4aOa/U1ZE3rtQWwGQGZ45AcbHwPGGdDcY2wc0y6XPqhzHVBcrk4tFM 7jXdsuu8g34qNgsPVHeg2QS8VyuY5UAbGKZyHr7SzONnv/8JWDUW2ns9FgVaM1bI6SwD tM4cC+WcZvtVg0RwF/E2txpQaR3l820dbL3fTSrP6JGVE3SXguZXjyYkG0NRyrEBjHMU ZaXPoUkOumuiidFRRxRaNrQrNZyxo9WL0+2TKmi0nBnyTxomMTi6FAOdG6wFbHPuGoxE 3OtA== X-Gm-Message-State: AOAM530VxgQMVXZC/i3YBK4QRpxhPWeBksZJo3WiO1VKoz9b2B0Guzcf IWnycbXjwZt3lyGrBIxrPp10EIC+Kg32cmbrDj9YTDdp X-Google-Smtp-Source: ABdhPJxZU4TyaONWnjTxk8D4HosqlYWCU5HmDaA4VXKwu9YHJ2+fg/PxrJnuCiDd37bGiQsC/ph+gScILPsIW99TQhM= X-Received: by 2002:a17:90b:3805:: with SMTP id mq5mr32326955pjb.143.1632069374684; Sun, 19 Sep 2021 09:36:14 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 19 Sep 2021 09:36:14 -0700 In-Reply-To: <87a6lojcij.fsf@neverwas.me> (J. P.'s message of "Wed, 11 Aug 2021 07:12:52 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214748 Archived-At: "J.P." writes: > Tags: patch > > Knowing when we're reconnecting and having that logic be as sane and > straightforward as possible is (IMO) a critical component of unraveling > the buffer-association game I've been trying to drag everyone into. > > The existing approach is troublesome because it's basically inscrutable > in the sense of being too difficult to sit down and reason through once > session identities enter the fray (at least for a simpleton like me). > And though the solution I'm proposing may seem underwhelming, it wasn't > just intuited out of thin air but rather discovered with the backing of > behavioral tests like the ones included in these patches [1]. Thanks. > > > [1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=48598 > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=49860 Copying in the ERC maintainer Amin Bandali here. Amin, could you help review this patch?