From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#71499: [PATCH] Make whitespace.el cleanup add missing final newline Date: Thu, 20 Jun 2024 07:55:19 +0000 Message-ID: References: <9453e7ef-dc31-4074-bba7-55a192313ccd@app.fastmail.com> <86tthy1u37.fsf@gnu.org> <86cyom1os2.fsf@gnu.org> <86jzitz1l0.fsf@gnu.org> <87sexfaf2i.fsf@gmail.com> <86ed8zy9gc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33389"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acorallo@gnu.org, 71499@debbugs.gnu.org, bkhl@elektrubadur.se To: Eli Zaretskii , Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 20 09:57:28 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sKCfg-0008UQ-NI for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Jun 2024 09:57:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sKCfF-0001fP-8H; Thu, 20 Jun 2024 03:57:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKCfC-0001ae-VI for bug-gnu-emacs@gnu.org; Thu, 20 Jun 2024 03:56:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sKCfC-0008Nz-EI for bug-gnu-emacs@gnu.org; Thu, 20 Jun 2024 03:56:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sKCfF-0000hk-M0 for bug-gnu-emacs@gnu.org; Thu, 20 Jun 2024 03:57:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Jun 2024 07:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71499 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71499-submit@debbugs.gnu.org id=B71499.17188701932662 (code B ref 71499); Thu, 20 Jun 2024 07:57:01 +0000 Original-Received: (at 71499) by debbugs.gnu.org; 20 Jun 2024 07:56:33 +0000 Original-Received: from localhost ([127.0.0.1]:47648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKCem-0000gr-Td for submit@debbugs.gnu.org; Thu, 20 Jun 2024 03:56:33 -0400 Original-Received: from mail-ej1-f53.google.com ([209.85.218.53]:42306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sKCek-0000gZ-0O for 71499@debbugs.gnu.org; Thu, 20 Jun 2024 03:56:30 -0400 Original-Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a6e43dad8ecso101687966b.1 for <71499@debbugs.gnu.org>; Thu, 20 Jun 2024 00:56:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718870120; x=1719474920; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=vDLu1PbkGdMjljarpAZ5/hYv9+1o/4Tnq2JwfRvSDmc=; b=Nv1GhCIo9WK/MnqwTeYS4xtXbohNLbumfvmExFWtJdllsq4XWAmcry/dePjZ8tAkYg Wj2eDgOIvIeTArT9jpDQHVOfezatmhYZrZ0c3TO3v9BhQONJWMCeAn6z5htMApx61aGF 4bR1hUx7yUVRBm/ZBPiCF7yiG5BbPjLMbg/6hoF7Usj8795FjOo83m1YoVrIYkHgTMSv If9+t97NNkG5yQPojrGoEGjVGxJCdUqj0vwh7bY8vwmRXHk3GYENHcQdAqnlSHCBYjmd UJLcQTmBGv3hLL3nkId8aNn7Z8VGZEbhIKhksBnqQ2iOy3BKCVzX/rd3FOuFpPYahzPz Ws7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718870120; x=1719474920; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=vDLu1PbkGdMjljarpAZ5/hYv9+1o/4Tnq2JwfRvSDmc=; b=FD3NmR/9TLuP8APKQch4HQBLF/w3Cqt+VXdeZ0qZ/rhGn9WVmQ8Ur1N4DoGTBCXd7+ SJn38D2Bj/TDhwbDP0nF4NkgXkTtFVsmB5v1qCpVmIjp2vvLmxoSYQdZZNzg2rLHxseB NlLY8GeYxN1Yh49W5ti5Zax3w1u93kn7J7Sl5uTg/icaOmRKdn+z1wkVZDBIFlRZl+9p c9+4E2LcjVBcRkV9LyxWJkTTc45oVw2GocAu6EE0RniKN76uB/nnMyPO99RbqR/L+6el dPQPe/r6jt1dXldAi3/1NyoM3PudKWnGNbpz4zAykPUEg7oYarUe1NuHtquu+C+zGemY sT8w== X-Forwarded-Encrypted: i=1; AJvYcCWtxzbuEFvmZPfsRfvjOwsk222uyg+CCz30Ad+gVcOpqTcn3rFtgT2mvnGebwnm5hzyE2HQkQa+lMSArKoQfDiStQQ6+s8= X-Gm-Message-State: AOJu0YyLAogE7WaY62vQLMv5FVDHjpHCZBQk+/6vYV7pYMRvn5YcGJ4P eudRcXl1zTyAR2Rgvwpg+T0jfLBDb4wKoPtw9sYqNwBQQXV86L4S9V0ZPQqmXeEcSrSBjDbcla/ IYJYQJOxvZ8psfp1rvXY1uD64Cu8= X-Google-Smtp-Source: AGHT+IHV5n8MHBfkIa/KzIaCFIUqkPLfzMCzTmSnjJlHmeGgC7e9QJeiH5L7d+/TYI0CRRIKoOfHrVAY2ogPZlQXhCQ= X-Received: by 2002:a17:906:684b:b0:a6f:8f48:5d29 with SMTP id a640c23a62f3a-a6f9506efbcmr487754666b.28.1718870120223; Thu, 20 Jun 2024 00:55:20 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 20 Jun 2024 07:55:19 +0000 In-Reply-To: <86ed8zy9gc.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287537 Archived-At: Eli Zaretskii writes: >> From: Robert Pluim >> Cc: Andrea Corallo , 71499@debbugs.gnu.org, >> stefankangas@gmail.com, bkhl@elektrubadur.se >> Date: Fri, 14 Jun 2024 14:23:17 +0200 >> >> >>>>> On Thu, 13 Jun 2024 11:30:51 +0300, Eli Zaretskii s= aid: >> >> I'm as well for having the patch in, but I guess would be safer i= n 31 so >> >> we have plenty of time to react if needed. >> >> Eli> OK, thanks. I will then install after the branch is cut. >> >> Eli> Meanwhile, Bj=C3=B6rn, I have a few comments to the patch: >> >> Eli> . it needs a NEWS entry announcing the new feature >> Eli> . is there any reason your code to handle the missing newline= is not >> Eli> identical to what the implementation of require-final-newli= ne >> Eli> does? >> >> I=CA=BCm going to chime in and say that, even though I highlight missing >> newlines at eob, I don=CA=BCt normally set `require-final-newline' to t, >> because of various reasons involving collaboration with others. So I=CA= =BCd >> have to turn this off once it goes in. Could you explain why you'd need to turn it off? Do you usually use `whitespace-cleanup` on files where you collaborate with others, but then you specifically don't want to ever touch newlines at eob? > Maybe this feature should take a hint from require-final-newline? To my mind, the main use case of this feature would be users that don't want to set `require-final-newline`, instead preferring to make such fixes manually.