unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Mauro Aranda <maurooaranda@gmail.com>, 42887@debbugs.gnu.org
Subject: bug#42887: 28.0.50; Customize Group doesn't show/hide option on repeated clicking
Date: Mon, 11 Sep 2023 11:01:49 -0700	[thread overview]
Message-ID: <CADwFkmkXJ9CB27xJoy8gRFTK9P6EfmBRor9PZYxG1oojS=SiFw@mail.gmail.com> (raw)
In-Reply-To: <7c86ca80-e4ab-7954-d21c-9f7a908aa9f8@gmail.com>

Mauro Aranda <maurooaranda@gmail.com> writes:

> I don't know why I couldn't reproduce it three years ago, but I managed
> to do that now, I think.
>
> Could you please check if the following change to
> widget-button-release-event-p fixes this for you?
>
> (defun widget-button-release-event-p (event)
>    "Non-nil if EVENT is a mouse-button-release event object."
>    (and (eventp event)
>         (memq (event-basic-type event) '(mouse-1 mouse-2 mouse-3))
>         (seq-some (lambda (el)
>                     (memq el '(click drag triple double)))
>                   (event-modifiers event))))
>
>
> Please do try it with mouse-1 and mouse-2 if you can.
>
> (I know that the mark gets set with repeating clicks with mouse-1,
> and there's a signal with mouse-2, but I'm focusing on whether this
> changes fixes the detection of repeated clicks)

Thanks.

I don't currently have convenient access to the machine where I can
reproduce this, and it will be at least another couple of weeks until I
do.  Apologies in advance if it takes a while before I can review this.

If someone else can reproduce and this patch fixes it for them, that
works too.





  reply	other threads:[~2023-09-11 18:01 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-16 14:02 bug#42887: 28.0.50; Customize Group doesn't show/hide option on repeated clicking Stefan Kangas
2020-08-16 14:51 ` Eli Zaretskii
2020-08-17 18:25   ` Stefan Kangas
2020-09-05 12:53 ` Mauro Aranda
2020-11-13 23:20   ` Stefan Kangas
2020-11-17 11:25     ` Mauro Aranda
2020-11-17 11:48       ` Stefan Kangas
2020-11-17 12:07         ` Mauro Aranda
2020-11-14  4:27 ` tsuucat via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-07  1:15 ` Lars Ingebrigtsen
2022-02-07  3:19   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-07  3:42     ` Lars Ingebrigtsen
2022-05-26  5:50   ` Stefan Kangas
2022-05-26 11:03     ` Lars Ingebrigtsen
2023-09-11 13:34 ` Mauro Aranda
2023-09-11 18:01   ` Stefan Kangas [this message]
2023-09-11 19:20     ` Mauro Aranda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkmkXJ9CB27xJoy8gRFTK9P6EfmBRor9PZYxG1oojS=SiFw@mail.gmail.com' \
    --to=stefankangas@gmail.com \
    --cc=42887@debbugs.gnu.org \
    --cc=maurooaranda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).