unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Manuel Giraud <manuel@ledu-giraud.fr>, 61508@debbugs.gnu.org
Subject: bug#61508: 30.0.50; [PATCH] Update thumbnail buffer's header more
Date: Wed, 15 Feb 2023 05:58:15 -0800	[thread overview]
Message-ID: <CADwFkmkVEk5CnFaFSf2DD+6CP05GhAHndRVKJB5Q6-4DwPsEUw@mail.gmail.com> (raw)
In-Reply-To: <8735785o15.fsf@ledu-giraud.fr>

Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs@gnu.org> writes:

> Without this patch, the header of the thumbnail buffer does not always
> update correctly (for instance with "C-t .", "C-t a" and even "C-t d").

Thanks for the patch.

> From bfff40cc6e9327d90040578d3b751c03bb0911eb Mon Sep 17 00:00:00 2001
> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Date: Tue, 14 Feb 2023 15:08:17 +0100
> Subject: [PATCH] Update thumbnail buffer's header more
>
> * lisp/image/image-dired.el (image-dired-display-thumbs): Call
> image-dired--update-header-line.
> ---
>  lisp/image/image-dired.el | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/image/image-dired.el b/lisp/image/image-dired.el
> index 49b8d9f03c8..cfcd1851188 100644
> --- a/lisp/image/image-dired.el
> +++ b/lisp/image/image-dired.el
> @@ -593,7 +593,8 @@ image-dired-display-thumbs
>        (if do-not-pop
>            (display-buffer buf)
>          (pop-to-buffer buf))
> -      (image-dired--line-up-with-method))))
> +      (image-dired--line-up-with-method)
> +      (image-dired--update-header-line))))
>
>  ;;;###autoload
>  (defun image-dired-show-all-from-dir (dir)
> --
> 2.39.1

Eli, is it okay to install the above bug fix on the emacs-29 branch at
this point?





  reply	other threads:[~2023-02-15 13:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-14 14:17 bug#61508: 30.0.50; [PATCH] Update thumbnail buffer's header more Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-15 13:58 ` Stefan Kangas [this message]
2023-02-15 14:14   ` Eli Zaretskii
2023-02-18 22:51     ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-19  6:26       ` Eli Zaretskii
2023-02-15 16:01   ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADwFkmkVEk5CnFaFSf2DD+6CP05GhAHndRVKJB5Q6-4DwPsEUw@mail.gmail.com \
    --to=stefankangas@gmail.com \
    --cc=61508@debbugs.gnu.org \
    --cc=manuel@ledu-giraud.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).