From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#13780: 24.2; Making find-file-hook customizable seems to cause troublle Date: Fri, 4 Dec 2020 06:05:47 -0500 Message-ID: References: <87k3q1gpba.fsf@sc3d.org> <83sg9ycrgp.fsf@gnu.org> <83sg8xsbu8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26786"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 13780@debbugs.gnu.org, monnier@iro.umontreal.ca, rrt@sc3d.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 04 12:06:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kl8uk-0006rf-Gl for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Dec 2020 12:06:14 +0100 Original-Received: from localhost ([::1]:38742 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kl8uj-0007do-Gw for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Dec 2020 06:06:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38984) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kl8uX-0007dU-Vp for bug-gnu-emacs@gnu.org; Fri, 04 Dec 2020 06:06:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59695) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kl8uX-0001fz-O2 for bug-gnu-emacs@gnu.org; Fri, 04 Dec 2020 06:06:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kl8uX-0006DV-JH for bug-gnu-emacs@gnu.org; Fri, 04 Dec 2020 06:06:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Dec 2020 11:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13780 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 13780-submit@debbugs.gnu.org id=B13780.160707995523878 (code B ref 13780); Fri, 04 Dec 2020 11:06:01 +0000 Original-Received: (at 13780) by debbugs.gnu.org; 4 Dec 2020 11:05:55 +0000 Original-Received: from localhost ([127.0.0.1]:43006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kl8uQ-0006D3-Q0 for submit@debbugs.gnu.org; Fri, 04 Dec 2020 06:05:54 -0500 Original-Received: from mail-pf1-f175.google.com ([209.85.210.175]:36330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kl8uQ-0006Ck-1P for 13780@debbugs.gnu.org; Fri, 04 Dec 2020 06:05:54 -0500 Original-Received: by mail-pf1-f175.google.com with SMTP id b26so3471417pfi.3 for <13780@debbugs.gnu.org>; Fri, 04 Dec 2020 03:05:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc :content-transfer-encoding; bh=mD21cwzbp88uOP7sAFp6XAnd204E5YNo6SRH8EEx5Wk=; b=jcTfzs2vnxtgK2TanuAkkBH3DRo7eJEtCblZJ52RNHg16eto7cnrslnhEtgIs6/piO Y/Z9h4wek/lf7yELGfTsdE+7Ma4IGJiw9TsYJr2Pi+3+4sDUy72DZ7gq+vYqH5mHUL/t jrm9YzgAgMvRKc6zx5TCWNRlmkfH6WYR27Sh8JlVWZfmURKOvl+KrcseadvgnybppV95 LPWejC5ZE0hFXHuUbV892ge7c7i8OJrhqXAefvb4ehuqkN/NbtMN8kR04kUl0+DNnR1J sFn2KwhkNwV5UUPQpshsygBk25Rm0QRtWA6Qpsc9CQR+ez8dkc3ZdnwccoTkWicWkzUk MS8g== X-Gm-Message-State: AOAM533mk10dytsVY9q5iL0KfWmP5K0tE9A8IUGFEXSHi/dLhgUbYBQN T+3gU5hgstKG0zzIN8KjG0JG5+OygZBdxHL6esE= X-Google-Smtp-Source: ABdhPJxmZdZNNHGIHP3H/RiFdIUAg+ocXRWY247i0bJOsPbYEJNyXNPuCpatmPZXwX8tCMpuZJcO23amwkLUtEtqUOY= X-Received: by 2002:a63:cd09:: with SMTP id i9mr7027688pgg.363.1607079948459; Fri, 04 Dec 2020 03:05:48 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 4 Dec 2020 06:05:48 -0500 In-Reply-To: (Stefan Kangas's message of "Wed, 25 Nov 2020 16:07:00 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194969 Archived-At: tags 13780 + wontfix close 13780 thanks Stefan Kangas writes: > Eli Zaretskii writes: > >>> Stefan Monnier writes: >>> >>> >>> So until Custom is fixed to actually properly handle customisation = of >>> >>> hooks (e.g. by storing "add functions foo, bar, and baz" rather tha= n >>> >>> "ignore current value and just set it to (foo bar baz)"). >>> >> This sentence seems to be missing its main clause=E2=80=A6 >>> > >>> > That's not just an appearance. Its main clause is: >>> > >>> > So until Custom ...blabla... I think it's better to use defcustom = for >>> > hooks very sparingly, i.e. only for those hook we can reasonably >>> > expect will only be modified by the user's customization. >> >> IMO, this rationale is good for future additions, not for >> already-existing user options. We cannot un-defcustom a user option >> just because someone became confused by some subtle use case. This is >> the price we pay for the flexibility and power we have in Emacs. > > Fine by me. No further comments within 7 days, closing as wontfix.