From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#42839: [PATCH] Support displaying line numbers in goto-line Date: Thu, 13 Aug 2020 07:30:40 -0700 Message-ID: References: <83mu2yn131.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17631"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 42839@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 13 16:31:35 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6EGV-0004UZ-C1 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Aug 2020 16:31:35 +0200 Original-Received: from localhost ([::1]:38160 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6EGU-0000gf-CP for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Aug 2020 10:31:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51440) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6EFy-0000EY-Mh for bug-gnu-emacs@gnu.org; Thu, 13 Aug 2020 10:31:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39074) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k6EFy-0002pL-Cr for bug-gnu-emacs@gnu.org; Thu, 13 Aug 2020 10:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k6EFy-0006sa-9t for bug-gnu-emacs@gnu.org; Thu, 13 Aug 2020 10:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Aug 2020 14:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 42839-submit@debbugs.gnu.org id=B42839.159732904926417 (code B ref 42839); Thu, 13 Aug 2020 14:31:02 +0000 Original-Received: (at 42839) by debbugs.gnu.org; 13 Aug 2020 14:30:49 +0000 Original-Received: from localhost ([127.0.0.1]:50619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6EFk-0006s1-PK for submit@debbugs.gnu.org; Thu, 13 Aug 2020 10:30:48 -0400 Original-Received: from mail-yb1-f176.google.com ([209.85.219.176]:36461) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6EFi-0006rW-JK for 42839@debbugs.gnu.org; Thu, 13 Aug 2020 10:30:47 -0400 Original-Received: by mail-yb1-f176.google.com with SMTP id g3so3424027ybc.3 for <42839@debbugs.gnu.org>; Thu, 13 Aug 2020 07:30:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=UYvuqLjYW08GFAo9J+AenoxWwWZBnb6GSyICnMfxfmo=; b=b9hVAScgFnlmr4/1HhKPmd1QfGJ3z4SipqZbotDfreB4EZVZsEkbrpb/0M/Ry+cOr1 qK0PhBdwBOsmAcocXEvTxPjZ3ZI66lklaAsz/yyt9mPq7CRv80IgM5YpVcONvKX+wMh/ 0bgatd5gC0JAbFHZ47ABMnMm7PiarV046kBR8KiMceL4BEBxq+IRQPJPpPMOeleC4sW9 DSCxrzPvUNudwWYuWYmKUOlqISpztAFyWEQjeObLJg8P+JrppPsYQxlu1U0EHkQ60rRw lU/Y1Nx0UZsqCtVv5iTBDkWuvRrEua/2em5+77cpvnEDveCCHQ78N+NG8sQShDq80APD r/ZA== X-Gm-Message-State: AOAM533Ne32QTAaQla0tlzg7OXU6VDOVd6MfcCE3MqO8s+OIChqJlvHW 850U8KNq0a6VmrRYimpzml+V/JOSdFdbQIroq7kKknT2iSw= X-Google-Smtp-Source: ABdhPJxrxSdDItjPQ99nIOuu7IHqV3x3UQ0/Jj4m2AzDoVQ+IA5ajcmfHBC+iyVX3WBFhJiWWG+oicu+osLCzbDcJzU= X-Received: by 2002:a25:9843:: with SMTP id k3mr7032111ybo.466.1597329041136; Thu, 13 Aug 2020 07:30:41 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 13 Aug 2020 07:30:40 -0700 In-Reply-To: <83mu2yn131.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185030 Archived-At: Eli Zaretskii writes: > The variable display-line-numbers is not a simple boolean, it can have > several values. I think you intended to show absolute line numbers in > this case, so just testing whether display-line-numbers is non-nil is > not enough. Similarly, restoring the original setting needs more than > just a call to display-line-numbers-mode. Right, you are completely correct of course. I suppose we would also have to consider that the user might have nlinum, linum, and possibly other conflicting modes activated. I should have been more clear that this was more a proof of concept to see if the idea would fly. > And this needs a NEWS entry. Yup. > Other than that, if someone wants this optional feature, why not? Thanks. Best regards, Stefan Kangas