From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#44529: [PATCH] Convert apropos-internal from C to Lisp Date: Mon, 9 Nov 2020 12:44:26 -0800 Message-ID: References: <83tuty4iyv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25815"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44529@debbugs.gnu.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 09 21:45:33 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kcE2f-0006c8-As for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 Nov 2020 21:45:33 +0100 Original-Received: from localhost ([::1]:56366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcE2e-0000Iz-BY for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 Nov 2020 15:45:32 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53540) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcE2A-0000Ik-Dt for bug-gnu-emacs@gnu.org; Mon, 09 Nov 2020 15:45:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52388) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kcE2A-0000Zv-3y for bug-gnu-emacs@gnu.org; Mon, 09 Nov 2020 15:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kcE2A-0000U2-0v for bug-gnu-emacs@gnu.org; Mon, 09 Nov 2020 15:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Nov 2020 20:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44529 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44529-submit@debbugs.gnu.org id=B44529.16049546741806 (code B ref 44529); Mon, 09 Nov 2020 20:45:01 +0000 Original-Received: (at 44529) by debbugs.gnu.org; 9 Nov 2020 20:44:34 +0000 Original-Received: from localhost ([127.0.0.1]:35701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcE1i-0000T3-4l for submit@debbugs.gnu.org; Mon, 09 Nov 2020 15:44:34 -0500 Original-Received: from mail-ej1-f54.google.com ([209.85.218.54]:38001) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcE1g-0000Sq-KQ for 44529@debbugs.gnu.org; Mon, 09 Nov 2020 15:44:33 -0500 Original-Received: by mail-ej1-f54.google.com with SMTP id za3so14262852ejb.5 for <44529@debbugs.gnu.org>; Mon, 09 Nov 2020 12:44:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=5M9yLJWbBkmeVOFAeMdkmbOQs+5y5mCmOnz8GMQJSuI=; b=DSALhiseIQXUgjSuuW2QEIaLZSKBWOiGyzWak6zuY9N3fHJoiLGSlQlzkjwS696yNR COSK8DqiJH/8wJ95i4/fIhZhpTVMpOLs226kWTikJbxZQBTubLNzhlnVH/2MpSeYIVSu a1iZJGGTektHkE83qJdUbMdsFsY5QvuIQ/QtlUNpAVdga6hb8RRbu1kn6cHqaA0p47QB An39KZOg97AvraBC02OQZGfsjpXHUgDjhkS+CtQVQJFs/0EZlm4qKcbjULFl/wmp7F+f RWxYzTmdT0bOQQPu0XTXNg6VoNACMrNlXTWMuAHoij1UNj5h58ZSVTWE8oSZoTT7ttuu axWw== X-Gm-Message-State: AOAM533/sSaMqgruMvZTu2bcMo1aLPfhQM706fQ1Sy2ONAhJB1nyKpiS aJ1wKStyAfby+EmcqUAI10B8d4opXoz61oawTPk= X-Google-Smtp-Source: ABdhPJyXNIyIdbeVRCXkUEGs44ulCryJ5yFqxra6Ex8UJ1Tj/IQx8sF08imld2AZH4w0M8nGcfanRI3/5SqeWSf+r9k= X-Received: by 2002:a17:906:a00c:: with SMTP id p12mr17425523ejy.249.1604954666905; Mon, 09 Nov 2020 12:44:26 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 9 Nov 2020 12:44:26 -0800 In-Reply-To: <83tuty4iyv.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192975 Archived-At: Eli Zaretskii writes: >> (benchmark-run 10 >> (apropos "x")) >> => (3.846117816 131 1.092690677) ; C >> => (4.218219444 145 1.2153865740000003) ; Lisp > > 20% slowdown is not negligible, at least not in principle. Let's wait > for more people to voice their opinions on this aspect. Unless I'm missing something, the slowdown should be around 10%. (FWIW, the figure of 0.38 or 0.42 seconds is for the more unlikely string with one character. In the more realistic scenario with a slightly longer string, we see a difference between 0.012 and 0.013 seconds.) > A bother: apropos.el is not preloaded, so please double-check that > none of the preloaded files call apropos-internal, otherwise that > would mean we need to preload apropos.el, which I think is > undesirable. I only see one call in a preloaded file: ./lisp/progmodes/elisp-mode.el:873: (dolist (sym (apropos-internal regexp)) (This is from a `cl-defmethod' for `xref-backend-apropos'.) Does this mean we have to preload apropos.el? I don't understand how, so I'm probably missing something. Thanks for commenting.